From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail03.groups.io (mail03.groups.io [45.79.227.220]) by spool.mail.gandi.net (Postfix) with ESMTPS id 6E9E17803D9 for ; Thu, 11 Apr 2024 08:40:32 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=5jEbKmrzeThrEVvm0PywGU3Zwql5fBZEdT6A4+jBOEk=; c=relaxed/simple; d=groups.io; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Transfer-Encoding; s=20240206; t=1712824831; v=1; b=PqrGWPd/8jpg7sTOvAeiNzdwCI+qoii2SqNe2ekr7+RTOBDol/oK8o9L+SStrI0l6uo3kn55 NANVa3FX/76zFAdImAJtw02I6bznvR0jVTsQ382vWHJ97XNhyGAg1FjF7HiFmXMdjo3Pq4Kawoi y7/L0r0sodjoxnGDM8C5cCCGeZDx8sIWiD4q0PY9dWIU1fd2zqmwTuJwSnn2xfj7Bt32nnPxYFo xgIhqIvi8+byIz+Wg+AM8vqtjeK2HEbPpwN+qSitrWybG/vZTmyJPGMNW0SjzgfMbUvVE6Ng9xJ okd4yXWr8W2ax2tcPkFR8UhBufR3pC40niq6SF6ZC9eUw== X-Received: by 127.0.0.2 with SMTP id XfC6YY7687511xlY5OWSSqp7; Thu, 11 Apr 2024 01:40:31 -0700 X-Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.17]) by mx.groups.io with SMTP id smtpd.web11.12789.1712824830314243329 for ; Thu, 11 Apr 2024 01:40:30 -0700 X-CSE-ConnectionGUID: htcYSZtfTLu+0CCjG1mxvQ== X-CSE-MsgGUID: xtCg93mYRoqjlnkT+8a3hQ== X-IronPort-AV: E=McAfee;i="6600,9927,11039"; a="8329900" X-IronPort-AV: E=Sophos;i="6.07,193,1708416000"; d="scan'208";a="8329900" X-Received: from fmviesa006.fm.intel.com ([10.60.135.146]) by orvoesa109.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Apr 2024 01:40:30 -0700 X-CSE-ConnectionGUID: g4tQiVFgSHO8QPdFtThQ2g== X-CSE-MsgGUID: WavADAgaRiK2HrOck92J8w== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,193,1708416000"; d="scan'208";a="20835901" X-Received: from saiphani-mobl.gar.corp.intel.com ([10.247.18.58]) by fmviesa006-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Apr 2024 01:40:27 -0700 From: "Sai Phanindra Gandikota" To: devel@edk2.groups.io Cc: Gandikota Sai Phanindra <102981786+saiphanindrag@users.noreply.github.com>, Ray Ni , Liming Gao , Sai Phanindra Gandikota Subject: [edk2-devel] [PATCH] MdeModulePkg/SdMmcPciHcDxe: Update switch to highspeed timing flow Date: Thu, 11 Apr 2024 14:10:16 +0530 Message-Id: <51e3cf1362f5507026ddf07e8ffff6c7044caf82.1712824811.git.sai.phanindra.gandikota@intel.com> MIME-Version: 1.0 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Thu, 11 Apr 2024 01:40:30 -0700 Resent-From: sai.phanindra.gandikota@intel.com Reply-To: devel@edk2.groups.io,sai.phanindra.gandikota@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: 5xiSxflcSSeiTbxrMVYsUvcHx7686176AA= Content-Transfer-Encoding: 8bit X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b="PqrGWPd/"; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.227.220 as permitted sender) smtp.mailfrom=bounce@groups.io From: Gandikota Sai Phanindra <102981786+saiphanindrag@users.noreply.github.com> Switch to DDR50 speed mode is failing with the existing code flow. Exiting flow sets Bus width first then bus timing and clock frequency, with this flow switch to DDR50 speed mode is failing. After updating the flow to set the bus timing and clock frequency then bus width resolved the issue and switch to DDR50 is successful. Cc: Ray Ni Cc: Liming Gao Signed-off-by: Sai Phanindra Gandikota --- MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/EmmcDevice.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/EmmcDevice.c b/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/EmmcDevice.c index a392a4e31a..2bca6da3db 100644 --- a/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/EmmcDevice.c +++ b/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/EmmcDevice.c @@ -833,12 +833,12 @@ EmmcSwitchToHighSpeed ( IsDdr = FALSE; } - Status = EmmcSwitchBusWidth (PciIo, PassThru, Slot, Rca, IsDdr, BusMode->BusWidth); + Status = EmmcSwitchBusTiming (PciIo, PassThru, Slot, Rca, BusMode->DriverStrength, BusMode->BusTiming, BusMode->ClockFreq); if (EFI_ERROR (Status)) { return Status; } - return EmmcSwitchBusTiming (PciIo, PassThru, Slot, Rca, BusMode->DriverStrength, BusMode->BusTiming, BusMode->ClockFreq); + return EmmcSwitchBusWidth (PciIo, PassThru, Slot, Rca, IsDdr, BusMode->BusWidth); } /** -- 2.38.1.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#117626): https://edk2.groups.io/g/devel/message/117626 Mute This Topic: https://groups.io/mt/105458662/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-