From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web12.3758.1586411340818454319 for ; Wed, 08 Apr 2020 22:49:01 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: arm.com, ip: 217.140.110.172, mailfrom: ard.biesheuvel@arm.com) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 5202E7FA; Wed, 8 Apr 2020 22:49:00 -0700 (PDT) Received: from [10.37.8.121] (unknown [10.37.8.121]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 271CA3F68F; Wed, 8 Apr 2020 22:53:11 -0700 (PDT) Subject: Re: [PATCH edk2-platforms 0/2] SynQuacer: fix driver model integration of NetSec To: Leif Lindholm Cc: devel@edk2.groups.io, Samer.El-Haj-Mahmoud@arm.com References: <20200408161138.18289-1-ard.biesheuvel@arm.com> <20200408162607.GW14075@vanye> From: "Ard Biesheuvel" Message-ID: <52332a8a-1e46-cee0-ca17-4c213d66bf0d@arm.com> Date: Thu, 9 Apr 2020 07:48:57 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: <20200408162607.GW14075@vanye> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit On 4/8/20 6:26 PM, Leif Lindholm wrote: > On Wed, Apr 08, 2020 at 18:11:36 +0200, Ard Biesheuvel wrote: >> Currently, the way the SynQuacer NetSec driver implements the EFI driver >> model is slightly quirky. Two changes are needed to move it closer to the >> intent of the driver model, which is the ability to boot using only the >> drivers that are required to drive the devices that are needed at boot. >> This series does not complete the picture entirely yet for SynQuacer, and >> it still relies on the unconditional EfiBootManagerConnectAll() call that >> exists in the PlatformBootManagerLib implementation in ArmPkg. This is left >> for future work. >> >> Ard Biesheuvel (2): >> Silicon/SynQuacer/PlatformDxe: defer device registration until >> EndOfDxe >> Silicon/SynQuacer/NetsecDxe: move device path to root device > > LGTM. > > For the series: > Reviewed-by: Leif Lindholm > > Thanks. Series pushed.