public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Ni, Ruiyu" <ruiyu.ni@Intel.com>
To: Shenglei Zhang <shenglei.zhang@intel.com>, edk2-devel@lists.01.org
Cc: Michael D Kinney <michael.d.kinney@intel.com>,
	Liming Gao <liming.gao@intel.com>
Subject: Re: [PATCH 6/8] IntelFrameworkPkg: Remove the redundant INFs
Date: Wed, 14 Nov 2018 11:12:12 +0800	[thread overview]
Message-ID: <52346a9d-6ec5-0048-ed87-a7038f1b708c@Intel.com> (raw)
In-Reply-To: <20181113083518.6824-7-shenglei.zhang@intel.com>

On 11/13/2018 4:35 PM, Shenglei Zhang wrote:
> All INFs of unused Library instances in IntelFrameworkPkg
> are removed as they are not actually used.
> https://bugzilla.tianocore.org/show_bug.cgi?id=1190
> 
> Cc: Liming Gao <liming.gao@intel.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
> ---
>   IntelFrameworkPkg/IntelFrameworkPkg.dsc | 7 -------
>   1 file changed, 7 deletions(-)
> 
> diff --git a/IntelFrameworkPkg/IntelFrameworkPkg.dsc b/IntelFrameworkPkg/IntelFrameworkPkg.dsc
> index bd5df8c5d9..802a80e3eb 100644
> --- a/IntelFrameworkPkg/IntelFrameworkPkg.dsc
> +++ b/IntelFrameworkPkg/IntelFrameworkPkg.dsc
> @@ -63,13 +63,6 @@
>   #       generated for it, but the binary will not be put into any firmware volume.
>   #
>   ###################################################################################################
> -[Components]
> -  IntelFrameworkPkg/Library/DxeIoLibCpuIo/DxeIoLibCpuIo.inf
> -  IntelFrameworkPkg/Library/FrameworkUefiLib/FrameworkUefiLib.inf
> -  IntelFrameworkPkg/Library/DxeSmmDriverEntryPoint/DxeSmmDriverEntryPoint.inf
> -  IntelFrameworkPkg/Library/PeiSmbusLibSmbusPpi/PeiSmbusLibSmbusPpi.inf
> -  IntelFrameworkPkg/Library/PeiHobLibFramework/PeiHobLibFramework.inf
> -
>   [BuildOptions]
>     *_*_*_CC_FLAGS = -D DISABLE_NEW_DEPRECATED_INTERFACES
>   
> 
Shenglei,
You cannot remove the INF in the separate patch like this.
You should either put this patch in the first patch in your serial,
or combine the DSC change with your library removal.
The goal is the the build won't fail when committing the patches one by one.

-- 
Thanks,
Ray


  reply	other threads:[~2018-11-14  3:10 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-13  8:35 [PATCH 0/8] IntelFrameworkPkg: Remove unused library instances Shenglei Zhang
2018-11-13  8:35 ` [PATCH 1/8] IntelFrameworkPkg/DxeIoLibCpuIo: Remove DxeIoLibCpuIo Shenglei Zhang
2018-11-13  8:35 ` [PATCH 2/8] IntelFrameworkPkg/Library: Remove DxeSmmDriverEntryPoint Shenglei Zhang
2018-11-13  8:35 ` [PATCH 3/8] IntelFrameworkPkg/FrameworkUefiLib: Remove FrameworkUefiLib Shenglei Zhang
2018-11-13  8:35 ` [PATCH 4/8] IntelFrameworkPkg/PeiHobLibFramework: Remove PeiHobLibFramework Shenglei Zhang
2018-11-13  8:35 ` [PATCH 5/8] IntelFrameworkPkg/PeiSmbusLibSmbusPpi: Remove PeiSmbusLibSmbusPpi Shenglei Zhang
2018-11-13  8:35 ` [PATCH 6/8] IntelFrameworkPkg: Remove the redundant INFs Shenglei Zhang
2018-11-14  3:12   ` Ni, Ruiyu [this message]
2018-11-14  3:32     ` Zhang, Shenglei
2018-11-14  5:18       ` Kinney, Michael D
2018-11-19  5:15         ` Gao, Liming
2018-11-19 20:05           ` Kinney, Michael D
2018-11-13  8:35 ` [PATCH 7/8] MdePkg: Remove DxeIoLibCpuIo in comments Shenglei Zhang
2018-11-13  8:35 ` [PATCH 8/8] Vlv2TbltDevicePkg: Remove DxeSmmDriverEntryPoint in DSCs Shenglei Zhang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52346a9d-6ec5-0048-ed87-a7038f1b708c@Intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox