From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.88; helo=mga01.intel.com; envelope-from=ruiyu.ni@intel.com; receiver=edk2-devel@lists.01.org Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 0862A2118FF3D for ; Tue, 13 Nov 2018 19:10:47 -0800 (PST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 13 Nov 2018 19:10:47 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,230,1539673200"; d="scan'208";a="279639617" Received: from ray-dev.ccr.corp.intel.com (HELO [10.239.9.22]) ([10.239.9.22]) by fmsmga005.fm.intel.com with ESMTP; 13 Nov 2018 19:10:46 -0800 To: Shenglei Zhang , edk2-devel@lists.01.org Cc: Michael D Kinney , Liming Gao References: <20181113083518.6824-1-shenglei.zhang@intel.com> <20181113083518.6824-7-shenglei.zhang@intel.com> From: "Ni, Ruiyu" Message-ID: <52346a9d-6ec5-0048-ed87-a7038f1b708c@Intel.com> Date: Wed, 14 Nov 2018 11:12:12 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: <20181113083518.6824-7-shenglei.zhang@intel.com> Subject: Re: [PATCH 6/8] IntelFrameworkPkg: Remove the redundant INFs X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Nov 2018 03:10:48 -0000 Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit On 11/13/2018 4:35 PM, Shenglei Zhang wrote: > All INFs of unused Library instances in IntelFrameworkPkg > are removed as they are not actually used. > https://bugzilla.tianocore.org/show_bug.cgi?id=1190 > > Cc: Liming Gao > Cc: Michael D Kinney > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Shenglei Zhang > --- > IntelFrameworkPkg/IntelFrameworkPkg.dsc | 7 ------- > 1 file changed, 7 deletions(-) > > diff --git a/IntelFrameworkPkg/IntelFrameworkPkg.dsc b/IntelFrameworkPkg/IntelFrameworkPkg.dsc > index bd5df8c5d9..802a80e3eb 100644 > --- a/IntelFrameworkPkg/IntelFrameworkPkg.dsc > +++ b/IntelFrameworkPkg/IntelFrameworkPkg.dsc > @@ -63,13 +63,6 @@ > # generated for it, but the binary will not be put into any firmware volume. > # > ################################################################################################### > -[Components] > - IntelFrameworkPkg/Library/DxeIoLibCpuIo/DxeIoLibCpuIo.inf > - IntelFrameworkPkg/Library/FrameworkUefiLib/FrameworkUefiLib.inf > - IntelFrameworkPkg/Library/DxeSmmDriverEntryPoint/DxeSmmDriverEntryPoint.inf > - IntelFrameworkPkg/Library/PeiSmbusLibSmbusPpi/PeiSmbusLibSmbusPpi.inf > - IntelFrameworkPkg/Library/PeiHobLibFramework/PeiHobLibFramework.inf > - > [BuildOptions] > *_*_*_CC_FLAGS = -D DISABLE_NEW_DEPRECATED_INTERFACES > > Shenglei, You cannot remove the INF in the separate patch like this. You should either put this patch in the first patch in your serial, or combine the DSC change with your library removal. The goal is the the build won't fail when committing the patches one by one. -- Thanks, Ray