From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mx.groups.io with SMTP id smtpd.web11.66921.1672761244776762459 for ; Tue, 03 Jan 2023 07:54:04 -0800 Authentication-Results: mx.groups.io; dkim=fail reason="body hash did not verify" header.i=@linux.microsoft.com header.s=default header.b=jEKuFNcr; spf=pass (domain: linux.microsoft.com, ip: 13.77.154.182, mailfrom: mikuback@linux.microsoft.com) Received: from [192.168.4.22] (unknown [47.201.8.94]) by linux.microsoft.com (Postfix) with ESMTPSA id A94BE20B92A6; Tue, 3 Jan 2023 07:54:03 -0800 (PST) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com A94BE20B92A6 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1672761244; bh=g8Dumt5IiffrY+a4nt7Tnjo09qkJBgls+MDCIQb0VtY=; h=Date:Subject:To:References:From:In-Reply-To:From; b=jEKuFNcrMECgl1YpblUPNWbqnNK5w3xttyslMORvO2Him+EByhG3u2o54UTWIGV8b 2NrSqYqq3k2mq0XJI9E3PtkzBI1aw77tOOXbbVtchEZTBenrSTMaQ68VOtwgWtxO+I bUPVC9Vl5CzEo8dg34LPg2MxuMLDOoSeCrvs2qc0= Message-ID: <5238694f-8a81-b421-25ca-a47122084f32@linux.microsoft.com> Date: Tue, 3 Jan 2023 10:54:02 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 6.2; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.13.1 Subject: Re: [edk2-devel] [PATCH v8 0/3] Add code coverage support for GCC/MSVC To: devel@edk2.groups.io, michael.d.kinney@intel.com, "Guo, Gua" References: <17367A3BDC508760.4716@groups.io> From: "Michael Kubacki" In-Reply-To: Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable I agree, the results look great. On 1/2/2023 1:01 PM, Michael D Kinney wrote: > Hi Gua, >=20 > Thanks!!!The results for both VS and GCC builds in Azure look really good= . >=20 > It even visually shows some branches and APIs calls missing coverage in= =20 > the unit tests for the SafeIntLib. >=20 > https://dev.azure.com/tianocore/edk2-ci/_build/results?buildId=3D75036&vi= ew=3Dcodecoverage-tab=20 > >=20 > Search for =E2=80=9CSafeIntLib=E2=80=9D >=20 > Mike >=20 > *From:*Guo, Gua > *Sent:* Monday, January 2, 2023 3:57 AM > *To:* devel@edk2.groups.io; Guo, Gua ; Kinney,=20 > Michael D ; Michael Kubacki=20 > > *Subject:* RE: [edk2-devel] [PATCH v8 0/3] Add code coverage support for= =20 > GCC/MSVC >=20 > @Kinney, Michael D and @Michael=20 > Kubacki everything fix now. >=20 > Leverage ReportGenerator=20 > https://marketplace.visualstudio.com/items?itemName=3DPalmmedia.reportgen= erator=20 > =20 > to create code coverage pipeline. >=20 > PR: https://github.com/tianocore/edk2/pull/3349=20 > >=20 > =E2=80=9CJob2 (Build Agent : windows-2019)=E2=80=9D must require for Wind= ows build agent=20 > because ReportGenerator is =E2=80=9CWindows dot-net=E2=80=9D specific. So= I add some=20 > dependency to let it support for both GCC5 and VS2019. >=20 > * Windows-VS2019 flow >=20 > o Summary URL: > https://dev.azure.com/tianocore/edk2-ci/_build/results?buildId=3D= 75021&view=3Dresults > >=20 > o CI/CD Flow:=20 >=20 > * Ubuntu-GCC5 flow >=20 > o Summary URL: > https://dev.azure.com/tianocore/edk2-ci/_build/results?buildId=3D= 75020&view=3Dresults > >=20 > o CI/CD Flow:=20 >=20 > Thanks, >=20 > Gua >=20 > -----Original Message----- > From: devel@edk2.groups.io =20 > > On Behalf Of Guo, Gu= a > Sent: Monday, January 2, 2023 7:25 PM > To: devel@edk2.groups.io > Cc: Guo, Gua > > Subject: [edk2-devel] [PATCH v8 0/3] Add code coverage support for GCC/MS= VC >=20 > From: Gua Guo > >=20 > V1: Add coverage option for GCC >=20 > V2: Add ReadMe.md for how to generate coverage report >=20 > V3: Add VS2019 and GCC code coverage support >=20 > V4: Add VS2019 and GCC Azure CI/CD support >=20 > V5: Fix some typo and some flow issue >=20 > V6: Remove html coverage information >=20 > =C2=A0 - Due to python 3.11 install lxml will be failure, >=20 > =C2=A0 pycobertura need it to convert cobertura format to >=20 > =C2=A0 html file. >=20 > =C2=A0 - Add section for developer how to use OpenCppCoverage >=20 > =C2=A0 on IDE Visual Studio >=20 > V7: Remove redundant code and add code coverage pipeline support >=20 > =C2=A0 - Remove redundant code on HostBasedUnitTestRunner.py >=20 > =C2=A0 - Unify coding rule on HostBasedUnitTestRunner.py >=20 > =C2=A0 - Add CodeCoverage Azure pipeline support for GCC5 and VS2019 >=20 > Gua Guo (3): >=20 > =C2=A0 UnitTestFrameworkPkg: Add code coverage support for GCC >=20 > =C2=A0 BaseTools/Plugin: Add coverage support for Unit Test >=20 > =C2=A0 .azurepipelines: Install code coverage tool >=20 > .azurepipelines/Ubuntu-GCC5.yml=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 |=C2=A0=C2=A0 5 +- >=20 > .azurepipelines/Windows-VS2019.yml=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0 |=C2=A0=C2=A0 5 + >=20 > .../templates/pr-gate-build-job.yml=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0 |=C2=A0 36 +++++++ >=20 > .azurepipelines/templates/pr-gate-steps.yml=C2=A0=C2=A0 |=C2=A0=C2=A0 4 + >=20 > .../HostBasedUnitTestRunner.py=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 | 101 +++++++++++++++++- >=20 > UnitTestFrameworkPkg/ReadMe.md=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 = =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0|=C2=A0 41 +++++++ >=20 > .../UnitTestFrameworkPkg.ci.yaml=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 |=C2=A0=C2=A0 1 + >=20 > .../UnitTestFrameworkPkgHost.dsc.inc=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0 |=C2=A0=C2=A0 3 +- >=20 > pip-requirements.txt=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0 |=C2=A0=C2=A0 2 + >=20 > 9 files changed, 195 insertions(+), 3 deletions(-) >=20 > --=20 >=20 > 2.31.1.windows.1 >=20 >=20