From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from alexa-out-sd-01.qualcomm.com (alexa-out-sd-01.qualcomm.com [199.106.114.38]) by mx.groups.io with SMTP id smtpd.web11.33734.1643642223905951994 for ; Mon, 31 Jan 2022 07:17:04 -0800 Authentication-Results: mx.groups.io; dkim=fail reason="signature has expired" header.i=@quicinc.com header.s=qcdkim header.b=PQ4vbwu3; spf=pass (domain: quicinc.com, ip: 199.106.114.38, mailfrom: quic_rcran@quicinc.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; i=@quicinc.com; q=dns/txt; s=qcdkim; t=1643642223; x=1675178223; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=rh3mS9lZmDBEERoYdp+Vx2cLxdC77GxRhRRbQSN+udI=; b=PQ4vbwu3knBre5EAvw7E9zBLHrjkK6+RiZSpePJk7dFRw0VStFHi1VIk zznGb9huY1sB2dmfyGaa7iRZXo3yTr4U2u/rWXboyMUhQRyUhxx9hY29T BFQ+/zfpKJwN3QXYgnJXQ6P7Q8W1Mg0QgS2IluVTif4XKGhrhriKWnRpO g=; Received: from unknown (HELO ironmsg-SD-alpha.qualcomm.com) ([10.53.140.30]) by alexa-out-sd-01.qualcomm.com with ESMTP; 31 Jan 2022 07:17:03 -0800 X-QCInternal: smtphost Received: from nasanex01b.na.qualcomm.com ([10.46.141.250]) by ironmsg-SD-alpha.qualcomm.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 31 Jan 2022 07:17:03 -0800 Received: from [10.110.65.129] (10.80.80.8) by nasanex01b.na.qualcomm.com (10.46.141.250) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.922.19; Mon, 31 Jan 2022 07:17:02 -0800 Message-ID: <52503b9c-c820-15b3-65c5-f2cc110f5027@quicinc.com> Date: Mon, 31 Jan 2022 08:17:02 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [edk2-devel] [PATCH v3 5/8] ArmVirtPkg/Kvmtool: Add DSDT ACPI table To: , CC: Ard Biesheuvel , Sami Mujawar References: <20220128154103.20752-1-Pierre.Gondois@arm.com> <20220128154103.20752-6-Pierre.Gondois@arm.com> From: "Rebecca Cran" In-Reply-To: <20220128154103.20752-6-Pierre.Gondois@arm.com> Return-Path: quic_rcran@quicinc.com X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nasanex01b.na.qualcomm.com (10.46.141.250) Content-Language: en-US Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit On 1/28/22 08:41, PierreGondois wrote: > + Differentiated System Description Table Fields (DSDT) > + > + Copyright (c) 2021 - 2022, ARM Ltd. All rights reserved.
> + SPDX-License-Identifier: BSD-2-Clause-Patent > + > +**/ > + > +DefinitionBlock ("DsdtTable.aml", "DSDT", 1, "ARMLTD", "ARM-KVMT", 1) { The Revision field should probably be 2, not 1. ACPI 6.4 says: 2. This field also sets the global integer width for the AML interpreter. Values less than two will cause the inter- preter to use 32-bit integers and math. Values of two and greater will cause the interpreter to use full 64-bit integers and math. -- Rebecca Cran