From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f177.google.com (mail-pg1-f177.google.com [209.85.215.177]) by mx.groups.io with SMTP id smtpd.web12.605.1624494494726608512 for ; Wed, 23 Jun 2021 17:28:14 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@gmail.com header.s=20161025 header.b=lJ485MPr; spf=pass (domain: gmail.com, ip: 209.85.215.177, mailfrom: kuqin12@gmail.com) Received: by mail-pg1-f177.google.com with SMTP id m2so3211474pgk.7 for ; Wed, 23 Jun 2021 17:28:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=+wTYFzV1B0cyrLf/rSsOCOk5xUI4Hugp1wNn16fP7Og=; b=lJ485MPryebVV72B5kDsMB8F3udK0MQE9DrGAMSiCWYhtDmFtjXQPhyxOZdn9UK7eS HlUDL0mytaYmLoRN60RyU0gDRqMTNI5Vdrd6S+1x1c/mYSGTEsJy3RqsI9zJArwtuxrD vVj3Q693W/2wz3JahS24FTQHVKLGCnLXByDcHAHtWGtUfyAdSSKMSKjrwtTLnxSo1McT 56tk3aANPMaitPXI1vSJPbeGcWfDfTu6EipohJ0KNZlOqK6rhmmcVFaTVGyC4Stl6TMU YYSn1LjCQgTSqnBIHEpagqkXFITF05aN56OKsTwCcNr66GXrgj1ZrnwUzqq3WqI4QCFh eWYA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=+wTYFzV1B0cyrLf/rSsOCOk5xUI4Hugp1wNn16fP7Og=; b=OlZEEcq8zDSAAP08uFF+okB9sWn4HE1VrXpl7x7ywccwUPM4XGKzxP4bduP+mCicCv vsltbSGWdXpfKDohr6skRge1GLPNWVv2eZIX8/5ATeouN2atZn7zKN2nMMni0pmkVbaA DE4aEBwNlpSMs0MzM2XV/wPVWuLuRgor2nt8w2bc/tMEF24OytpkWFHPCoYSbrodHllR sOWVU2vx1m9JCclPT36MLICgrjCSTImMd3KLlJAGTcnw9pxkxOQvZHcsaXDwm7NqYx4a d2Y8vi6e135PX0Ql8cDaB1Q57eH8L0na56t/C5BGYHZTU+RxjTpbix1WNbmLQCljiGJl iMfQ== X-Gm-Message-State: AOAM531r9GOpFSERXb6YkuaXidnedBTTiYRFCwpQxQa1OQy2GW53n1la gk/e58sF6BCdWoRYvid/Wd0= X-Google-Smtp-Source: ABdhPJyXoYFEDT4TKOMqt+rSOWSeUQ6c9Ua3+g+Br6HCc/mM2OgNPmZl5BX8Te3U6rYOZZECXHlExg== X-Received: by 2002:a63:f01:: with SMTP id e1mr2099793pgl.232.1624494494370; Wed, 23 Jun 2021 17:28:14 -0700 (PDT) Return-Path: Received: from [192.168.50.18] ([50.35.88.161]) by smtp.gmail.com with ESMTPSA id u38sm248851pgm.14.2021.06.23.17.28.13 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 23 Jun 2021 17:28:13 -0700 (PDT) Subject: Re: [edk2-devel] [PATCH v2 1/6] EDK2 Code First: PI Specification: EFI_MM_COMMUNICATE_HEADER Update To: Laszlo Ersek , devel@edk2.groups.io Cc: Michael D Kinney , Liming Gao , Zhiguang Liu , Andrew Fish , Leif Lindholm , Hao A Wu References: <20210618090243.2517-1-kuqin12@gmail.com> <20210618090243.2517-2-kuqin12@gmail.com> <82e2e6ef-2334-0b12-2b5d-27aa8fdac783@redhat.com> From: "Kun Qin" Message-ID: <52a4494b-f3b0-1cad-8d48-82a96990298a@gmail.com> Date: Wed, 23 Jun 2021 17:28:13 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <82e2e6ef-2334-0b12-2b5d-27aa8fdac783@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit I can place this file under "CodeFirst" folder on the next round of patch series. It would be helpful to update the code-first process page so that others can be consistent on the process next time. Thanks, Kun On 06/23/2021 03:02, Laszlo Ersek wrote: > On 06/18/21 11:02, Kun Qin wrote: >> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3430 >> >> This change includes specification update markdown file that describes >> the proposed PI Specification v1.7 Errata A in detail and potential >> impact to the existing codebase. >> >> Cc: Michael D Kinney >> Cc: Liming Gao >> Cc: Zhiguang Liu >> Cc: Andrew Fish >> Cc: Laszlo Ersek >> Cc: Leif Lindholm >> Cc: Hao A Wu >> >> Signed-off-by: Kun Qin >> --- >> >> Notes: >> v2: >> - Updated change impact analysis regarding SmmLockBoxDxeLib [Hao] >> >> BZ3430-SpecChange.md | 90 ++++++++++++++++++++ >> 1 file changed, 90 insertions(+) > > Placing such a document in the edk2 root directory looks very strange to me. > > https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Code-First-Process#tianocore-github > > [...] Specification text changes are held within the affected source > repository, using the GitHub flavor of markdown, in a file (or split > across several files) with .md suffix [...] > > The wiki does not seem to specify what directory should contain the spec > change document. > > Should we create a "CodeFirst" top-level directory? > > Thanks, > Laszlo >