From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124])
 by mx.groups.io with SMTP id smtpd.web10.11539.1683707438229561509
 for <devel@edk2.groups.io>;
 Wed, 10 May 2023 01:30:38 -0700
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=LE4p6h30;
 spf=pass (domain: redhat.com, ip: 170.10.129.124, mailfrom: lersek@redhat.com)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1683707437;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=vRXtxKQAcy2drzhyiNE2yia0+vD88+ktgNlOC1uuGlk=;
	b=LE4p6h308AtzrUx1q9x8c7XXyCSP3IIOgxpwUaqrsfBAk4v1ba1pWQT6BSVaO4giRoVALQ
	4ijGOUDnn2jce1k1YNFjjuaWsEF9Pn921EXFx8mzQnlDQnIsZWnv7aivOUyycNGSFM1nys
	5Mw+AiX77klo87BzWC8KEqtMVfsk4A8=
Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com
 [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS
 (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 us-mta-353-wwvkLjaHORS0R4o1bUjLYw-1; Wed, 10 May 2023 04:30:32 -0400
X-MC-Unique: wwvkLjaHORS0R4o1bUjLYw-1
Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 7F11380B2BB;
	Wed, 10 May 2023 08:30:31 +0000 (UTC)
Received: from [10.39.192.106] (unknown [10.39.192.106])
	by smtp.corp.redhat.com (Postfix) with ESMTPS id 7269E1121314;
	Wed, 10 May 2023 08:30:28 +0000 (UTC)
Message-ID: <52aed2b3-98e3-c21f-0db4-dbd450e4c827@redhat.com>
Date: Wed, 10 May 2023 10:30:27 +0200
MIME-Version: 1.0
Subject: Re: [PATCH v2 01/12] MdeModulePkg/SataControllerDxe: Clean up error handling in Start()
To: Pedro Falcato <pedro.falcato@gmail.com>, devel@edk2.groups.io
Cc: Jian J Wang <jian.j.wang@intel.com>, Liming Gao
 <gaoliming@byosoft.com.cn>, Hao A Wu <hao.a.wu@intel.com>,
 Ray Ni <ray.ni@intel.com>
References: <20230509163212.291333-1-pedro.falcato@gmail.com>
 <20230509163212.291333-2-pedro.falcato@gmail.com>
From: "Laszlo Ersek" <lersek@redhat.com>
In-Reply-To: <20230509163212.291333-2-pedro.falcato@gmail.com>
X-Scanned-By: MIMEDefang 3.1 on 10.11.54.3
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Language: en-US
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit

On 5/9/23 18:32, Pedro Falcato wrote:
> Clean up error handling using cascading labels + goto.
> 
> (port of commit 379b179 + bcab714)
> 
> Cc: Jian J Wang <jian.j.wang@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Hao A Wu <hao.a.wu@intel.com>
> Cc: Ray Ni <ray.ni@intel.com>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Signed-off-by: Pedro Falcato <pedro.falcato@gmail.com>
> ---
>  .../Pci/SataControllerDxe/SataController.c    | 80 ++++++++-----------
>  1 file changed, 35 insertions(+), 45 deletions(-)

Reviewed-by: Laszlo Ersek <lersek@redhat.com>