From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM02-CY1-obe.outbound.protection.outlook.com (mail-cys01nam02on0054.outbound.protection.outlook.com [104.47.37.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 6CE9A21CF950C for ; Mon, 31 Jul 2017 12:36:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amdcloud.onmicrosoft.com; s=selector1-amd-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=G313l4N49uf85alQM3c76A+l2Se/3ZRO0AaRzS0Z30o=; b=HsljoINl0gy2h3S2GGf7Va6o7mfsIOsINVO5Mv0vHTbiy315oJBg1c9/9FOT6hBX0wXqQbhZUmc7xRVpMe9JPBLlejqnvK8FCjDoe92AdREppTJeCjausVqJaC87NoRzZ7ETvKGrVjOtpt2gzT5tJIvNuqtJgDxwaCDDmiiiIFU= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=brijesh.singh@amd.com; Received: from [10.236.136.62] (165.204.77.1) by SN1PR12MB0158.namprd12.prod.outlook.com (10.162.3.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.1.1304.22; Mon, 31 Jul 2017 19:38:34 +0000 Cc: brijesh.singh@amd.com, Tom Lendacky , Ard Biesheuvel , Laszlo Ersek , Jordan Justen To: edk2-devel@lists.01.org References: <1501529474-20550-1-git-send-email-brijesh.singh@amd.com> <1501529474-20550-4-git-send-email-brijesh.singh@amd.com> From: Brijesh Singh Message-ID: <52bcbfac-028e-c4f4-7dac-e0cde14e82f0@amd.com> Date: Mon, 31 Jul 2017 14:38:31 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <1501529474-20550-4-git-send-email-brijesh.singh@amd.com> X-Originating-IP: [165.204.77.1] X-ClientProxiedBy: CY4PR04CA0080.namprd04.prod.outlook.com (10.171.243.173) To SN1PR12MB0158.namprd12.prod.outlook.com (10.162.3.145) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: c52e7f56-d622-47b0-b712-08d4d84bbbba X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(2017030254152)(48565401081)(300000503095)(300135400095)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095); SRVR:SN1PR12MB0158; X-Microsoft-Exchange-Diagnostics: 1; SN1PR12MB0158; 3:IAZhozYdp8CXRH/ZMnFBz3Q/QabRA7Dyv4xlMBAAmInXWh66xFzHH/LfoJGnFh5K2ytBaLELpCf/94D0exiKPUgnWUM1MIcU6Z63b3Pcb8ADN1B3aZetx5dvJi1sAUzuCMGJDJT+5bhzaL8GujL7K0epVTPqMR3vkaZ0wDQVGXYhgwdmtzxE5900kPIQn1FdzSir/M+ZkvyAIn96ZmVDX66eExJIY+4Ipcedg7c3LlG4hGbsPH5pf/mSw+GAizRGfNSbd8LryoYCkCdFlwbBR8RO2spbC1y2F2PxhkE85/G5GPmQr0mLJ2EfGMALqMkEGrEQp1WPRlnKVNOxmneEHerSDCR4JGNlZfNTmld3Js5FwsJF9GSGXfTlRGebXETGdAEnydK5l1xWAzGVB0LvHRhBsTG/zhRGmZkGEJGujVBlXBzgnA/fih8+JF87O0C14FDqIqS3AB6prIif5Yqshcg0CD5l9yvItvHYjUvfMOLL774I7cX+eADWVgduaEFcg3EmIYHU4xKp1N1cwUvPNFVfcwdKw+BUUIi11eRv8Euy+vDWCzuKWfXOvmB0nmUO8zoOBPc9xNR51/gpbqm0GgkO+k+H+hYNn+5oTYuZl1yjWkzEMnVXaY6zSSanNSBhtri9Y2yl/bc3kWOjNKihv+YDA3i6rs16Fqsm4JUC1zlmZgtmz2VMh6IwmJaLiT7+bhT8oYsA8uh+pNt7U0e8qofK//IeVy4mbUSA+R4fbHpIp7wi2E/z3lPXcA0FgLII7v34mfJ4TAqtWtrl0UObfU7b0Nhe7KfrFzIB/WPHk3s+UttykEKfGkkpwHOb8xuflJHI4t5jZzVPLn5O0UBP5g== X-MS-TrafficTypeDiagnostic: SN1PR12MB0158: X-Microsoft-Exchange-Diagnostics: 1; SN1PR12MB0158; 25:IaTJvdiFAmIKEnoJeUFmvMkHCmWDYPt7V2nHSDurEnRwPuyaIOLvCGt5PMjEPeR9iwEqUBSS3wWxgxryJ9REjV4wI6FuEJ/3hGXAovu0S+c1BGm5A7WDl29dV80p2975tErhBX/kQ0OuDWdC7R4Uaz28N4iycvuLadT+nSIcDUxiFDhMtM0tYNz9nPHcDVpuQxPNjBoaAQ2j8k1jMk0afbxFaWZiLx0SZ9ZLVy9BILymHXFKrf2BP2hVFFG4LbSVldgeta+gLy1N58+qcBN71fjTAORA5YnBmPhpxhqEFDq9GCd4V1cljHkidWfbbGQA63/KTxBTlaWDyTos4MQB+7AmULgJHtsqjNyjziOYuOnxcNU5FjTNgNVdoRWSiyS2MJPY8Afqwzrq211fmYcuKawxLB1IB3Oafk41q4p2g8dPaLsxJyDAyjgEtpx695Zj7S/QWTxSsUg9hYgoiasSKmgb8/Twplw3a/NNJT39sCWGpTjxZ9SiPKAzuV5jIoXEQaO3gvRtQ7WIqz5L+MO2vGREfNg1D/iGvSMm12NNemdVgnum58TePkyZ3OdlIm45gKW+ioS0iYTriG7KSv8vHCm53qm+3cafdMHu7+KHbWjQqaDM+qTsb4PzUzfR1s9R11Rj5z//ndgF0bx8OnYFRwER9HTrCL88ZuhYs8cADDiJE06jeaLLuCgCbaSZou6ycGSmBJVwDHIyH2QCgEm8UstM3nX7ATDZEemPkxNWKSQ5GK95247RTKvqVsuddhTEE/V+hW+piHbCxSdS5m/E0JHQHdoxkqPvIynvoTy+Y5GXiOewFyMm0IDkACZvkf+msD7ihTyOT2Ti4qEYqJdeKvYbW8+qBUPFz7OtaRh1nrjN3bMx57cKF9vXYPoYIG4Zs6ODZNIda3g7S2Y1SbYuw28OPIf1K9V1q3QPHHU80Lc= X-Microsoft-Exchange-Diagnostics: 1; SN1PR12MB0158; 31:r+mYN0SiI7QNWHb1x/xJrtNKeLDlpZsI8Ov4rpvCxakEfumhsm2u80GqwgQcAc0o2eXGj5vxuH1a2FhmTJmtwOWAJ4BVYN3HoiCB3DGBYJpFH2+pmZgik/xUvqAIze8DSe7xctUqwpktcC+2Y8dS5hvxuddICD6K8gbSnzG7k801Tr+dpCMZ50QeAdkVYKGEizt7lIlVnkX3cxUzHeKloPq9PYx5WR5rIpWNj8VX7uis9sx3UU5Z29oDzPVb6psDsX6p6YESVc9H4jDBHfaoVE52NKZP0+RYBPZpysaZLQMQG9YXqaRRrf/s3IdoxzC50j13mRthIrbkCGrnh/Zy5Ko2cdeUpPj3/lAuxUz6I5NduJLOcoIgylXrQXfyr2uRWTF5wXGZoiPWsRU+/DiSfrzU4WDxd7FCwqvarYDLcZWwinrTwTYfwod+Mc6H5X7Zc4WDBHCLLyPVzq1m+7TIb82HUd59kKNX+9IPhd6BR6JuenCMcxd61bP5GvH8dvf6WfT1cARNfRn1JoCY8pvMQs3tqn7+1LEBhe2ZWEjNafLt/4T926/dN18o3UmBvmu2viN3EQe78nvNkpM6Hfe0oaCrf7B7wc6DfvKsdK63+/RjQRLlmz7oJFUwmBiclPSPqyn+KtTo2UHZPqhBa0ZtzV143iotklqFi6Sj33AjuUA= X-Microsoft-Exchange-Diagnostics: 1; SN1PR12MB0158; 20:RI0xFi21qbbrmOn6ks2ehOzHqVoxNg6jJiQwkVVkUC1Dc4b6zybdJoiFwXnRn0xISbX2a33wxtR00FfkuNWEpJ+iJTT0PuzgaXq6WLTGJigxE9vYoWZVpYIogCa5mEHnGsoBU0Yc4PH+IL4ATxWixyg61k+/GsnnURAb9baqATDLYmHjX2sER2aJ5YQ1mJtw9pRlfbaSpw9bF4CJsOFBULhdMNIZRErfnrRZCnvhRTtVicAR3E0ksEa1TTBw4pssSlSR9CV2e2+JIJU6Vb2LEryqYoVvtckgCc52JP3ZTE3huILvMMY53TUdT6kg0I99/BCyg5vbLR4dh8LerLm/qcoffMS1P5W8jZjkuC1BKVgYuhL5n1tPvqtUqn9iEKuswSxT2/NR/90VMuNa6LieuIRXs9aZklbcifI7AxawTtGELWLQi1oneaNUW46PRDmqZoz9zKJilCGNm0m6zOf6Mgt7pMel/Pj3J/ITEwdW/t6eCGYvSMsXqCwRyqWGnFPs X-Exchange-Antispam-Report-Test: UriScan:(767451399110)(228905959029699); X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(601004)(2401047)(5005006)(8121501046)(93006095)(93001095)(3002001)(10201501046)(100000703101)(100105400095)(6055026)(6041248)(20161123555025)(20161123558100)(20161123560025)(20161123562025)(20161123564025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(6072148)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:SN1PR12MB0158; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:SN1PR12MB0158; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtTTjFQUjEyTUIwMTU4OzQ6L3ZzSDI5SmpyUzkzMktGa203M2FpbW9qUkto?= =?utf-8?B?OEpUSm1HQjR1bVJDRnVvYm9xOGQ1U2RqRW5XSDBqWTZZSG0xSTR1RTVSQ3Jp?= =?utf-8?B?L3lQcnVVZVhCaldMajA1YVNCRGljTmtqS0xYNjBWSXhNR2hRT2xoM29ycm1j?= =?utf-8?B?dGhiYlVqRGJFQkF6Y2tYZm03VzdKbE1DTklBeW14RU8yRHJSRnMvYkc0bSt6?= =?utf-8?B?UWtiYzdPQnJVMEZvT1pFZ2RnOTczNmkwZStYMW51VUFKSTJoSFU4czkyQ0Ix?= =?utf-8?B?dk9BUzhDSlNZK3JNSTh2ZGxhN0xkZVM0ejJwMGNBWkd5MjY4MWY5cDJaVWhp?= =?utf-8?B?WVhWdDdaNm9DTlZQSFZlMzY0RGpLZjQxRWgyYUhMa25wczkrUXI1VHBmQ2tP?= =?utf-8?B?MStrMmFvZFJ3ZjhTbTlKUHBMWm1ZTUEvUjZOWGpPQjhkdWl1YmNmVWtNbGJT?= =?utf-8?B?ZGx4Z3RycXVKSzBuSCtpZENUdEJKUTVKdVpKK1Qya1l4SW9nQ1BaR200QVZR?= =?utf-8?B?MmVwSjZwMlFoU2VDbTZ2aFRiTjR1TC9HTUk3VGVGeTJDQlhRU3MrdHVXNFZy?= =?utf-8?B?aWV0SG1IMzhneXFZNzZqTm1Ld1BsaWtrTTVSOWt0ZkNGRDhydHB5dDgxa0Vp?= =?utf-8?B?QzRRNFA0YjBMWERwdUhON1JBWGRWcEtmUUhJU29WOElTMlozNWNIMXR3Yy9z?= =?utf-8?B?Yk1TOUs4WllCOFk3VW45TnY5WklIYWxydEJUWnY4TUVVaUhEdFRLeCswUHhI?= =?utf-8?B?MGMwUXUyRk1EK2pIbjdsSmg3S25PNHJZRHhIV00xdkpJYWRXdWxkRmR1a0lv?= =?utf-8?B?WFlST0J3OHN1ZkxVWEdiUVVjL2pqNXpDNXBFN0JVTFd2c2xqMVhGNXRuWWNS?= =?utf-8?B?c29RdTlMOWFsV29aSERtdmlrZGxhZGJtSHRyc3VveWFyUC9JM2JtbVB0QnFq?= =?utf-8?B?T1I1amdkdWhOWGtKVlY3SHF2ZGFjbDZwc010dzNNOXFJNi94TDV3ZGtqaWZI?= =?utf-8?B?ZU1sQm02Wkx5Q1pHN2M3UDAzd1UxSVRDeVN5SHN5UGN3eGNzRm4yWUcyeDEz?= =?utf-8?B?dXRoSUpaM0tJMkJPTStGZFYyem42NmZRYmhOOWQzTUQvMGh2ZHh2b2RRLytz?= =?utf-8?B?cXprNTVBZEhPRHd2Y1h5SGF5MXhFdzkrK1V6RXFDTDNyZ0JNV0hhUjh0cXN4?= =?utf-8?B?R3FGUHF5VDlFQVN5QUV4WHhFWWQ2eVViYURwb0RUd2M2VzdPZFM1Qi95Z05C?= =?utf-8?B?V2VTZHAra2RxQzhJVVo3dWVhaDhCZHYydTZMRWcrUkN2TWtMWlBVYis2M3p1?= =?utf-8?B?YjBqeEl5SkVTYlMzOGxTU1RWN3RZNFNyUjRzallKK1VGY0RrSktNRXhnUlZQ?= =?utf-8?B?WUdra3UrU2xNVHdtajBqemN6WWtYWWcydytCeFc2R3JEOG53ZjlvaDltdXQ3?= =?utf-8?B?TVpKOE9rcDJIVXh2elUyUUFZbzZOT0xUcWRJc1JKcVlCQ2ltY2NsRStOKy9E?= =?utf-8?B?UUd6Wmw4TDBta0ZLcHhWWXFwQVg0MG5VMUlhQkpQQ3JuMnhreGtiRVJoU0Fn?= =?utf-8?B?ZnpIM1lSNkx5K0FsV21tRXBNRi9BMkszWElpV2hMVzhJdE5tSmdJT1RQMWRK?= =?utf-8?B?Rkp6TEdMVXRObEZUbTJ2aC9vbnY5djNyM3VZWjFJQXFqWTdjdFh3MjBNN29G?= =?utf-8?Q?o0YecfmNS2mHzMnLs=3D?= X-Forefront-PRVS: 03853D523D X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(4630300001)(7370300001)(979002)(6049001)(6009001)(39400400002)(39410400002)(39850400002)(39840400002)(39450400003)(39860400002)(189002)(377454003)(199003)(24454002)(7736002)(50466002)(53546010)(36756003)(4001350100001)(106356001)(90366009)(97736004)(77096006)(6486002)(65826007)(105586002)(8676002)(5660300001)(305945005)(68736007)(81166006)(81156014)(42186005)(2950100002)(6666003)(23676002)(64126003)(6916009)(2906002)(478600001)(50986999)(33646002)(2361001)(66066001)(65956001)(76176999)(54356999)(25786009)(47776003)(4326008)(101416001)(7350300001)(65806001)(31686004)(110136004)(86362001)(38730400002)(229853002)(53936002)(2351001)(189998001)(6246003)(230700001)(31696002)(6116002)(54906002)(3846002)(83506001)(969003)(989001)(999001)(1009001)(1019001); DIR:OUT; SFP:1101; SCL:1; SRVR:SN1PR12MB0158; H:[10.236.136.62]; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; Received-SPF: None (protection.outlook.com: amd.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtTTjFQUjEyTUIwMTU4OzIzOnBzTmtuZGJjL3VObGxTdzlRUG1nSHZOWUNi?= =?utf-8?B?TFk1RjU4NWd5bG1YbzhUdGpibE9JbU5raWRmOHJnWlliTFVwOHpBSjFpUUZt?= =?utf-8?B?SmJXMGt2dEhNVUg2NUExNk13SWpmWEhyeTh6QjlPTndvR3Fwb1VKMGpWNm1q?= =?utf-8?B?Y2NnWWJrRFBQaXI3Z09lNWhKdUNMcWg0bTBHdUdES3JZWWxZc05nK1JXbzM0?= =?utf-8?B?SFp5Lzh4eVZNMVJxSjdvMWxTN1YwTnNYTEU2aVVSUm1yblNvcGJZdTZ4eXhS?= =?utf-8?B?M2d6UGNPcmtUNERUWjlOdnJZZStGMldqa3RqOU8rT2JPamlWTTJWOVJZZ1pH?= =?utf-8?B?bEU4RTBOcEc5Qk01WHRRY0JZWkxBc2VkKzRHTThYNGs0eTRvQVVtV0grdUhZ?= =?utf-8?B?eXlmbHlCTzFOdnlsV3l1UVRJckNDeEZiVzhDNjNMK055dEhMbDdUMUxUZmJZ?= =?utf-8?B?TzJpZTVkaWVoWWttcUhoZk1CTVVRREpESFZDenAvRTRVcDg0ZmFCTUVITkpJ?= =?utf-8?B?c0ZnbGVjeUlNWlFhM0dmWldoTmNESDk3WmV2Y3Q0cVM4Vm5SZVQ4K3ZHVHpQ?= =?utf-8?B?QlkxcmhJU2hNQ3VzWEY1MGJaSkJNOTVmNmRnNWp4M2hDajdRbjByU2o1anlD?= =?utf-8?B?RGJxOVYra20wN0RtckdSbys3R1pYK2owVXZZVEFSREoxbG8rMnVjQWt6ejJq?= =?utf-8?B?QU4zWmw5VFVsbm1mRUJNM1VZOHNDMXRidWZGdW9tdW1sTGR2QTk1MUl6NTE3?= =?utf-8?B?eFVneHZDL2UyNHI0ckpORS9YZ1RXNDRyZkhHQndNQ1VQQUJOZXA5ZnRsUUcy?= =?utf-8?B?Z2FJdGFnS0ZqQVZZVnMxckh1a1RWbzFQOHIrS1I2a1JybzZVSXd1TCsrUjgw?= =?utf-8?B?Qk1Ea3phaEZ1bUw5Q1NTLzBBQytMMHB3bFZYNzFRbmovTXM0MlFMeWJlSVpH?= =?utf-8?B?MSsvYkI4dXhKc0lvWk9vNllkd1YyQ2dlSTE0Um9XcVViTS9zdDdXZ2duNUVZ?= =?utf-8?B?cFdscEtQdzhybzNqNXFqMkhSUElVN0d1Tlh2VHUxQnhjYmpkUUVocU5aUzZj?= =?utf-8?B?L0ZSbnZLc1R4aWZRNWpCQkhrYWFhZnFmV1NkWE9Gckpsa01OcllUTC9QS3pT?= =?utf-8?B?Q3d6dm83SnNSVGYvUnZEMDYwd05BUTFiZ290R3VXTXdHVjljNzZYYjBWZXhF?= =?utf-8?B?R2d4U1Y3NTRUQjhScnQ0YTdPQUtWNUJmYlNPY2xxR0xQMS82QndGd2c2Q1B2?= =?utf-8?B?SjVSWUJEaGw2SGJ4TkNCdURpTXBaVnh0cCttL1RxTnBNdWZRYWdJaEt2bU5M?= =?utf-8?B?elhaK3ZzQ1dqdk5pWGxTTkZFcjNOQUtyTXZyQm5CaVJrUjZIS25EM3pqU3VK?= =?utf-8?B?OGtoZmIxbVFRdmRaNFZwNlNFVDdXSEpKTkRTYkZRZGYvTEMwdHBCSzh6WFNL?= =?utf-8?B?M2QrSXQ3d2RYZmxsaTl6VzVvZCtmL1hKc2EyV3BjVW1XaGk3TGE5TTgydkdC?= =?utf-8?B?NXBOTjZBOEdUUThrS3ZuTGYvbTFxMjB1ckxIQ0RLT0g1bXZlSDlncU9TQWQ2?= =?utf-8?B?eE1NMVhSRzJDQkdxRTBmeGc0VnFNa09Eb1hZTDBnbWp2TXpxR09PaDlhZmdh?= =?utf-8?B?U3gzN3N3b2R5RTFyekozVkJFMEhUbmJsS0NkUCsra3VEaWtjZXFGMm9DOVlR?= =?utf-8?B?TmtmeXI1VzJXZTBDZ0E3eDhmY0o0Ym5DUXJxQjhEdURBNXQxZlo2cVh5T2w1?= =?utf-8?B?NDAwSHR0aWh0SUw0OUlMS0F4dURwYmIxUWhYSkY3cGxlR0tzMm9URG5Nc3VM?= =?utf-8?B?VkRnWHdDaXFzWjdzcVVvdDBscVUyR3FoMUxjaFpqcUp5TDQ5Q29tWkQzUXA0?= =?utf-8?B?anBxTGs3NVdwcDRuVUE1Tjg5NG5OdmQ2MjUzOE9WaWlzU1JwQ012RDE2R1Bh?= =?utf-8?B?VmhYbzZ6bkFsYlFraVJTOVp4ZW1rNnQ2bU1ZYzkvMTVmcytTKzdQVE1QS0lQ?= =?utf-8?B?Q2FDbzdIOSsvMktEV0FLZWlmWGJwZGRrTXBHcmROalY3NTNPLzcxeGNYRXlu?= =?utf-8?B?UzZvUmtJaWlvaUV5eDdYSE03QmJMQk9pdWE0TUV3ZC9lWWh5L1I3MFpvb1V5?= =?utf-8?B?aWQyVGd3SWNLcUpHdldTK0swaWZKUTVZT3BCeHYvU3kzQ0ZFcWZ3d25rMldh?= =?utf-8?B?RytDRGJzTGsySndGbDk0ZmtBUC9PU3I2Z1lRR2hYYTEydUFydnJpZy9ML3VK?= =?utf-8?B?M0pwUVdaSnl5eXNWSEpwVG9ieU82ZC9NSUQ3Q1prMkpVYWY0TklZTjhyT1o2?= =?utf-8?Q?vK5GEKkVFRh3aTlgRfmn6Cd+Y/FGn7qHdb06Q?= X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtTTjFQUjEyTUIwMTU4OzY6MUx5TXZKVFhSeTVuZ01DU2pQbnhZZmRqT0cx?= =?utf-8?B?ZnZHa0RURjVFcys4RzhudzNBdFhxSytuaXBWUW9xcnkybjBZbUk1eFM1d25s?= =?utf-8?B?Q3B4R2Q5TmJSbDhGU2taTUJjZXVYSmRwek0xV1JPUEpDU0dEWGVKRlBPSFNa?= =?utf-8?B?cUp2VityTVJIdmcrc3ZOaGN5aWorOEJSQWs5V2dpTWY1UXE1TEx3d1dTZncx?= =?utf-8?B?ZlFnY29YOWhzM2ZFRU82alk0UVBpM05remxnK0xGSklxWXo4bFN0aGNnSDI3?= =?utf-8?B?VDV4YkVRUTNleTAxd3pGamNrYSs4Wk53ZUp0OHNVdlcxMlFwTFFzVUtVcmdx?= =?utf-8?B?eERpOXl6THRvN1FyT2kzdENyRk1zU0pqOUlBQ1NHS2dXQmRzdlBIL0s5QWN1?= =?utf-8?B?U2k5WFVzci8ySUx3cVJLR3NyaEJiT1h6UEtIUmVMYU15KzlYZ0pBYzlrN1Ri?= =?utf-8?B?bzJzb3VCMDVoeWpYNFB3dWhPZzBFNGxRTU5YRWJ4bE5KM2VUZzkrcEZCOS9p?= =?utf-8?B?RnFzZlFpYXE1dm9VbGlWWGhQU2drS1pwVXlXMkdCNU1UNlpqMytDNVdVUVM2?= =?utf-8?B?U1JyeS9iaWk4TXFuZW5ITCt0cGZMeitqVTJZTFZWbEprQ2lQbUhOZzhaR050?= =?utf-8?B?RTZKODhGRlhoanNpZERHNktjVWlxcFNMZGt5L0RZTnJhY2EyeTYyL1R3VThQ?= =?utf-8?B?aDRXWDdoTGZod1VlZkdCc2xjY3VEQjAwZTN1bHRxVmhsNmdCZmZORnc2UXdG?= =?utf-8?B?Yzl6VzZ2OUFCVVV4M0Jab05INFVmZ3ZQMXdrNlpDdWtFSUZzaXI3NDBvVlYz?= =?utf-8?B?Ry96aHliSFBIbkxNWlFzUDhUcWVXQWFjWGREUDNPWDMyOElJWFZwRjlIMFVp?= =?utf-8?B?dmNkU0tlY0lMWlEyS1EvU29aaitIVkx3Mnd2SHlwbHpHei9QYlFTRU5UYXR0?= =?utf-8?B?MStremh0ajFCWk9ueFBSKzhkL0pHKzg3TFRCTVVmeFFNMGJkVCsrUTF1MWFy?= =?utf-8?B?cUVYT3dKU21FVmJ0N21DMUZ6UkpjSko5QUgrRFdITWhrK3lZOXh4TGtnVHcx?= =?utf-8?B?enVqSks5VDFrSitFOFkxK3ZydU5mRkRpM3NJdmlBSGRyenQxdEZTaElBMUtE?= =?utf-8?B?OE0wNDV4cFF1d3g0NGpvQ05JQzlmQlR3WEtMZGNhZUE4OVdVcm8wNkpBZFZ0?= =?utf-8?B?VnpVZWNNUlIwbTFXbTBUK0RhVHdZcC9ZWW9wTGN4cDNFSUUvR3lZMDVtVFVz?= =?utf-8?B?bFpockdmNkpUM0FuV0tTSEcrcFM5Y2I0ZlVQYlVUTXJtaFdCUjc3WS9vbThl?= =?utf-8?B?NktPbkFjQXhMeVNaSWFYbjJBdGhYL0xzREsrWmpGTDgwcWFZODFkNDhHQjJp?= =?utf-8?Q?boeNm/Y?= X-Microsoft-Exchange-Diagnostics: 1; SN1PR12MB0158; 5:9nrFcGf0SwefH8GXqzzx+IXRTb4l+TDVNqmi2ezJy0HjutSU0u3lSHKUFn3Oox6StlfxswCw2BP3SYwcBfNJD+b0cqZkCXzVzJi9HuNIfimFLe776DtCyzPCNTrtVgHgSDHd4jRarSAGp8iokFJEXGeedW0gcQOQoWJOi6CZaqlclRVkJWiAjgok/oZWPD/MYOpWaGHS2R3wRvbEZctLzeRb7oZ/HxdC82JG06w49Mg1XyQkkYKvoSYKCFMksBeGaePUYj0pTuMWO9uIb6LlZqL1pmppKTGoVjpKMqPO3eB4/pL8b88mvnrqC49z/xoM4PDQqpD/QTcKWXaAyUuIi2VaFOOPBwiuP10C2dcmbG33SXfh3TMiuOWj4bi8fVMO/mo3u2wSB62et+OT5XB8NCp+UF61wDKfAsytSofAge8dWiSGzSYrPzupqtN0lKuUd/t5pt2TRiw+ZEhidoKZMIayGiMslddFoYPd9vInTFQ7jbeQONQaff3ToN+guSsa; 24:S464+YqjhbjLqNUQWVG93jo859fqQ8/08FLj2iklykFe3qtxra7NYyPIMWWQepOgVsmiRPJvtpR15RtECy4A+/6KBc+8gSNWeuA9f+Y6xTE= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; SN1PR12MB0158; 7:wOYnWAIWSKn5CnJADHscldJZdrfPJCqBq7TngnlJTXqTstS/dffsuEo10rA5psBZgcU0qvrFwEy1zTxAA175dqK+qT/52Hkd5EYCLAHvlovQ9bJLLG1jj69UlqVEJcLp+g5nO6mH15JpwTAz7yMIrN8hWOeMFp1df6mskcVGFpr5qVRyY5Ju2sBgJHVxVErmFDSCTQ4L3QxDLxj1S3c2HQosry6UbICdzax2aVX9R4Nxg6nkXuNtLxUIcCl+ByTftqSC/f/P3HvxUmmSf1JmchEdV4//mEAvYM6Cdd8r5OB5LEnrSSRkt4a9ApNXgFHvjQpcZYNWQPMg9Rksjb/uyzjFVhBovLsuoiMAmKEKtC/+FDoqWJgwxk7wAZk0l2OgFFfovqzFGmlnuh5YOdorn4fOJbmtvhiF8Y/lAdJxL2wsiFfJw/qzZm2jeHChxLeAkMZznsHrBNqG/PWTEiZhT6Db76qolLny3e8Araoc9TuymUWQKnlu/9oNttkXHM0Ze+MACO8SAoiYg/cDaPUi9gk5Dg47RSv8C+qhfT6agETb6vR7ITdDBDpbN+ecfrBSW1xj1u1gMH324QVmN+aLzD12PAQO/eAmh6SgHjzEYIubLUx3q3pm1irtfwj4NW8+m31xGVvCkclOu9p1Xkg9u570xO4a3z/1JyTplY77qQnFSBznn1QBAiti0UabHJnEHz6ofafyC/5e33m28PyZ+JLR1ZIzFiRlJK3AYyaBy4nKLsx8GWg7r+NoZLqfMnstXDVWWjzwocZ/CbB1dOQW+mqtl8WcOoKjMRIH86y8VOI= X-Microsoft-Exchange-Diagnostics: 1; SN1PR12MB0158; 20:7doERQjqfdHUPhOsstXS3wXsWCyAcg0TUy48OOQ1nrUrShQAJVZB5djKdRmBif2b0GYfhCKzYA7lw2MBSrf1wwW3T2ha0q/MbpqdRuAeDA16JFSwyol2i3AAyo9hDKiHjAN1TiBTEAeTy/7gYVOjRtB5USBWxvI3WRyi19DQ0mzfV8GMFJ57/cCiXRcNcf8zxUNNkCBqCQIbtSawveXJdyuom9sSp0VCPmoFEvQzF5HmD/T5SdfSfnIU8Ek0Ukkz X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Jul 2017 19:38:34.5274 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN1PR12MB0158 Subject: Re: [PATCH v1 3/4] OvmfPkg: IommuDxe: Zero the shared page(s) on Unmap() X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 31 Jul 2017 19:36:28 -0000 Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit I just realized that this patch contains some changes which should be part of Patch 2/3. Please ignore this patch for now. I will fix it as part of v2 when addressing review feedback. thanks -Brijesh On 07/31/2017 02:31 PM, Brijesh Singh wrote: > To support the Map(), we allocate bounce buffer with C-bit cleared, > the buffer is referred as a DeviceAddress. Typically, DeviceAddress > is used as communication block between guest and hypervisor. When > guest is done with communication block, it calls Unmap().The Unmap() > free's the DeviceAddress, if we do not clear the content of shared > communication block during Unmap() then data remains readble to the > hypervisor for an unpredicatable time. Let's zero the bounce buffer > after we are done using it. > > I did some benchmark and did not see any measure perform impact of > zeroing the page(s). > > Suggested-by: Laszlo Ersek > Contributed-under: TianoCore Contribution Agreement 1.0 > Cc: Laszlo Ersek > Cc: Jordan Justen > Signed-off-by: Brijesh Singh > --- > OvmfPkg/IoMmuDxe/AmdSevIoMmu.c | 18 ++++++++++-------- > 1 file changed, 10 insertions(+), 8 deletions(-) > > diff --git a/OvmfPkg/IoMmuDxe/AmdSevIoMmu.c b/OvmfPkg/IoMmuDxe/AmdSevIoMmu.c > index 5ae54482fffe..04e3725ff7e6 100644 > --- a/OvmfPkg/IoMmuDxe/AmdSevIoMmu.c > +++ b/OvmfPkg/IoMmuDxe/AmdSevIoMmu.c > @@ -67,8 +67,7 @@ SetBufferAsEncDec ( > // buffer matches with same encryption mask. > // > if (!Enc) { > - Status = MemEncryptSevClearPageEncMask (0, MapInfo->DeviceAddress, > - MapInfo->NumberOfPages, TRUE); > + Status = MemEncryptSevClearPageEncMask (0, TempBuffer, MapInfo->NumberOfPages, TRUE); > ASSERT_EFI_ERROR (Status); > } > > @@ -79,7 +78,7 @@ SetBufferAsEncDec ( > // > CopyMem ( > (VOID *) (UINTN) TempBuffer, > - (VOID *) (UINTN)MapInfo->HostAddress, > + (VOID *) (UINTN) MapInfo->HostAddress, > MapInfo->NumberOfBytes); > > // > @@ -109,11 +108,8 @@ SetBufferAsEncDec ( > // > // Restore the encryption mask of the intermediate buffer > // > - if (!Enc) { > - Status = MemEncryptSevSetPageEncMask (0, MapInfo->DeviceAddress, > - MapInfo->NumberOfPages, TRUE); > - ASSERT_EFI_ERROR (Status); > - } > + Status = MemEncryptSevSetPageEncMask (0, TempBuffer, MapInfo->NumberOfPages, TRUE); > + ASSERT_EFI_ERROR (Status); > > // > // Free the intermediate buffer > @@ -386,6 +382,12 @@ IoMmuUnmap ( > ASSERT_EFI_ERROR(Status); > > // > + // Zero the shared memory so that hypervisor no longer able to get intelligentable > + // data. > + // > + SetMem ((VOID *) (UINTN)MapInfo->DeviceAddress, MapInfo->NumberOfBytes, 0); > + > + // > // Free the bounce buffer > // > gBS->FreePages (MapInfo->DeviceAddress, MapInfo->NumberOfPages); >