From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (NAM10-BN7-obe.outbound.protection.outlook.com [40.107.92.45]) by mx.groups.io with SMTP id smtpd.web10.21975.1676310990167414414 for ; Mon, 13 Feb 2023 09:56:30 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@amd.com header.s=selector1 header.b=1Qq8tM2e; spf=permerror, err=parse error for token &{10 18 %{i}._ip.%{h}._ehlo.%{d}._spf.vali.email}: invalid domain name (domain: amd.com, ip: 40.107.92.45, mailfrom: pankaj.gupta@amd.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KBXoGEjMtWPm8O/0TcyOXVtHdF/aEGXU8ahqJnrY41Taf9ySRdNjEvivICtrSmjnr76ZgjUQ+axJCgWydIj8ojBOCBCFO9H4lbqzZXkLTP+ExfZ3LEqkUTB09pb0XLzeQenDzU+Lhdart+OxnVuXSO0Y1idd7TzUHIn17bAKaSWM9suBa/MZaSPPHf6fIMCygKcTdcugwY4Ih4Y7f6R3yE6jdPjMT/bYPtdARdl1CcN7quu5yXgtrjNop9aGa/Q39QfD9RyzJr4+CmNIZysIdjdhpHTMC+XlalzOAJF+5PgH+9gC/CMb3rt34V7IRwp2C6YAxP5TU39nAr4hseEYnA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=bEHn0OKrco4yPi0/kxa+/UZdMD9Z0CVQNBX3vKr28Qg=; b=nb2u2zXuyitUScSUG0dXG0Hfh7rwCYJ/DGUsv8IFAVKusdWeh5EcaHh18Tc15USrPVysQkYtzg2jTxeSFRE6WyJ7LNUfqtPqp5Nv3jGDTwzbl2DNDW9LZzNBlMV/M2vld6WNyZIu+AOzoMCbWgic2TbO/o8dF0citTgIWk5MbO7bjU3jx5UhgbeuXqHLdU9TDmJvRiizvvpK9V5GR/BlVJRTQvTbrQxLYItEhaPu1rkTT0r0nNDMcuqf0a8s82XB48maP6WkIdrk52bjPVWKsCoO22dBLRmuDG1gqdKUpqy5vtm/awh69l+p+kzE8Dg+wS9ahAF5MWYM5Bw0N9S6IQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bEHn0OKrco4yPi0/kxa+/UZdMD9Z0CVQNBX3vKr28Qg=; b=1Qq8tM2eGDi0/KLSCSpY7x9qqusWOdiTeUc7fI3kqIaOa4vZ2nhQKSeUnyTXgaFgYG9f29mAOg7bFIA34t7RGW8aAUucZVI7Q6HVoOcHTFdF/ibtJBFMX/c8fFXaXVJJawuTntg1RV59uWAJ9RCbvXX/GFhrLsYo9jcLCZUOFFY= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from DM6PR12MB2810.namprd12.prod.outlook.com (2603:10b6:5:41::21) by IA1PR12MB6435.namprd12.prod.outlook.com (2603:10b6:208:3ad::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.24; Mon, 13 Feb 2023 17:56:25 +0000 Received: from DM6PR12MB2810.namprd12.prod.outlook.com ([fe80::b84e:f638:fa40:27ef]) by DM6PR12MB2810.namprd12.prod.outlook.com ([fe80::b84e:f638:fa40:27ef%6]) with mapi id 15.20.6086.024; Mon, 13 Feb 2023 17:56:25 +0000 Message-ID: <52c7d139-3763-b4f2-ab5c-a0a925a1a3ff@amd.com> Date: Mon, 13 Feb 2023 18:56:16 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Subject: Re: [edk2-devel] [PATCH v10 1/4] OvmfPkg: Add memory acceptance event in AmdSevDxe To: Dionna Amalie Glaze Cc: devel@edk2.groups.io, Gerd Hoffmann , James Bottomley , Jiewen Yao , Tom Lendacky , Ard Biesheuvel , "Min M. Xu" , Andrew Fish , "Michael D. Kinney" References: <20230126005647.3019225-1-dionnaglaze@google.com> <20230126005647.3019225-2-dionnaglaze@google.com> <0d8f2b0b-1d62-3db6-34c9-e9ce39838bce@amd.com> <9ea61013-e2c1-30a4-3be7-feed537c035a@amd.com> From: "Gupta, Pankaj" In-Reply-To: X-ClientProxiedBy: FR0P281CA0137.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:96::13) To DM6PR12MB2810.namprd12.prod.outlook.com (2603:10b6:5:41::21) Return-Path: Pankaj.Gupta@amd.com MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6PR12MB2810:EE_|IA1PR12MB6435:EE_ X-MS-Office365-Filtering-Correlation-Id: 981a81b2-3e73-419c-1c27-08db0deb9fbc X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: P2Ac7pm0KF1EbDPxoX3cAKM9zOMBbqn4sVEGslHV2fhnSkDcKVtj2Z5/62oHrGVComChP2qsDxeHhpcs5iP/eLfwL/l+OptqSJrD+I5JNnmeNOzogpqis9AvwhGP0OtTKGi67kqBzKNcw6esteJUiV8GkIoqatWD6N9lKALirpIyE/mYm1XHeIQrtTiHZeS6eWWTDFgRLFjHdgAtXBGJQt6tV9GegeqZLatuGGfELTPCdQcqu5DnzsK8Q1iBFjJTnnJx+fPTWO7l7mO4aOQBjsjIAoDj267FRhH9Ru7nFmbusL48SPAj75xTg98NS8kcIr1eHnEKTV9AFWWZ9bmm/Vj9Kp9m/99UuQmsRlSSc71D5NNjk49sj87+2/fngp+8ZgEvEkwgLSEriyVj9gYL6VSnFyuiayazjiGgmrdmYQUyuclMDyugoLWYllAd2KqSzczLjjfQ4qhIGBaJwi+7MKMHsEGa8Q1G1rUYyjpPD6S8SmfDbzpCCMcbxDhR0aC606L0IKXkL0Pmk6Jpvp4X2nGfM3c6aUi/iR5Sm9SaHpv1s5xGv+IlZ3aFsViPGtVj/VvPkmBIlRVbj5+JarNzU3uJKEcSCq2e2VeViJ0z73vzmiqK0SdOX79PPqgWFeq/eujC+QKO/jlotn3bJL57sl+jTLeNBhb/Uq+CBOPSaR8rBvf6jBn/yH9o9yFPlI3Aau9gox6ulka1qWwZyZ0LcM51Iu05uNkyT2HXJ6DJFxg= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR12MB2810.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(4636009)(366004)(376002)(396003)(39860400002)(136003)(346002)(451199018)(36756003)(66899018)(2616005)(83380400001)(38100700002)(6666004)(8936002)(5660300002)(41300700001)(2906002)(6506007)(186003)(6512007)(31696002)(26005)(6486002)(316002)(54906003)(31686004)(8676002)(66946007)(66476007)(66556008)(6916009)(86362001)(4326008)(478600001)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cUhQV2pyczlhc0djNXFOUEJWeXIxVysrWmFxTHQyYWhWMHUveXBPMCtpTFI4?= =?utf-8?B?TXF0MU02RTduZDE4UERlYzZMV3dKSEQvbXUxaDhGVTRYQldhcEcwR1d1QjFM?= =?utf-8?B?NmhiS3YxR3JTWmJadVBkVU9WNFhJQ0J1SVdCd1pETzVIUDl2a2JBYUVURmFr?= =?utf-8?B?RGhNVG5pejBQUUU0UjkxMkZNbk42Wk5sTGl0eXlhRFZYUm9MT1c5T294bUY1?= =?utf-8?B?Q05aMFppbEsyTkNXMVpqRkpqYWhvd0d2b29ON2FuUWc5eWNHZUhPRGNNMXEv?= =?utf-8?B?RVdmUDBNMnkzTG5BV0VKT1pyY25aYWswVjdOTzdwcWxCSExveE9mckhvZVZk?= =?utf-8?B?QnlnU0pLWDJMZnloVU0vNWN2MnFZa2F5NGJtZnRscEFQanBUSWtPVnhhcUhY?= =?utf-8?B?SVVlaGNTMGMwZ3ZhYVFHcFN2UGxnRGlNeDlEM0NWZ1g0eGtHYjBLMERpMmlj?= =?utf-8?B?VENTcTYvOUlqSmNCVnlCVjh1dm9zVGtRTGk0cW03YkhRS0NsTFFYbTdMdjVr?= =?utf-8?B?V2hIUjgydU1RZDJiM0VXMjVHMHJJc1FqMFRrb01UR1h6WG9NT1RzVHlSbjRC?= =?utf-8?B?eDh3clJIbDhwRzllUk9pbmdmdEpMY0UrQmgzY3U2SGtsc1NKMDVUTVNQSmNY?= =?utf-8?B?VGgxVXNHOEFkWlR2QUIrSDBGcVVwQTArZ3JsQ05TOTVHQW11aFlQVWJRY1Vu?= =?utf-8?B?aDlneVNBUUdKU0Z3SytuNW5UM3I5T1B5TEFwTHU5ekVXbTJOYTdRMkNHcFcv?= =?utf-8?B?UUZwQlV3aklySzlFRGNJZHgwMmhjbnorUE5JWDRUcFpaMUR2eFpFb3pTUUE3?= =?utf-8?B?NWVwOFpoR0ZCMWk3aU1nMWpxdlFadmF5Sm5iMFBmMy93aFV2ckVLSk5KajFn?= =?utf-8?B?NmxObG9aVHprOW1xb05HWnVTZE9lT2VDMWREaXZEOGRrWUxPRXRtb1k1eU5u?= =?utf-8?B?VkF6OEhZOTIxWGtkR2VnbmdlaTRXdkM3b2N0SlZ2UHZBVUs5dUZOdUxncWpG?= =?utf-8?B?QzhkN1JkS2Q5Q2tyWklFU0FFaXVNdUNBSEtOQlk1dnlBMVFlalZsK3VPT0VF?= =?utf-8?B?T2tIZUxpNDg3VlZlMXZLWGVhT2hKNng1MXdqSDNudHZhWktWYjV5TTgxYVFQ?= =?utf-8?B?V2FUbjQwTkNDdWlHODRLVXQ4d3RKemJudnVhdGVhMjRZa1Y1aW5tSm1UVXNj?= =?utf-8?B?d3RySldVL2FJakNzckdBQi83aXpDbzFOeGY2cVZ2MUFpV0ZCN2lZQW11Q3k4?= =?utf-8?B?cXpNRnQ1WTFIM3k1V1Zva1dORGlxK0RjQXZWVE9sZGdIK2MyZmQvMGNCTnR6?= =?utf-8?B?d0E1Q3crSzBCV0VFN0oyTnJ0ejk5cmsyOHE4V0p1bkZEampsR3AraEtRYmFN?= =?utf-8?B?QTJDRWFzNWt0ZHh2aXpHUGgxd0loaTJ2cDdERk53MGxDWWFnbmZsWlM1NC9I?= =?utf-8?B?b1J2cklQYUZ3L09xbmY1OGJXUjcyZ2ZvOXdEQmVGcXEwUUxVZ0I2NkFWZ2lK?= =?utf-8?B?TCtweEZWRWhYZWZvVUtFTzlSWHg5R215NXhyM1VUOW1uTjNBYmNYYjl1ZTlQ?= =?utf-8?B?Z08xSWJkSzlYaTJhc2hiRkJGMWhrUDZ1c0VEMXJTRzBkM0R4OUJsNGI1enJu?= =?utf-8?B?TVFxQWNYZlEzNzB5Tmk4UUJCQ2E3aTZTaHpVb3JRb0RqTjRWbDZ1cU8raEo5?= =?utf-8?B?WDAwRVRmb1lWNjEyNko4RkY1OGd5N1BMSjlQdWVyOVNKTHJ3RGdiTWF2RXV2?= =?utf-8?B?c05LUnhoa0diTFlkc1ZwUWR6MmFvUUs4WFhya1o1WFF6M2hqRmdsOS9uYVhY?= =?utf-8?B?Q1dWblVuVVJxdmlHZTZGMWFWMFNJQ1YvVzJzT1lzaDdCa0QxOW53T0hvN01l?= =?utf-8?B?dDNrZHVaeDdLVXRBNFNrdjZscmg4RHkyOUo0Umw2czhEL2FnOEZpVUt4ZlJZ?= =?utf-8?B?aGhXS1BJQ3J1UU5ta3dXZXVSRk9DY1VYTjJsWlg1ak5YeTAvV2hraldJb1Fn?= =?utf-8?B?cnlBOVRHU2hJZHNKYndHRGlVUmQ5Nk5uUERBQWhUNEpoWDZBNUpnSXhuK2E3?= =?utf-8?B?dDBYcnNLV0VVdzdUTnhxMGgzNEx0S3JHa1hRbkFvSGRDRXpsN0JvcWc0Uk5L?= =?utf-8?Q?ugqPlMQKiEYjUz7hhvZWAf3uN?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 981a81b2-3e73-419c-1c27-08db0deb9fbc X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB2810.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Feb 2023 17:56:25.3781 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: PgmMNFK+seg3uApbW/tD8lKk0Lldet10aC62ahZYXxws+5YfLfPCod8kiSHhfOZVlszTgsCMn9edGYQ9Gr6+QA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR12MB6435 Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit >> - If no memory is getting accepted at all, should guest boot fail with >> below errors? > > No, the guest should not error. EBS should return success on the > second call and permit progress. > >> - Why unaccepted memory not being set in my setup but works fine for >> you? Does it require any other change? >> > > We have an internal fork of EDK2 that we regularly rebase on top of > upstream, and we have our own hypervisor called Vanadium. So there's a > lot different. We don't have an easy way to test with upstream EDK2 > and Qemu. > A recent import found incompatibilities with measured boot only in > SEV-SNP that we have disabled, but that's related to NVdata, which we > deal with differently in GCE due to the cloud IVARS service and our > allergy to SMM emulation. Should be unrelated. > > I've looked over our OvmfPkg.patch that we maintain after every rebase > and most everything is related to our paravirtualized UEFI package > that eschews SMM to talk to Vanadium directly through either shared > memory or port I/O depending on whether the guest OS owns cr3 or not. > > You've added a log for the if != unaccepted memory, but will you log > what status the function ultimately returns? And both the MapKey what > status CoreTerminateMemoryMap returns in DxeMain.c's > CoreExitBootServices? I'm wondering if maybe the EFI stub calling EBS > isn't calling GetMemoryMap to update the MapKey after the > invalid_param result that this semantics depends on. If the stub is > the Linux kernel's own stub, then it should be doing the right > thing... CoreTerminateMemoryMap::MapKey::18033 ^M CoreTerminateMemoryMap::Status::2 .... CoreTerminateMemoryMap::MapKey::18035 ^M CoreTerminateMemoryMap::Status::2 ^M Thanks, Pankaj