Re: [edk2-devel] [PATCH v5 4/7] OvmfPkg: Generate CloudHv as a PVH ELF binary

["Boeuf, Sebastien" <sebastien.boeuf@intel.com>]

On Wed, 2022-03-02 at 08:17 +0100, Gerd Hoffmann wrote:
> > -[FD.CLOUDHV_VARS]
> > -[FD.CLOUDHV_CODE]
> 
> Dropping these two should be a separate patch,
> so this patch becomes more readable.

Sounds good.

> 
> > -0x00000000|$(FVMAIN_SIZE)
> > +0x00001000|$(FVMAIN_SIZE)
> 
> FVMAIN_SIZE is not changes anywhere it seems.
> So CLOUDHV.fd ends up with some odd size (instead of 2M or 4M) I
> guess?

No the total size is still 4M because of the FW_SIZE.

> 
> (not much of a problem though if cloudhv doesn't care ...)
> 
> > diff --git a/OvmfPkg/VarStore.fdf.inc b/OvmfPkg/VarStore.fdf.inc
> > index a1e524e393..a1cbc74fbb 100644
> > --- a/OvmfPkg/VarStore.fdf.inc
> > +++ b/OvmfPkg/VarStore.fdf.inc
> > @@ -15,6 +15,7 @@
> >  0x00000000|0x00040000
> >  !endif
> >  #NV_VARIABLE_STORE
> > +
> >  DATA = {
> >    ## This is the EFI_FIRMWARE_VOLUME_HEADER
> >    # ZeroVector []
> 
> leftover whitespace update

Ok I'll remove it.

> 
> take care,
>   Gerd
> 

---------------------------------------------------------------------
Intel Corporation SAS (French simplified joint stock company)
Registered headquarters: "Les Montalets"- 2, rue de Paris, 
92196 Meudon Cedex, France
Registration Number:  302 456 199 R.C.S. NANTERRE
Capital: 4,572,000 Euros

This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.