From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 0859E7803D7 for ; Thu, 18 Jan 2024 08:48:04 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=H4okzB/Cxsw3WsiSBOgYJob7QS1vXQyM5hFuZoEmbu0=; c=relaxed/simple; d=groups.io; h=Message-ID:Date:MIME-Version:User-Agent:Subject:To:Cc:References:From:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type; s=20140610; t=1705567683; v=1; b=jFdxt1ro55uY5gKbBF9ozuNypwOk5F/h/GQ4fO9R4totlcbGZt37PWINQJObuK2GdrlqkvBG nI19WefVtJKRRvUxDAYU4RnrUKVpvAHg1+/YzWz0Flatak7i4xfCl2IWD0hKmV1yrXimR8NlVgG 2PU9aJAlDg93fMO+bZ9EtO8E= X-Received: by 127.0.0.2 with SMTP id ClGxYY7687511xxAe6TPthKj; Thu, 18 Jan 2024 00:48:03 -0800 X-Received: from mail.loongson.cn (mail.loongson.cn [114.242.206.163]) by mx.groups.io with SMTP id smtpd.web11.7118.1705567682254399396 for ; Thu, 18 Jan 2024 00:48:03 -0800 X-Received: from loongson.cn (unknown [10.40.24.149]) by gateway (Coremail) with SMTP id _____8DxWPC85ahlCpEBAA--.7493S3; Thu, 18 Jan 2024 16:47:56 +0800 (CST) X-Received: from [10.40.24.149] (unknown [10.40.24.149]) by localhost.localdomain (Coremail) with SMTP id AQAAf8DxDc+45ahlgyAIAA--.41571S3; Thu, 18 Jan 2024 16:47:52 +0800 (CST) Message-ID: <52fb9309-4597-417d-ab9c-766c4be1392d@loongson.cn> Date: Thu, 18 Jan 2024 16:47:52 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [edk2-devel] [PATCH v7 25/37] ArmVirtPkg: Move PlatformBootManagerLib to OvmfPkg To: devel@edk2.groups.io, lersek@redhat.com Cc: Ard Biesheuvel , Leif Lindholm , Sami Mujawar , Gerd Hoffmann , Jiewen Yao References: <20240112082153.3284189-1-lichao@loongson.cn> <20240112082534.3299238-1-lichao@loongson.cn> <29414777-a154-bd1c-95c8-6c4f4e01bbcb@redhat.com> <7a1627f4-ed0c-46f7-ac6e-6ab1f16393dd@loongson.cn> From: "Chao Li" In-Reply-To: X-CM-TRANSID: AQAAf8DxDc+45ahlgyAIAA--.41571S3 X-CM-SenderInfo: xolfxt3r6o00pqjv00gofq/1tbiAQAACGWnj+ALpAAEsP X-Coremail-Antispam: 1Uk129KBj93XoWxJr4fZr1fZF4xXF1kJw43urX_yoW8Kw1Dpr 4rtrWfAF4Fvr1YyF98ArW5X3Wvv3yq9F1UG3Z0yryxCFn8KF4IyryxKr45trW7ZFnxuay7 Zrs0kw48ZFyDWagCm3ZEXasCq-sJn29KB7ZKAUJUUUUU529EdanIXcx71UUUUU7KY7ZEXa sCq-sGcSsGvfJ3UbIjqfuFe4nvWSU5nxnvy29KBjDU0xBIdaVrnRJUUUyCb4IE77IF4wAF F20E14v26r1j6r4UM7CY07I20VC2zVCF04k26cxKx2IYs7xG6rWj6s0DM7CIcVAFz4kK6r 1Y6r17M28lY4IEw2IIxxk0rwA2F7IY1VAKz4vEj48ve4kI8wA2z4x0Y4vE2Ix0cI8IcVAF wI0_Gr0_Xr1l84ACjcxK6xIIjxv20xvEc7CjxVAFwI0_Gr0_Cr1l84ACjcxK6I8E87Iv67 AKxVW8Jr0_Cr1UM28EF7xvwVC2z280aVCY1x0267AKxVW8Jr0_Cr1UM2AIxVAIcxkEcVAq 07x20xvEncxIr21l57IF6xkI12xvs2x26I8E6xACxx1lYx0E2Ix0cI8IcVAFwI0_JrI_Jr ylYx0Ex4A2jsIE14v26r1j6r4UMcvjeVCFs4IE7xkEbVWUJVW8JwACjcxG0xvEwIxGrwCj r7xvwVCIw2I0I7xG6c02F41l42xK82IYc2Ij64vIr41l4I8I3I0E4IkC6x0Yz7v_Jr0_Gr 1lx2IqxVAqx4xG67AKxVWUGVWUWwC20s026x8GjcxK67AKxVWUGVWUWwC2zVAF1VAY17CE 14v26r126r1DMIIYrxkI7VAKI48JMIIF0xvE2Ix0cI8IcVAFwI0_Jr0_JF4lIxAIcVC0I7 IYx2IY6xkF7I0E14v26r1j6r4UMIIF0xvE42xK8VAvwI8IcIk0rVWUJVWUCwCI42IY6I8E 87Iv67AKxVWUJVW8JwCI42IY6I8E87Iv6xkF7I0E14v26r1j6r4UYxBIdaVFxhVjvjDU0x ZFpf9x07UAWrXUUUUU= Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,lichao@loongson.cn List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: YXELicsa3OzQ9qp1ALuoZVwTx7686176AA= Content-Type: multipart/alternative; boundary="------------vgV1jCONY1Nvlq6kCsxA2iVF" X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=jFdxt1ro; dmarc=none; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io --------------vgV1jCONY1Nvlq6kCsxA2iVF Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable Hi Laszlo, Thanks, Chao On 2024/1/16 22:41, Laszlo Ersek wrote: > On 1/16/24 12:54, Chao Li wrote: >> On 2024/1/15 16:46, Laszlo Ersek wrote: >>> On 1/12/24 09:25, Chao Li wrote: >>>> @@ -29,7 +29,6 @@ >>>> QemuKernel.c >>>> =20 >>>> [Packages] >>>> - ArmVirtPkg/ArmVirtPkg.dec >>>> MdeModulePkg/MdeModulePkg.dec >>>> MdePkg/MdePkg.dec >>>> OvmfPkg/OvmfPkg.dec >>> Hmmm. This makes me wonder. >>> >>> If we can remove the ArmVirtPkg package dependency from the lib instanc= e >>> in *this patch*, then we should be able to remove it *earlier* too >>> (i.e., independently), while the lib instance still exists under ArmVir= tPkg. >>> >>> I don't see why the "ArmVirtPkg.dec" dep becomes superfluous *right her= e*. >>> >>> If I look at this INF file, as of commit 4a443f73fd67, I see at least >>> two "ArmVirtPkg.dec" dependencies: >>> >>> [FixedPcd] >>> gArmVirtTokenSpaceGuid.PcdUninstallMemAttrProtocol >>> >>> [Pcd] >>> gArmVirtTokenSpaceGuid.PcdTerminalTypeGuidBuffer >>> >>> In patch 24 ("ArmVirtPkg: Move two PCD variables into OvmfPkg"), you >>> move these PCDs to OvmfPkg. >>> >>> Ah, I understand now. In brief: this particular hunk belongs to patch 2= 4 >>> (where you correctly modify "PlatformBootManagerLib.inf" anyway). The >>> point is that, with the movement of both PCDs from the ArmVirt token >>> space to the OVMF token space, "PlatformBootManagerLib.inf"'s dependenc= y >>> on "ArmVirtPkg.dec" disappears. Therefore the above hunk belongs to >>> patch 24. >>> >>> ... When you implement that, please build-test both patches 24 and 25. >>> >>> More precisely, your patch set should build at every stage, considering >>> both ArmVirt and OVMF platforms. >>> >>> The command "git rebase --exec" is useful for building a series at ever= y >>> stage. >> Do you means this change should belong in patch 24 is better? > Yes, please. OK, I will move this change to patch 24 in V8, which will be submitted=20 after discussing the UefCpuPkg folders layout. > >> BTW, I did build and tested after applying patches 24 and 25(building >> and testing with ArmVirtQemu.dec) and it works fine. > Thank you. > > Laszlo > > > >=20 > -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#113988): https://edk2.groups.io/g/devel/message/113988 Mute This Topic: https://groups.io/mt/103679477/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- --------------vgV1jCONY1Nvlq6kCsxA2iVF Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable

Hi Laszlo,


=
Thanks,
Chao
On 2024/1/16 22:41, Laszlo Ersek wrote:<= br> 
On 1/16/24 12:54, Chao Li wrot=
e:

On 2024/1/15 16:46, Laszlo E=
rsek wrote:

On 1/12/24 09:25, Chao Li =
wrote:


      

        

          

            
@@ -29,7 +29,6 @@
   QemuKernel.c
=20
 [Packages]
-  ArmVirtPkg/ArmVirtPkg.dec
   MdeModulePkg/MdeModulePkg.dec
   MdePkg/MdePkg.dec
   OvmfPkg/OvmfPkg.dec


          

          
Hmmm. This makes me wonder=
.

If we can remove the ArmVirtPkg package dependency from the lib instance
in *this patch*, then we should be able to remove it *earlier* too
(i.e., independently), while the lib instance still exists under ArmVirtPkg=
.

I don't see why the "ArmVirtPkg.dec" dep becomes superfluous *right here*.

If I look at this INF file, as of commit 4a443f73fd67, I see at least
two "ArmVirtPkg.dec" dependencies:

[FixedPcd]
  gArmVirtTokenSpaceGuid.PcdUninstallMemAttrProtocol

[Pcd]
  gArmVirtTokenSpaceGuid.PcdTerminalTypeGuidBuffer

In patch 24 ("ArmVirtPkg: Move two PCD variables into OvmfPkg"), you
move these PCDs to OvmfPkg.

Ah, I understand now. In brief: this particular hunk belongs to patch 24
(where you correctly modify "PlatformBootManagerLib.inf" anyway). The
point is that, with the movement of both PCDs from the ArmVirt token
space to the OVMF token space, "PlatformBootManagerLib.inf"'s dependency
on "ArmVirtPkg.dec" disappears. Therefore the above hunk belongs to
patch 24.

... When you implement that, please build-test both patches 24 and 25.

More precisely, your patch set should build at every stage, considering
both ArmVirt and OVMF platforms.

The command "git rebase --exec" is useful for building a series at every
stage.


        

        
Do you means this change should belong in patch 24 is better?


      

      
Yes, please.

    

    OK, I will move this change to patch 24 in V8, which will be
    submitted after discussing the UefCpuPkg folders layout.

    

      



      

        
BTW, I did build and tested after applying patches 24 and 25(building
and testing with ArmVirtQemu.dec) and it works fine.


      

      
Thank you.

Laszlo







    

  




_._,_._,_





Groups.io Links:



 =20
    You receive all messages sent to this group.
 =20
 =20




View/Reply Online (#113988) |


 =20

|

  Mute=
 This Topic


| New Topic







Your Subscriptio=
n |
Contact Group Owner |

Unsubscribe

 [rebecca@openfw.io]


_._,_._,_



--------------vgV1jCONY1Nvlq6kCsxA2iVF--