From: "PierreGondois" <pierre.gondois@arm.com>
To: Jeff Brasen <jbrasen@nvidia.com>, devel@edk2.groups.io
Cc: sami.mujawar@arm.com, Alexei.Fedorov@arm.com, nd@arm.com
Subject: Re: [PATCH v2] DynamicTablesPkg: AcpiSsdtPcieLibArm : Add UID to slot creation
Date: Wed, 24 Aug 2022 23:12:15 +0200 [thread overview]
Message-ID: <532bb58f-8354-9cb6-7080-f63f13121a93@arm.com> (raw)
In-Reply-To: <42a40dcf43d62ff985fd89bbcde47558344384bc.1661315727.git.jbrasen@nvidia.com>
Reviewed-by: Pierre Gondois <pierre.gondois@arm.com>
On 8/24/22 06:35, Jeff Brasen wrote:
> Expose the UID value to GeneratePciSlots().
> This is needed for some cases for example:
> https://docs.microsoft.com/en-us/windows-hardware/drivers/pci/dsd-for-pcie-root-ports#identifying-externally-exposed-pcie-root-ports
>
> Name (_DSD, Package () {
> ToUUID("EFCC06CC-73AC-4BC3-BFF0-76143807C389"),
> Package () {
> Package (2) {"ExternalFacingPort", 1},
> Package (2) {"UID", 0},
> }
> })
>
> Signed-off-by: Jeff Brasen <jbrasen@nvidia.com>
> ---
> DynamicTablesPkg/Include/Library/SsdtPcieSupportLib.h | 8 +++++---
> .../Acpi/Arm/AcpiSsdtPcieLibArm/SsdtPcieGenerator.c | 5 ++++-
> .../Common/SsdtPcieSupportLib/SsdtPcieSupportLib.c | 8 +++++---
> 3 files changed, 14 insertions(+), 7 deletions(-)
>
> diff --git a/DynamicTablesPkg/Include/Library/SsdtPcieSupportLib.h b/DynamicTablesPkg/Include/Library/SsdtPcieSupportLib.h
> index 85e283a994..4171dabc33 100644
> --- a/DynamicTablesPkg/Include/Library/SsdtPcieSupportLib.h
> +++ b/DynamicTablesPkg/Include/Library/SsdtPcieSupportLib.h
> @@ -54,9 +54,10 @@ AddOscMethod (
> used. It should be possible to enumerate them, but this is additional
> information.
>
> - @param [in] PciInfo Pci device information.
> - @param [in] MappingTable The mapping table structure.
> - @param [in, out] PciNode Pci node to amend.
> + @param [in] PciInfo Pci device information.
> + @param [in] MappingTable The mapping table structure.
> + @param [in] Uid Unique Id of the Pci device.
> + @param [in, out] PciNode Pci node to amend.
>
> @retval EFI_SUCCESS Success.
> @retval EFI_INVALID_PARAMETER Invalid parameter.
> @@ -67,6 +68,7 @@ EFIAPI
> GeneratePciSlots (
> IN CONST CM_ARM_PCI_CONFIG_SPACE_INFO *PciInfo,
> IN CONST MAPPING_TABLE *MappingTable,
> + IN UINT32 Uid,
> IN OUT AML_OBJECT_NODE_HANDLE PciNode
> );
>
> diff --git a/DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtPcieLibArm/SsdtPcieGenerator.c b/DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtPcieLibArm/SsdtPcieGenerator.c
> index ceffe2838c..24e074ea90 100644
> --- a/DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtPcieLibArm/SsdtPcieGenerator.c
> +++ b/DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtPcieLibArm/SsdtPcieGenerator.c
> @@ -295,6 +295,7 @@ GeneratePciDeviceInfo (
> @param [in] CfgMgrProtocol Pointer to the Configuration Manager
> Protocol interface.
> @param [in] PciInfo Pci device information.
> + @param [in] Uid Unique Id of the Pci device.
> @param [in, out] PciNode Pci node to amend.
>
> @retval EFI_SUCCESS The function completed successfully.
> @@ -308,6 +309,7 @@ GeneratePrt (
> IN ACPI_PCI_GENERATOR *Generator,
> IN CONST EDKII_CONFIGURATION_MANAGER_PROTOCOL *CONST CfgMgrProtocol,
> IN CONST CM_ARM_PCI_CONFIG_SPACE_INFO *PciInfo,
> + IN UINT32 Uid,
> IN OUT AML_OBJECT_NODE_HANDLE PciNode
> )
> {
> @@ -416,7 +418,7 @@ GeneratePrt (
> PrtNode = NULL;
>
> // Generate the Pci slots once all the device have been added.
> - Status = GeneratePciSlots (PciInfo, &Generator->DeviceTable, PciNode);
> + Status = GeneratePciSlots (PciInfo, &Generator->DeviceTable, Uid, PciNode);
> if (EFI_ERROR (Status)) {
> ASSERT (0);
> goto exit_handler;
> @@ -687,6 +689,7 @@ GeneratePciDevice (
> Generator,
> CfgMgrProtocol,
> PciInfo,
> + Uid,
> PciNode
> );
> if (EFI_ERROR (Status)) {
> diff --git a/DynamicTablesPkg/Library/Common/SsdtPcieSupportLib/SsdtPcieSupportLib.c b/DynamicTablesPkg/Library/Common/SsdtPcieSupportLib/SsdtPcieSupportLib.c
> index e5ab3a3ca8..b35fb6a7dd 100644
> --- a/DynamicTablesPkg/Library/Common/SsdtPcieSupportLib/SsdtPcieSupportLib.c
> +++ b/DynamicTablesPkg/Library/Common/SsdtPcieSupportLib/SsdtPcieSupportLib.c
> @@ -41,9 +41,10 @@
> used. It should be possible to enumerate them, but this is additional
> information.
>
> - @param [in] PciInfo Pci device information.
> - @param [in] MappingTable The mapping table structure.
> - @param [in, out] PciNode Pci node to amend.
> + @param [in] PciInfo Pci device information.
> + @param [in] MappingTable The mapping table structure.
> + @param [in] Uid Unique Id of the Pci device.
> + @param [in, out] PciNode Pci node to amend.
>
> @retval EFI_SUCCESS Success.
> @retval EFI_INVALID_PARAMETER Invalid parameter.
> @@ -54,6 +55,7 @@ EFIAPI
> GeneratePciSlots (
> IN CONST CM_ARM_PCI_CONFIG_SPACE_INFO *PciInfo,
> IN CONST MAPPING_TABLE *MappingTable,
> + IN UINT32 Uid,
> IN OUT AML_OBJECT_NODE_HANDLE PciNode
> )
> {
next prev parent reply other threads:[~2022-08-24 21:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-24 4:35 [PATCH v2] DynamicTablesPkg: AcpiSsdtPcieLibArm : Add UID to slot creation Jeff Brasen
2022-08-24 21:12 ` PierreGondois [this message]
2022-09-01 14:00 ` [edk2-devel] " Sami Mujawar
2022-09-01 14:01 ` Sami Mujawar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=532bb58f-8354-9cb6-7080-f63f13121a93@arm.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox