From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-in2.apple.com (mail-out2.apple.com [17.151.62.25]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 6982E1A1E08 for ; Tue, 16 Aug 2016 09:27:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; d=apple.com; s=mailout2048s; c=relaxed/simple; q=dns/txt; i=@apple.com; t=1471364851; x=2335278451; h=From:Sender:Reply-To:Subject:Date:Message-id:To:Cc:MIME-version:Content-type: Content-transfer-encoding:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-reply-to:References:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=F3pdcsSPo2b5X2s++rZ4thVb23D9qVfp3fPhxoMsoo0=; b=28ujAIO4NKD1c+FdBloN+MDokAuIV/NhLTkRO7+GKTfSiB+b6/EB6k1efY6RMhO+ PXeo40NeCerHpWzb+3M6+1F5JtqBiFG0TDN42kBRa0D6uazJawhKojpn2cWRHswL SttaWMqlaA2VsTdJd7twrRQs0kGtIPLwy+f+8O5P9VBV1/HFHaOnPAmPysAz3gbI Cq9IpXddxJ0tkwiL+cJf3LyA5JcUUHgjPE7rVstNwzoJVluPBk7pd2VtQB36WMUW ZWhnP1Z/IcD45rU3nxnPF3P7STyUYdInNXmCz7daTfo8GI2FViOCGeRyRoh688Gp xQ/xu8XUaUY7quxuL52q9w==; Received: from relay3.apple.com (relay3.apple.com [17.128.113.83]) by mail-in2.apple.com (Apple Secure Mail Relay) with SMTP id 82.FE.10360.2FE33B75; Tue, 16 Aug 2016 09:27:30 -0700 (PDT) X-AuditID: 11973e11-f79e76d000002878-43-57b33ef2b2b8 Received: from nwk-mmpp-sz08.apple.com (nwk-mmpp-sz08.apple.com [17.128.115.25]) by relay3.apple.com (Apple SCV relay) with SMTP id DE.95.18578.2FE33B75; Tue, 16 Aug 2016 09:27:30 -0700 (PDT) MIME-version: 1.0 Received: from [17.114.155.95] by nwk-mmpp-sz08.apple.com (Oracle Communications Messaging Server 8.0.1.1.0 64bit (built Jun 15 2016)) with ESMTPSA id <0OC0003JUGDU0420@nwk-mmpp-sz08.apple.com>; Tue, 16 Aug 2016 09:27:30 -0700 (PDT) Sender: afish@apple.com From: Andrew Fish In-reply-to: <4A89E2EF3DFEDB4C8BFDE51014F606A1155EBAE3@shsmsx102.ccr.corp.intel.com> Date: Tue, 16 Aug 2016 09:27:30 -0700 Cc: Kurt Kennett , edk2-devel Message-id: <5330A22A-0CDB-4DDE-8DF6-0F71F13F56D5@apple.com> References: <56352D44-41C4-49D8-8BFA-C92B84CC0CDC@apple.com> <4FA3496D-C050-40FA-8CB1-E3603E431E79@apple.com> <4A89E2EF3DFEDB4C8BFDE51014F606A1155EB6CE@shsmsx102.ccr.corp.intel.com> <4A89E2EF3DFEDB4C8BFDE51014F606A1155EBAE3@shsmsx102.ccr.corp.intel.com> To: "Gao, Liming" X-Mailer: Apple Mail (2.3112) X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrHLMWRmVeSWpSXmKPExsUi2FAYrPvJbnO4wdWF5hZ7Dh1ltpi03MJi xb0N7A7MHov3vGTy6J79j8Wjdcdf9gDmKC6blNSczLLUIn27BK6M5R/vsRXM8q74NmsWawPj W/suRk4OCQETiUf33jFB2GISF+6tZ+ti5OIQEtjLKHHk5y5GmKJNE6cyQSQOMko8eT2XFSTB KyAo8WPyPZYuRg4OZgF1iSlTckHCQgLvGCU6m9lBbGEBcYl3ZzYxQ9i+EjP+rWYBsdkElCVW zP/ADtLKKRAmcbYtHyTMIqAq0Tz/MthaZoFQidlL5rFD2NoST95dYAUp5xWwkdg2MRfimgY2 iQcbz4CNFxHQkHh47zczxMmyEvs2LAD7RULgAJvE7utHmSYwisxCcvUshKtnIVmxgJF5FaNQ bmJmjm5mnpFeYkFBTqpecn7uJkZQBEy3E9zBeHyV1SFGAQ5GJR7eG1abw4VYE8uKK3MPMUpz sCiJ89qaAoUE0hNLUrNTUwtSi+KLSnNSiw8xMnFwSjUwdtSe/iPDxtyvd7DUaUGVYfGStxbe 9tdlJF9ZbQ5bGTt1v6TjWr/r37ZbMPvO/r0wbdbHe8qTvHq7/TWSCzR+vEhU9Q4+YW/MeFb8 tuRSJRE/m7n/V9vyHrz4SLngwE8h8Wstyr3nRbgDZsatawl4uE6EafqF7qL+jhvXvGpqZuSn /TDY13tRiaU4I9FQi7moOBEAg47Kf2ECAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFupkkeLIzCtJLcpLzFFi42IRbCiW1P1ktzncYOtxA4s9h44yW0xabmGx 4t4Gdgdmj8V7XjJ5dM/+x+LRuuMvewBzFJdNSmpOZllqkb5dAlfG8o/32ApmeVd8mzWLtYHx rX0XIyeHhICJxKaJU5kgbDGJC/fWs3UxcnEICRxklHjyei4rSIJXQFDix+R7LF2MHBzMAuoS U6bkgoSFBN4xSnQ2s4PYwgLiEu/ObGKGsH0lZvxbzQJiswkoS6yY/4EdpJVTIEzibFs+SJhF QFWief5lRhCbWSBUYvaSeewQtrbEk3cXWEHKeQVsJLZNzIW4poFN4sHGM2DjRQQ0JB7e+80M cbKsxL4NC9gmMArOQnLoLIRDZyGZuoCReRWjQFFqTmKlsV5iQUFOql5yfu4mRnDAFgbvYPyz zOoQowAHoxIP7w2rzeFCrIllxZW5hxglOJiVRHiXmgGFeFMSK6tSi/Lji0pzUosPMSYD/TKR WUo0OR8YTXkl8YYmJgYmxsZmxsbmJuakCSuJ815SBlohkJ5YkpqdmlqQWgSzhYmDU6qB0ev+ WgHJpNisjHabjwc+8M3/lNpRrtE3Z6f78fMdURaXOC74iHNJHuh1MrUzXN4n913qktkD3nV/ ZtxtuVWyu4yrUmq77heXy2naP1ZXJ5+1etsif3banGmJNy5dDxaUjNVK7E7uvMqiJfPyYLD3 3cWLmmXuXY94O+Wyyu1p3LsWtM1gMtv7UomlOCPRUIu5qDgRAL7ulkGcAgAA Subject: Re: Setting BuildOptions by module type does not seem to work X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Aug 2016 16:27:31 -0000 Content-type: text/plain; charset=utf-8 Content-transfer-encoding: quoted-printable > On Aug 16, 2016, at 9:21 AM, Gao, Liming wrote: >=20 > Andrew: > arch value may be common. 3.3.1 Common Definitions, ::=3D = {"IA32"} {"X64"} {"IPF"} {"EBC"} {} {"common"}. > I agree [BuildOptions.AARCH64.common.DXE_RUNTIME_DRIVER should be = supported. We will look it. >=20 I agree but precedence rules seem different for *.*.*.Edk2ModuleType. It = should follow $(arch) overrides common pattern of the other examples? =E2=80=A2 Highest, DSC file=E2=80=99s component scoped for individual = INF files. =E2=80=A2 [BuildOptions.$(arch).CodeBase.Edk2ModuleType] missing [BuildOptions.common.CodeBase.Edk2ModuleType] =E2=80=A2 [BuildOptions.$(arch).CodeBase] =E2=80=A2 [BuildOptions.common.CodeBase] =E2=80=A2 [BuildOptions.$(arch)] =E2=80=A2 [BuildOptions.common] =E2=80=A2 [BuildOptions] =E2=80=A2 INF File=E2=80=99s [BuildOptions] section =E2=80=A2 Lowest - tools_def.txt entry Thanks, Andrew Fish > Thanks > Liming > From: afish@apple.com [mailto:afish@apple.com] > Sent: Tuesday, August 16, 2016 11:47 PM > To: Kurt Kennett > Cc: edk2-devel ; Gao, Liming = > Subject: Re: [edk2] Setting BuildOptions by module type does not seem = to work >=20 >=20 >> On Aug 16, 2016, at 8:22 AM, Kurt Kennett wrote: >>=20 >> Thanks for your help, Andre. I appreciate it. =E2=98=BA >>=20 >> [BuildOptions.AARCH64.common.DXE_RUNTIME_DRIVER] >> Does not work. >>=20 >=20 > Can you file a bugzilla report on the tools, and another on the spec = to mention BuildOptions.AARCH64.common.DXE_RUNTIME_DRIVER >=20 > Thanks, >=20 > Andrew Fish >=20 >> [BuildOptions.AARCH64.common.EDKII.DXE_RUNTIME_DRIVER] >> Does not work. >>=20 >> [BuildOptions.common.EDKII.DXE_RUNTIME_DRIVER] >> Works. >>=20 >>=20 >> K2 >>=20 >> From: afish@apple.com = [mailto:afish@apple.com] >> Sent: Tuesday, August 16, 2016 8:15 AM >> To: Kurt Kennett >> Cc: Gao, Liming ; edk2-devel >> Subject: Re: [edk2] Setting BuildOptions by module type does not seem = to work >>=20 >>=20 >> On Aug 16, 2016, at 7:49 AM, Kurt Kennett = > wrote: >>=20 >> Hi Liming. I=E2=80=99m a bit confused by your email. >>=20 >> I my original email below, I reference directly: >>=20 >>>> DSC spec (January 2016 1.26) says I can do this: >>>>=20 >>>> (Section 3.6 pp 76) >>=20 >>=20 >> In this section it says: >>=20 >> =E2=80=A6 >> Build options priority (appended from lowest to highest and/or = highest replacement) is: >> =E2=80=A2 Highest, DSC file=E2=80=99s component scoped for individual = INF files. >> =E2=80=A2 [BuildOptions.$(arch).CodeBase.Edk2ModuleType] >> =E2=80=A2 [BuildOptions.$(arch).CodeBase] >> =E2=80=A2 [BuildOptions.common.CodeBase] >> =E2=80=A2 [BuildOptions.$(arch)] >> =E2=80=A2 [BuildOptions.common] >> =E2=80=A2 [BuildOptions] >> =E2=80=A2 INF File=E2=80=99s [BuildOptions] section >> =E2=80=A2 Lowest - tools_def.txt entry >>=20 >> In the =E2=80=9CPrototype=E2=80=9D section immediately below this = (Page 79) is the grammar. >>=20 >> There is no interpretation of the grammar corresponds to >>=20 >> [BuildOptions.common.EDKII.DXE_RUNTIME_DRIVER] >>=20 >> Kurt, >>=20 >> It looks like a bug in the spec as there is a missing Edk2ModuleType = common type. >> =E2=80=A2 [BuildOptions.$(arch).CodeBase.Edk2ModuleType] >> =E2=80=A2 [BuildOptions.common.CodeBase.Edk2ModuleType] >> =E2=80=A2 [BuildOptions.$(arch).CodeBase] >>=20 >> Or I guess you could interpret the spec that the last = BuildOptions.$(arch).CodeBase.Edk2ModuleType wins either common or = matching $(arch)? >>=20 >> Did [BuildOptions.AARCH64.common.DXE_RUNTIME_DRIVER] not work? Did = you try without the illegal entry = [BuildOptions.AARCH64.common.EDKII.DXE_RUNTIME_DRIVER] >>=20 >> Thanks, >>=20 >> Andrew Fish >>=20 >>=20 >>=20 >> Which is the format that actually works in the code. >>=20 >> Is there some other section or interpretation that you are referring = to? >>=20 >> K2 >>=20 >> From: Gao, Liming [mailto:liming.gao@intel.com] >> Sent: Monday, August 15, 2016 7:17 PM >> To: Kurt Kennett = >; = afish@apple.com >> Cc: edk2-devel = > >> Subject: RE: [edk2] Setting BuildOptions by module type does not seem = to work >>=20 >> Hi, >> This style has been defined in DSC spec 1.26. It can be downloaded = from = https://github.com/tianocore/tianocore.github.io/wiki/EDK%20II%20Specifica= tions >>=20 >> Thanks >> Liming >> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf = Of Kurt Kennett >> Sent: Tuesday, August 16, 2016 1:56 AM >> To: afish@apple.com >> Cc: edk2-devel = > >> Subject: Re: [edk2] Setting BuildOptions by module type does not seem = to work >>=20 >> Okay this seems to work: >>=20 >> [BuildOptions.common.EDKII.DXE_RUNTIME_DRIVER] >>=20 >> Thanks Andrew. >>=20 >> (doesn't match the spec though :) ) >>=20 >> K2 >>=20 >> -----Original Message----- >> From: afish@apple.com = [mailto:afish@apple.com] >> Sent: Monday, August 15, 2016 10:30 AM >> To: Kurt Kennett >> Cc: edk2-devel >> Subject: Re: [edk2] Setting BuildOptions by module type does not seem = to work >>=20 >>=20 >>> On Aug 15, 2016, at 9:34 AM, Kurt Kennett wrote: >>>=20 >>> No, I had not tried that. I tried it now and it does not seem to = work. >>>=20 >>> I have: >>>=20 >>> [BuildOptions.AARCH64.common] >>> *_VS2015x86_AARCH64_DLINK_FLAGS =3D /BORK >>>=20 >>> [BuildOptions.AARCH64.common.DXE_RUNTIME_DRIVER] >>> *_VS2015x86_AARCH64_DLINK_FLAGS =3D /PLOR >>>=20 >>> [BuildOptions.AARCH64.common.EDKII.DXE_RUNTIME_DRIVER] >>> *_VS2015x86_AARCH64_DLINK_FLAGS =3D /BONK >>>=20 >>> And the only one that makes it to the command line is the /BORK one. >>>=20 >>> (The tools do not complain about the specification of options as = above). >>>=20 >>=20 >> I'm guessing the syntax checking is not very good? >> [BuildOptions.common.EDKII.DXE_RUNTIME_DRIVER] >> [BuildOptions.AARCH64.common.EDKII.DXE_RUNTIME_DRIVER] >>=20 >> I see the [BuildOptions.common.EDKII.DXE_RUNTIME_DRIVER] form used in = other places, but you have an extra .common? >>=20 >> Thanks, >>=20 >> Andrew Fish >>=20 >>> K2 >>>=20 >>> -----Original Message----- >>> From: afish@apple.com = [mailto:afish@apple.com] >>> Sent: Monday, August 15, 2016 9:22 AM >>> To: Kurt Kennett >>> Cc: edk2-devel >>> Subject: Re: [edk2] Setting BuildOptions by module type does not = seem >>> to work >>>=20 >>>=20 >>>> On Aug 15, 2016, at 9:10 AM, Kurt Kennett wrote: >>>>=20 >>>> DSC spec (January 2016 1.26) says I can do this: >>>>=20 >>>> (Section 3.6 pp 76) >>>>=20 >>>> ... >>>> * [BuildOptions.$(arch).CodeBase.Edk2ModuleType] >>>> ... >>>>=20 >>>> And this works fine: >>>>=20 >>>> [BuildOptions.AARCH64.common] >>>> *_VS2015x86_*_DLINK_FLAGS =3D /BORK >>>>=20 >>>> But when I also do: >>>>=20 >>>> [BuildOptions.AARCH64.common.DXE_RUNTIME_DRIVER] >>>> *_VS2015x86_*_DLINK_FLAGS =3D /PLOR >>>>=20 >>>> The link flags are not affected on the command line - they get the = /BORK for all module types, but not the /PLOR for DXE_RUNTIME_DRIVERs. >>>>=20 >>>=20 >>> Kurt, >>>=20 >>> Have you tried [BuildOptions.AARCH64.EDKII.DXE_RUNTIME_DRIVER]? Do = you need EDK compatibility? >>>=20 >>> I'm guessing that works given: >>> ~/work/src/edk2(master)>git grep "BuildOptions." -- *.dsc | grep >>> DXE_RUNTIME_DRIVER >>> = OvmfPkg/OvmfPkgIa32.dsc:49:[BuildOptions.common.EDKII.DXE_RUNTIME_DRIV >>> ER] >>> = OvmfPkg/OvmfPkgIa32X64.dsc:54:[BuildOptions.common.EDKII.DXE_RUNTIME_D >>> RIVER] >>> = OvmfPkg/OvmfPkgX64.dsc:54:[BuildOptions.common.EDKII.DXE_RUNTIME_DRIVE >>> R] >>> = QuarkPlatformPkg/Quark.dsc:885:[BuildOptions.common.EDKII.DXE_RUNTIME_ >>> DRIVER] >>>=20 >>>=20 >>>> I'm not familiar with the DSC processing tools source. Anybody know = where to look to see why not? >>>>=20 >>>=20 >>> It starts here: >>> = https://github.com/tianocore/edk2/blob/master/BaseTools/Source/Python/ >>> build/build.py and uses some code from: >>> = https://github.com/tianocore/edk2/tree/master/BaseTools/Source/Python/ >>> Common >>>=20 >>> Thanks, >>>=20 >>> Andrew Fish >>>=20 >>>> K2 >>>>=20 >>>>=20 >>>> _______________________________________________ >>>> edk2-devel mailing list >>>> edk2-devel@lists.01.org >>>> https://lists.01.org/mailman/listinfo/edk2-devel >>>=20 >>> _______________________________________________ >>> edk2-devel mailing list >>> edk2-devel@lists.01.org >>> https://lists.01.org/mailman/listinfo/edk2-devel >>=20 >> _______________________________________________ >> edk2-devel mailing list >> edk2-devel@lists.01.org >> https://lists.01.org/mailman/listinfo/edk2-devel >>=20 >> _______________________________________________ >> edk2-devel mailing list >> edk2-devel@lists.01.org >> https://lists.01.org/mailman/listinfo/edk2-devel > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel