public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Laszlo Ersek" <lersek@redhat.com>
To: "Kinney, Michael D" <michael.d.kinney@intel.com>,
	"devel@edk2.groups.io" <devel@edk2.groups.io>,
	Sean Brogan <sean.brogan@microsoft.com>,
	Bret Barkelew <Bret.Barkelew@microsoft.com>
Cc: Vladimir Olovyannikov <vladimir.olovyannikov@broadcom.com>,
	Rebecca Cran <rebecca@bsdio.com>,
	Tom Lendacky <thomas.lendacky@amd.com>
Subject: Re: [edk2-devel] running CI locally
Date: Wed, 19 Aug 2020 19:56:28 +0200	[thread overview]
Message-ID: <53313fdb-0609-9a1f-6e72-424c81a8b20a@redhat.com> (raw)
In-Reply-To: <MN2PR11MB4461B620EC8521E3462D9BECD25D0@MN2PR11MB4461.namprd11.prod.outlook.com>

Hi Mike,

On 08/19/20 17:29, Kinney, Michael D wrote:
> Hi Laszlo,
> 
> Thank you for the feedback.  I agree there are some documentation updates required.
> 
> The spell check requirements are documented here:
> 
> https://github.com/tianocore/edk2/blob/master/.pytool/Readme.md#spell-checking---cspell
> 
> You do need to install nodejs and cspell.
> 
> * Install nodejs from https://nodejs.org/en/
> * Install cspell
>   1. Open cmd prompt with access to node and npm
>   2. Run `npm install -g cspell`

npm is a security hole one can drive a truck through :)

Additionally, I just realized that "nuget" downloads native iasl and
nasm binaries ("BaseTools/Bin/iasl_extdep/Linux-x86/iasl",
"BaseTools/Bin/mu_nasm_extdep/Linux-x86-64/nasm").

This basically requires me to trust two package repositories (npmjs.org,
nuget.org) that, well, I don't trust.

This is *not* criticism of the CI system; it only means that running it
locally on my laptop needs more work from me. In particular, it requires
spinning up a VM that I don't use for anything else.

Given the typing / clicking / scripting necessary for this, and the
network-originated updates for the "in VM" CI system, I wonder if
running CI locally actually saves me any time.

One thing it would certainly give me is "confidentiality", as I wouldn't
have to push my branch to github (for a personal CI build PR) before I
were ready to submit the set for real.

I think I'll set up a new libvirt/QEMU/KVM domain for this, and report
back with more results once I have them.

> I agree that the verbosity of the output is very brief.  There is a more complete
> log that is always produced in the build output directory in Build/CI_BUILDLOG.txt.
> Can you look at that file and see if it provide a more detailed reason for the
> failure?

Yes, I'll check that.

Thanks!
Laszlo


      parent reply	other threads:[~2020-08-19 17:56 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-19 12:27 running CI locally Laszlo Ersek
2020-08-19 15:29 ` [edk2-devel] " Michael D Kinney
2020-08-19 16:22   ` Sean
2020-08-19 17:59     ` Laszlo Ersek
2020-08-21  7:23       ` Laszlo Ersek
2020-08-21 21:36         ` Sean
2020-08-24 12:35           ` Laszlo Ersek
     [not found]         ` <162D662A3371B4DC.7353@groups.io>
2020-08-21 21:50           ` Sean
2020-08-19 17:56   ` Laszlo Ersek [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53313fdb-0609-9a1f-6e72-424c81a8b20a@redhat.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox