From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.61]) by mx.groups.io with SMTP id smtpd.web10.94121.1597859798275238370 for ; Wed, 19 Aug 2020 10:56:38 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=dvLxCv/H; spf=pass (domain: redhat.com, ip: 205.139.110.61, mailfrom: lersek@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1597859797; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=RWxHt8JfNNsIHd8LwkDHhwNGSWPtLOCHsAJpIrn3hsg=; b=dvLxCv/Hg5ztAlpRbu+wb8gYmlutZJqlLadwPfWKxffDbg9OMZ1KkPA+WUOfarjKdMwXPP Lr9MuXY07Jnc7E3zoNuNBUX65ab8BZcVbd/txRJygwoDZMkzPC35U4MpRIkBnDV4kYT/ks d7DUXZwzQuCDoirbhbqB6WpfkbckjP8= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-418-HCHFIxR5NuOgm9INygOlwQ-1; Wed, 19 Aug 2020 13:56:33 -0400 X-MC-Unique: HCHFIxR5NuOgm9INygOlwQ-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 50A3F8030B3; Wed, 19 Aug 2020 17:56:31 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-114-226.rdu2.redhat.com [10.10.114.226]) by smtp.corp.redhat.com (Postfix) with ESMTP id B67A868861; Wed, 19 Aug 2020 17:56:29 +0000 (UTC) Subject: Re: [edk2-devel] running CI locally To: "Kinney, Michael D" , "devel@edk2.groups.io" , Sean Brogan , Bret Barkelew Cc: Vladimir Olovyannikov , Rebecca Cran , Tom Lendacky References: From: "Laszlo Ersek" Message-ID: <53313fdb-0609-9a1f-6e72-424c81a8b20a@redhat.com> Date: Wed, 19 Aug 2020 19:56:28 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Firefox/52.0 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=lersek@redhat.com X-Mimecast-Spam-Score: 0.001 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Hi Mike, On 08/19/20 17:29, Kinney, Michael D wrote: > Hi Laszlo, > > Thank you for the feedback. I agree there are some documentation updates required. > > The spell check requirements are documented here: > > https://github.com/tianocore/edk2/blob/master/.pytool/Readme.md#spell-checking---cspell > > You do need to install nodejs and cspell. > > * Install nodejs from https://nodejs.org/en/ > * Install cspell > 1. Open cmd prompt with access to node and npm > 2. Run `npm install -g cspell` npm is a security hole one can drive a truck through :) Additionally, I just realized that "nuget" downloads native iasl and nasm binaries ("BaseTools/Bin/iasl_extdep/Linux-x86/iasl", "BaseTools/Bin/mu_nasm_extdep/Linux-x86-64/nasm"). This basically requires me to trust two package repositories (npmjs.org, nuget.org) that, well, I don't trust. This is *not* criticism of the CI system; it only means that running it locally on my laptop needs more work from me. In particular, it requires spinning up a VM that I don't use for anything else. Given the typing / clicking / scripting necessary for this, and the network-originated updates for the "in VM" CI system, I wonder if running CI locally actually saves me any time. One thing it would certainly give me is "confidentiality", as I wouldn't have to push my branch to github (for a personal CI build PR) before I were ready to submit the set for real. I think I'll set up a new libvirt/QEMU/KVM domain for this, and report back with more results once I have them. > I agree that the verbosity of the output is very brief. There is a more complete > log that is always produced in the build output directory in Build/CI_BUILDLOG.txt. > Can you look at that file and see if it provide a more detailed reason for the > failure? Yes, I'll check that. Thanks! Laszlo