From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web10.6741.1657117121548242792 for ; Wed, 06 Jul 2022 07:18:42 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: arm.com, ip: 217.140.110.172, mailfrom: thomas.abraham@arm.com) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 483A7106F; Wed, 6 Jul 2022 07:18:41 -0700 (PDT) Received: from [10.57.11.190] (unknown [10.57.11.190]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id A7AC43F792; Wed, 6 Jul 2022 07:18:39 -0700 (PDT) Message-ID: <534e7163-f063-2ba4-f155-8bf69c5c1068@arm.com> Date: Wed, 6 Jul 2022 15:18:37 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH edk2-platforms v2 03/11] Platform/ARM: SGI: Update for IORT revision macro renaming To: Sami Mujawar , devel@edk2.groups.io Cc: ardb+tianocore@kernel.org, pierre.gondois@arm.com, Matteo.Carlini@arm.com, Akanksha.Jain2@arm.com, Ben.Adderson@arm.com, nd@arm.com References: <20220706103952.36268-1-sami.mujawar@arm.com> <20220706103952.36268-4-sami.mujawar@arm.com> From: "Thomas Abraham" In-Reply-To: <20220706103952.36268-4-sami.mujawar@arm.com> Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 06/07/2022 11:39, Sami Mujawar wrote: > The IORT Specification E.d updates the IORT table revision to 5. To > reflect this change the IORT header file has been updated to rename > the EFI_ACPI_IO_REMAPPING_TABLE_REVISION macro which was at Rev 0 to > EFI_ACPI_IO_REMAPPING_TABLE_REV0. > > Therefore, update the usage of EFI_ACPI_IO_REMAPPING_TABLE_REVISION > macro in the IORT table for SGI platforms to > EFI_ACPI_IO_REMAPPING_TABLE_REV0. > > Signed-off-by: Sami Mujawar > --- > Platform/ARM/SgiPkg/AcpiTables/Iort.aslc | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Platform/ARM/SgiPkg/AcpiTables/Iort.aslc b/Platform/ARM/SgiPkg/AcpiTables/Iort.aslc > index fcc28a71c82eb0c78c96d60c9d9eb1554adb41a3..415403e8e8e5946d3a2319d83b76d6182a8a1e74 100644 > --- a/Platform/ARM/SgiPkg/AcpiTables/Iort.aslc > +++ b/Platform/ARM/SgiPkg/AcpiTables/Iort.aslc > @@ -50,7 +50,7 @@ ARM_EFI_ACPI_6_0_IO_REMAPPING_TABLE Iort = > ( > EFI_ACPI_6_2_IO_REMAPPING_TABLE_SIGNATURE, > ARM_EFI_ACPI_6_0_IO_REMAPPING_TABLE, > - EFI_ACPI_IO_REMAPPING_TABLE_REVISION > + EFI_ACPI_IO_REMAPPING_TABLE_REV0 nit: Should this have been EFI_ACPI_IO_REMAPPING_TABLE_REVISION_0 to better align with all the other table revision macros? > ), > 3, // NumNodes > sizeof (EFI_ACPI_6_0_IO_REMAPPING_TABLE), // NodeOffset Reviewed-by: Thomas Abraham Thanks.