From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-1.mimecast.com (us-smtp-1.mimecast.com [207.211.31.120]) by mx.groups.io with SMTP id smtpd.web10.10877.1591105316260417442 for ; Tue, 02 Jun 2020 06:41:56 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=hWBEpDxk; spf=pass (domain: redhat.com, ip: 207.211.31.120, mailfrom: lersek@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1591105315; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ZAj12Pwhx7UAU5b7sy02E5VDpshtYHnmqF41jBIk5JE=; b=hWBEpDxkZFT9DFoMdizHw9p3Ls9oFJCC7Dx52bNlfikqh2T1+ED5hcglg4XPMDzmKwGcYC HS6pLm3iW9YUQbsFRtugpBRJwtUDxMmG7/PSwtIPhzqX/9ozhlD3GChYMrKCnFlcmbS0On k+YdkY6w/uIUKaxSNEbrxev2koIn83o= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-269-Ukcq8FVpOKmq7faF3iHuaw-1; Tue, 02 Jun 2020 09:41:51 -0400 X-MC-Unique: Ukcq8FVpOKmq7faF3iHuaw-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id AEBFF800053; Tue, 2 Jun 2020 13:41:49 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-115-66.ams2.redhat.com [10.36.115.66]) by smtp.corp.redhat.com (Postfix) with ESMTP id DA87D5D9CC; Tue, 2 Jun 2020 13:41:46 +0000 (UTC) Subject: Re: [PATCH] Maintainers.txt: Add reviewers for security features. To: Eric Dong , devel@edk2.groups.io Cc: Hao A Wu , Jiewen Yao , Jian J Wang , Chao Zhang , Ray Ni , Debkumar De , Harry Han , Catharine West , Qi Zhang , Rahul Kumar , Min Xu References: <20200601080755.579-1-eric.dong@intel.com> From: "Laszlo Ersek" Message-ID: <535d4a36-c866-e653-ea08-bb77ca92d8d5@redhat.com> Date: Tue, 2 Jun 2020 15:41:45 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20200601080755.579-1-eric.dong@intel.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Hi Eric, On 06/01/20 10:07, Eric Dong wrote: > Add reviewers to review security related changes. > Impacted below modules: > > MdeModulePkg: Pei Core > F: MdeModulePkg/Core/Pei/ > > SecurityPkg: Tcg related modules > F: SecurityPkg/Tcg/ > > SecurityPkg: Secure boot related modules > F: SecurityPkg/Library/DxeImageVerificationLib/ > F: SecurityPkg/VariableAuthenticated/SecureBootConfigDxe/ > F: SecurityPkg/Library/AuthVariableLib/ > > UefiCpuPkg: Sec related modules > F: UefiCpuPkg/SecCore/ > F: UefiCpuPkg/ResetVector/ > > Signed-off-by: Eric Dong > Cc: Hao A Wu > Cc: Jiewen Yao > Cc: Jian J Wang > Cc: Chao Zhang > Cc: Ray Ni > Cc: Laszlo Ersek > Cc: Debkumar De > Cc: Harry Han > Cc: Catharine West > Cc: Qi Zhang > Cc: Rahul Kumar > Cc: Min Xu > --- > Maintainers.txt | 28 +++++++++++++++++++++++++++- > 1 file changed, 27 insertions(+), 1 deletion(-) This patch should be split in at least 3 parts (one per package). Maybe even 4 parts (if we want to keep the TCG vs. Secure Boot section update separate). There are two reasons for this: (1) Better review granularity. For a (random!) example, Debkumar De is not added under SecurityPkg, therefore Debkumar should not be forced to look at the SecurityPkg hunks. But now that's a problem, because the patch contains everything. (2) Such patches are actually code. They influence how "BaseTools/Scripts/GetMaintainer.py works. For example, when you introduce "MdeModulePkg: Pei Core" as a separate subsystem, I have to verify that you also remove it from under "MdeModulePkg: Core services (PEI, DXE and Runtime) modules". In addition, I review that Dandan and Liming *remain* reviewers for the PEI Core (because they are listed under "MdeModulePkg: Core services (PEI, DXE and Runtime) modules" as well), and that Debkumar, Harry and Catharine are *new* reviewers. I also have to check that the resultant reviewer list, for the new "MdeModulePkg: Pei Core" subsystem does not overlap with the general MdeModulePkg owners (Jian, Hao). So that's all good, but it's complex enough that I really don't want to handle *multiple packages* in this regard in a single patch. The same procedure has to be done for SecurityPkg and UefiCpuPkg as well (on the reviewer side), and having them all in a single patch makes the review needlessly difficult. So split this up please. Thanks Laszlo > > diff --git a/Maintainers.txt b/Maintainers.txt > index 76f336b7dc..4f316cfc60 100644 > --- a/Maintainers.txt > +++ b/Maintainers.txt > @@ -258,6 +258,14 @@ F: MdeModulePkg/Universal/Console/ > R: Zhichao Gao > R: Ray Ni > > +MdeModulePkg: Pei Core > +F: MdeModulePkg/Core/Pei/ > +R: Dandan Bi > +R: Liming Gao > +R: Debkumar De > +R: Harry Han > +R: Catharine West > + > MdeModulePkg: Core services (PEI, DXE and Runtime) modules > F: MdeModulePkg/*Mem*/ > F: MdeModulePkg/*SectionExtract*/ > @@ -265,7 +273,6 @@ F: MdeModulePkg/*StatusCode*/ > F: MdeModulePkg/Application/DumpDynPcd/ > F: MdeModulePkg/Core/Dxe/ > F: MdeModulePkg/Core/DxeIplPeim/ > -F: MdeModulePkg/Core/Pei/ > F: MdeModulePkg/Core/RuntimeDxe/ > F: MdeModulePkg/Include/*Mem*.h > F: MdeModulePkg/Include/*Pcd*.h > @@ -463,6 +470,17 @@ M: Jiewen Yao > M: Jian J Wang > R: Chao Zhang > > +SecurityPkg: Tcg related modules > +F: SecurityPkg/Tcg/ > +R: Qi Zhang > +R: Rahul Kumar > + > +SecurityPkg: Secure boot related modules > +F: SecurityPkg/Library/DxeImageVerificationLib/ > +F: SecurityPkg/VariableAuthenticated/SecureBootConfigDxe/ > +F: SecurityPkg/Library/AuthVariableLib/ > +R: Min Xu > + > ShellPkg > F: ShellPkg/ > W: https://github.com/tianocore/tianocore.github.io/wiki/ShellPkg > @@ -486,6 +504,14 @@ W: https://github.com/tianocore/tianocore.github.io/wiki/UefiCpuPkg > M: Eric Dong > M: Ray Ni > R: Laszlo Ersek > +R: Rahul Kumar > + > +UefiCpuPkg: Sec related modules > +F: UefiCpuPkg/SecCore/ > +F: UefiCpuPkg/ResetVector/ > +R: Debkumar De > +R: Harry Han > +R: Catharine West > > UefiPayloadPkg > F: UefiPayloadPkg/ >