From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f65.google.com (mail-wr1-f65.google.com [209.85.221.65]) by mx.groups.io with SMTP id smtpd.web12.7504.1587472179578096657 for ; Tue, 21 Apr 2020 05:29:40 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@akeo-ie.20150623.gappssmtp.com header.s=20150623 header.b=DCGUcXtD; spf=none, err=permanent DNS error (domain: akeo.ie, ip: 209.85.221.65, mailfrom: pete@akeo.ie) Received: by mail-wr1-f65.google.com with SMTP id g13so14218573wrb.8 for ; Tue, 21 Apr 2020 05:29:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=akeo-ie.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=TM37QxzMKDtfHZn4Fb/X6kZQyxIuj8D5EK8coc1TlGE=; b=DCGUcXtDWu7WszTon0tsmfJmh5SAtDBIsH6wCzx4BRjC16dUK6clyX5HReFtziNjl8 oyHuu29ehuv/RMwc1eh9iiw2foHYDfNWJum3XZ/hMDO6xLgVuM8HeQZHyC2t1TmPXUFM c+lKpI74iNUYa/gCrXUQaQWlVwRjPA4kS0f+nDrXYeA+kyEO3cgJ6sv1+2Qs/VHARa+a R1tNsUm8hVb1SxDInDSpmQNYbWBNFCKM2RMaaf8o+WAZmtJHRMIJV+fpX4v1xTyhiPLv Th89jqEvYg5yIhi4p7hfdMTq2Spp8AuWCnMWqnvF+q4SSlvLAIu/VMxiiecUrZFkmHiV 2Cgw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=TM37QxzMKDtfHZn4Fb/X6kZQyxIuj8D5EK8coc1TlGE=; b=C6VYHLlfFy2EqAlCB4TOVOOWwmdhcM2o878zcfC8yg1Wjc+m/0Q0v/E8PH0MS4LOXf F43+N6/DXIsNhXHXM5n5gYy31zwSiA6SMMDwoCnMD/BYe53TEVE+imz9ZfZ4Xa8LcOkf xLsWmLqbo2YH8F7+MhM6KqPiVC/Iz+8ymXuiI/7ICiVVP2gkdAstgqEyWQ9sYmlp2X+D foPF18RmXRApzZ27IeVQtKr+NbMKSM4dc+r7f8KcTgao2py3lR1NsmvnuSZTsoA5zAUJ 2ZgodYWuFfz76y8m11746uJ34zCEMsdVSkBfDiWO+57A1t6WGr2v5xX2wiPWz0xxtdOC uMpQ== X-Gm-Message-State: AGi0PublQvxDkx61yKlS/J3fuMBFwym6np0mJB1AcFjhcf/vhKoPQLUM Ip0SVFAmJZq+EGzXiyhevyGTCQ== X-Google-Smtp-Source: APiQypLvQ4voVJ9sDIKAUGpDmdU0RKJBoQahwWhHEOJDnF3Th1UTls3XXziKyIpvAI1BPtkpyfpLRg== X-Received: by 2002:adf:9d8d:: with SMTP id p13mr18148316wre.17.1587472178122; Tue, 21 Apr 2020 05:29:38 -0700 (PDT) Return-Path: Received: from [10.0.0.122] ([84.203.47.66]) by smtp.googlemail.com with ESMTPSA id w12sm3668262wrk.56.2020.04.21.05.29.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 21 Apr 2020 05:29:37 -0700 (PDT) Subject: Re: [edk2-non-osi][PATCH 1/1] Platform/RPi/TrustedFirmware: Update TF-A binaries to v2.3 release To: Ard Biesheuvel , devel@edk2.groups.io Cc: leif@nuviainc.com, awarkentin@vmware.com References: <20200421112931.11752-1-pete@akeo.ie> <9bcf3dcc-71a3-49c8-5a88-ea2d5a11432d@arm.com> From: "Pete Batard" Message-ID: <538f4820-19a0-f483-37d8-805af415702f@akeo.ie> Date: Tue, 21 Apr 2020 13:29:35 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <9bcf3dcc-71a3-49c8-5a88-ea2d5a11432d@arm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 8bit Hi Ard, On 2020.04.21 13:20, Ard Biesheuvel wrote: > On 4/21/20 1:29 PM, Pete Batard wrote: >> With the v2.3 release of TF-A, that integrates automatic PL011 vs >> miniUART >> switching, we can remove the dual bl31 binaries we were using for RPi4, >> and of course, we also take this opportunity to update the RPi3 binaries >> to the latest. >> >> Note that these binaries were built in an open and verifiable manner >> through an AppVeyor build script (https://github.com/pbatard/pitf). >> >> Signed-off-by: Pete Batard >> --- >>   Platform/RaspberryPi/RPi3/TrustedFirmware/Readme.md         |  16 >> ++++++++-------- >>   Platform/RaspberryPi/RPi3/TrustedFirmware/bl1.bin           | Bin >> 18776 -> 18837 bytes >>   Platform/RaspberryPi/RPi3/TrustedFirmware/fip.bin           | Bin >> 45792 -> 53972 bytes >>   Platform/RaspberryPi/RPi4/TrustedFirmware/Readme.md         |  16 >> ++++++++++------ >>   Platform/RaspberryPi/RPi4/TrustedFirmware/bl31.bin          | Bin 0 >> -> 41067 bytes >>   Platform/RaspberryPi/RPi4/TrustedFirmware/bl31_miniuart.bin | Bin >> 41072 -> 0 bytes >>   Platform/RaspberryPi/RPi4/TrustedFirmware/bl31_pl011.bin    | Bin >> 41072 -> 0 bytes >>   7 files changed, 18 insertions(+), 14 deletions(-) >> > > I gave these a spin, and my RPi3 isn't booting. I then went back to your > v1.21 release, and it doesn't boot either. Log of my DEBUG build below - > any thoughts? You may need an updated start.elf (along with bootcode.bin, which needs to match the release date of start/elf). What happens if you pick the files from https://github.com/pftf/RPi3/releases and just replace your RPI_EFI.fd? For the record, I did test the patches I sent in just that manner, applied on top of latest platforms/non-osi, for both Pi3 and Pi4 (with and without PL011 overlay) and didn't see any ASSERT. Regards, /Pete > > > > > Raspberry Pi Bootcode > Read File: config.txt, 93 > Read File: start.elf, 2884708 (bytes) > Read File: fixup.dat, 6746 (bytes) > MESS:00:00:01.526885:0: brfs: File read: /mfs/sd/config.txt > MESS:00:00:01.531096:0: brfs: File read: 93 bytes > MESS:00:00:01.587076:0: brfs: File read: /mfs/sd/config.txt > MESS:00:00:01.591292:0: gpioman: gpioman_get_pin_num: pin LEDS_PWR_OK > not defined > MESS:00:00:01.795773:0: gpioman: gpioman_get_pin_num: pin > DISPLAY_DSI_PORT not defined > MESS:00:00:01.803201:0: gpioman: gpioman_get_pin_num: pin LEDS_PWR_OK > not defined > MESS:00:00:01.809220:0: *** Restart logging > MESS:00:00:01.813107:0: brfs: File read: 93 bytes > MESS:00:00:01.834674:0: hdmi: HDMI:hdmi_get_state is deprecated, use > hdmi_get_display_state instead > MESS:00:00:01.853083:0: brfs: File read: /mfs/sd/bcm2710-rpi-3-b.dtb > MESS:00:00:01.857754:0: Loading 'bcm2710-rpi-3-b.dtb' to 0x100 size 0x675f > MESS:00:00:02.073260:0: brfs: File read: 26463 bytes > MESS:00:00:02.079132:0: brfs: File read: /mfs/sd/config.txt > MESS:00:00:02.084442:0: brfs: File read: 93 bytes > MESS:00:00:02.089923:0: brfs: File read: /mfs/sd/cmdline.txt > MESS:00:00:02.093917:0: Read command line from file 'cmdline.txt': > MESS:00:00:02.099785:0: 'console=serial0,115200 console=tty1 > root=/dev/mmcblk0p7 rootfstype=ext4 elevator=deadline fsck.repair=yes > rootwait quiet splash plymouth.ignore-serial-consoles' > MESS:00:00:04.177869:0: gpioman: gpioman_get_pin_num: pin EMMC_ENABLE > not defined > MESS:00:00:04.347941:0: brfs: File read: 160 bytes > MESS:00:00:04.484887:0: brfs: File read: /mfs/sd/RPI_EFI.fd > MESS:00:00:04.488762:0: Loading 'RPI_EFI.fd' to 0x0 size 0x200000 > MESS:00:00:04.494604:0: brfs: File read: 2097152 bytes > MESS:00:00:05.334051:0: brfs: File read: /mfs/sd/kernel8.img > MESS:00:00:05.338010:0: Loading 'kernel8.img' to 0x80000 size 0xc9e200 > MESS:00:00:05.344269:0: Device tree loaded to 0x2eff9400 (size 0x6b8a) > MESS:00:00:05.351740:0: uart: Set PL011 baud rate to 103448.300000 Hz > MESS:00:00:05.358222:0: uart: Baud rate change done... > MESS:00:00:05.361652:0: uart: Baud rateNOTICE:  Booting Trusted Firmware > NOTICE:  BL1: v2.3():v2.3 > NOTICE:  BL1: Built : 10:40:46, Apr 21 2020 > NOTICE:  rpi3: Detected: Raspberry Pi 3 Model B (1GB, Embest, China) > [0x00a22082] > NOTICE:  BL1: Booting BL2 > NOTICE:  BL2: v2.3():v2.3 > NOTICE:  BL2: Built : 10:40:42, Apr 21 2020 > NOTICE:  BL1: Booting BL31 > NOTICE:  BL31: v2.3():v2.3 > NOTICE:  BL31: Built : 10:40:44, Apr 21 2020 > UEFI firmware (version EDK2-DEV built at 14:02:06 on Apr 21 2020) > Board Rev: 0xA22082 > Base RAM : 0x00000000 (Size 0x3B400000) > VideoCore: 0x3B400000 (Size 0x04C00000) > FD: >         PhysicalBase: 0x0 >         VirtualBase: 0x0 >         Length: 0x1E0000 > FD Variables: >         PhysicalBase: 0x1E0000 >         VirtualBase: 0x1E0000 >         Length: 0x20000 > TF-A RAM: >         PhysicalBase: 0x200000 >         VirtualBase: 0x200000 >         Length: 0x200000 > Base System RAM: >         PhysicalBase: 0x400000 >         VirtualBase: 0x400000 >         Length: 0x3B000000 > GPU Reserved: >         PhysicalBase: 0x3B400000 >         VirtualBase: 0x3B400000 >         Length: 0x3C00000 > SoC Reserved (283x): >         PhysicalBase: 0x3F000000 >         VirtualBase: 0x3F000000 >         Length: 0x2000000 > Decompress Failed - Invalid Parameter > > ASSERT_EFI_ERROR (Status = Not Found) > ASSERT [ArmPlatformPrePiUniCore] > /home/ardbie01/build/edk2/ArmPlatformPkg/PrePi/PrePi.c(152): !EFI_ERROR > (Status)