From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.groups.io with SMTP id smtpd.web08.673.1614612536563547986 for ; Mon, 01 Mar 2021 07:28:56 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=B+v4xG9y; spf=pass (domain: redhat.com, ip: 170.10.133.124, mailfrom: lersek@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1614612535; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=4yLmSKHeLp3Y38crdkVCln+ooIy5U3N6o6hubi2fKTs=; b=B+v4xG9y/SY9TamPiVsVdMoL99aIJ594JfxT3s5mZm1Mp2HphXrSIDoJcpR4pceL1j2lFn a8tjsNbhgjuwk3XUm/7ESEqYiroPRAjjuPXG0OuMTjWpC2I/kM2ccocqf671ASpoxk2+fE JfMp/ogObzy/2+4o8igBqmG8X+gs90A= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-16-zA18nXPJMRaFgueidaN6TA-1; Mon, 01 Mar 2021 10:28:46 -0500 X-MC-Unique: zA18nXPJMRaFgueidaN6TA-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 080891005501; Mon, 1 Mar 2021 15:28:45 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-114-254.ams2.redhat.com [10.36.114.254]) by smtp.corp.redhat.com (Postfix) with ESMTP id E2C5E5D9E3; Mon, 1 Mar 2021 15:28:41 +0000 (UTC) Subject: =?UTF-8?B?UmU6IOWbnuWkjTogW2VkazItZGV2ZWxdIFNvZnQgRmVhdHVyZSBGcmVlemUgc3RhcnRzIG5vdyBmb3IgZWRrMi1zdGFibGUyMDIxMDI=?= To: gaoliming , devel@edk2.groups.io, announce@edk2.groups.io, 'Andrew Fish' , leif@nuviainc.com, 'Michael D Kinney' Cc: 'Soumya Guptha' , ray.ni@intel.com, w.sheng@intel.com, 'Ming Huang' , jiewen.yao@intel.com References: <16660439D2A488A3.5517@groups.io> <00bf01d70c08$661b0f00$32512d00$@byosoft.com.cn> From: "Laszlo Ersek" Message-ID: <53959bcb-45c6-5237-0597-b1f789d10796@redhat.com> Date: Mon, 1 Mar 2021 16:28:41 +0100 MIME-Version: 1.0 In-Reply-To: <00bf01d70c08$661b0f00$32512d00$@byosoft.com.cn> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=lersek@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=UTF-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Hi Liming, On 02/26/21 07:27, gaoliming wrote: > Hi, Stewards and All: > > So far, there are still three patch sets to be requested to catch this > stable tag. They are bug fixes, and pass code review in soft feature freeze > phase. Have you any comments for them? > > > > 1. Fix two issue in ArmGicLib > (https://edk2.groups.io/g/devel/message/72175) > > 2. Fix CET shadow stack token busy bit clear issue > (https://edk2.groups.io/g/devel/message/71864) > > [Liming] this version uses DB for the instruction. BZ > https://bugzilla.tianocore.org/show_bug.cgi?id=3227 is create for future > enhancement. > > 3. Use XADD to avoid lock acquire/release > (https://edk2.groups.io/g/devel/message/71516) I agree that the first two patch sets are bugfixes, but I'm not entirely convinced the third one is a bugfix as well -- it is a performance optimization, to my understanding. Without that patch set, there is no misbehavior, things are just slower. The bugfixes can be merged of course; I wouldn't merge the 3rd series however. ... I can see Ray pushed the first patch of the third series: I disagree with that. Here's an excerpt from the commit message: With this patch, OVMF when running in a 255 threads QEMU spends about one second to wakeup all APs. Original implementation needs more than 10 seconds. I wouldn't call the pre-patch behavior a bug. And the review for "[PATCH v3 1/4] UefiCpuPkg/MpInitLib: Use XADD to avoid lock acquire/release" only arrived (from Mike) after the SFF, so I don't think it should have been pushed. On the other hand, I also won't ask for a revert. Thanks Laszlo > > > > Thanks > > Liming > > 发件人: bounce+27952+71922+4905953+8761045@groups.io > 代表 gaoliming > 发送时间: 2021年2月22日 16:23 > 收件人: devel@edk2.groups.io; announce@edk2.groups.io > 抄送: 'Andrew Fish' ; 'Laszlo Ersek' ; > leif@nuviainc.com; 'Michael D Kinney' ; 'Soumya > Guptha' > 主题: [edk2-devel] Soft Feature Freeze starts now for edk2-stable202102 > > > > Hi, all > > We will enter into Soft Feature Freeze phase. In this phase, the feature > under review will not be allowed to be merged. The feature passed review can > still be merged. > > > > The patch review can continue without break in edk2 community. If the patch > is sent before Soft Feature Freeze, and plans to catch this stable tag, the > patch contributor need reply to his patch and notify edk2 community. If the > patch is sent after Soft Feature Freeze, and plans to catch this stable tag, > please add edk2-stable202102 key words in the patch title and BZ, so the > community know this patch target and give the feedback. > > > > Below is edk2-stable202102 tag planning > https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Release-Plannin > g Proposed Schedule > > Date (00:00:00 UTC-8) Description > > 2020-11-27 Beginning of development > > 2021-02-15 Feature Planning Freeze > > 2021-02-22 Soft Feature Freeze > > 2021-03-01 Hard Feature Freeze > > 2021-03-05 Release > > > > Thanks > > Liming > > > >