From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by mx.groups.io with SMTP id smtpd.web11.6013.1597307482357839768 for ; Thu, 13 Aug 2020 01:31:23 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=i16Gui4o; spf=pass (domain: redhat.com, ip: 63.128.21.124, mailfrom: lersek@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1597307481; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=K+nktk0aBVr5Wo4G/QOSzgowS/nCNAlf11s7esWE5NY=; b=i16Gui4oSgnM/4Wc5iunFEBQ+nP5PFivqGJ8KRsKx43RTaJrOxtm4t95fli7HrAbdZoCvX kQNK01ep7SUQW4B1S0cLjm7ZaQ5IgHncU79TIpHYwTu/7ZyROx+JNJ9a0rPfp+XXLgYv3I FaVYI2IfCvlu8c9hR9mY9Q3BE6Y8yAg= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-414-uOB6jw2bOHiITIZvjzHqxw-1; Thu, 13 Aug 2020 04:31:14 -0400 X-MC-Unique: uOB6jw2bOHiITIZvjzHqxw-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 14A061009610; Thu, 13 Aug 2020 08:31:13 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-114-59.ams2.redhat.com [10.36.114.59]) by smtp.corp.redhat.com (Postfix) with ESMTP id 0D086100AE51; Thu, 13 Aug 2020 08:31:11 +0000 (UTC) Subject: Re: [PATCH v6 4/5] ArmVirtPkg: Add RngLib based on TimerLib for CryptoPkg To: matthewfcarlson@gmail.com, devel@edk2.groups.io Cc: Ard Biesheuvel , Leif Lindholm References: <20200812224338.287-1-matthewfcarlson@gmail.com> <20200812224338.287-5-matthewfcarlson@gmail.com> From: "Laszlo Ersek" Message-ID: <53aa1410-7965-3304-71ef-eacf22a0d92c@redhat.com> Date: Thu, 13 Aug 2020 10:31:11 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Firefox/52.0 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20200812224338.287-5-matthewfcarlson@gmail.com> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=lersek@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit On 08/13/20 00:43, matthewfcarlson@gmail.com wrote: > From: Matthew Carlson > > Updates the DSC for the ArmVirtPkg platform to add a RngLib that uses the > TimerLib. This is due to a later change that adds TimerLib as a dependency > for OpenSSL. The TimerLib based RngLib mimics the behavior of OpenSSL > previously and it is recommended to switch to a better source of > entropy than the system's performance counter. > > Ref: https://github.com/tianocore/edk2/pull/845 > Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1871 > > Cc: Laszlo Ersek > Cc: Ard Biesheuvel > Cc: Leif Lindholm > Signed-off-by: Matthew Carlson > --- > ArmVirtPkg/ArmVirt.dsc.inc | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/ArmVirtPkg/ArmVirt.dsc.inc b/ArmVirtPkg/ArmVirt.dsc.inc > index cf44fc73890b..cb3845d2bd37 100644 > --- a/ArmVirtPkg/ArmVirt.dsc.inc > +++ b/ArmVirtPkg/ArmVirt.dsc.inc > @@ -160,6 +160,7 @@ > OpensslLib|CryptoPkg/Library/OpensslLib/OpensslLibCrypto.inf > !endif > BaseCryptLib|CryptoPkg/Library/BaseCryptLib/BaseCryptLib.inf > + RngLib|MdePkg/Library/BaseRngLibTimerLib/BaseRngLibTimerLib.inf > > # > # Secure Boot dependencies > Reviewed-by: Laszlo Ersek