From mboxrd@z Thu Jan  1 00:00:00 1970
Authentication-Results: mx.groups.io;
 dkim=missing; spf=pass (domain: redhat.com, ip: 209.132.183.28, mailfrom: lersek@redhat.com)
Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28])
 by groups.io with SMTP; Wed, 10 Jul 2019 09:06:55 -0700
Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mx1.redhat.com (Postfix) with ESMTPS id 87D758535C;
	Wed, 10 Jul 2019 16:06:54 +0000 (UTC)
Received: from lacos-laptop-7.usersys.redhat.com (ovpn-117-153.ams2.redhat.com [10.36.117.153])
	by smtp.corp.redhat.com (Postfix) with ESMTP id 253635D9CA;
	Wed, 10 Jul 2019 16:06:52 +0000 (UTC)
Subject: Re: [PATCH] Maintainers.txt: Remove maintainer info for IntelFsp[Wrapper]Pkg
To: Ray Ni <ray.ni@intel.com>, devel@edk2.groups.io
Cc: Andrew Fish <afish@apple.com>, Leif Lindholm <leif.lindholm@linaro.org>,
 Michael D Kinney <michael.d.kinney@intel.com>,
 Liming Gao <liming.gao@intel.com>
References: <20190710080504.83772-1-ray.ni@intel.com>
From: "Laszlo Ersek" <lersek@redhat.com>
Message-ID: <53c3028b-95f9-a9ed-76fe-516a32f1820c@redhat.com>
Date: Wed, 10 Jul 2019 18:06:52 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: <20190710080504.83772-1-ray.ni@intel.com>
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.25]); Wed, 10 Jul 2019 16:06:54 +0000 (UTC)
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit

On 07/10/19 10:05, Ray Ni wrote:
> Signed-off-by: Ray Ni <ray.ni@intel.com>
> Cc: Andrew Fish <afish@apple.com>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Cc: Leif Lindholm <leif.lindholm@linaro.org>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Liming Gao <liming.gao@intel.com>
> ---
>  Maintainers.txt | 12 ------------
>  1 file changed, 12 deletions(-)
> 
> diff --git a/Maintainers.txt b/Maintainers.txt
> index 788b46202c..eb41dba7b1 100644
> --- a/Maintainers.txt
> +++ b/Maintainers.txt
> @@ -130,18 +130,6 @@ M: Chasel Chiu <chasel.chiu@intel.com>
>  R: Nate DeSimone <nathaniel.l.desimone@intel.com>
>  R: Star Zeng <star.zeng@intel.com>
>  
> -IntelFspPkg
> -W: https://github.com/tianocore/tianocore.github.io/wiki/IntelFspPkg
> -M: Chasel Chiu <chasel.chiu@intel.com>
> -R: Nate DeSimone <nathaniel.l.desimone@intel.com>
> -R: Star Zeng <star.zeng@intel.com>
> -
> -IntelFspWrapperPkg
> -W: https://github.com/tianocore/tianocore.github.io/wiki/IntelFspWrapperPkg
> -M: Chasel Chiu <chasel.chiu@intel.com>
> -R: Nate DeSimone <nathaniel.l.desimone@intel.com>
> -R: Star Zeng <star.zeng@intel.com>
> -
>  MdeModulePkg
>  W: https://github.com/tianocore/tianocore.github.io/wiki/MdeModulePkg
>  M: Jian J Wang <jian.j.wang@intel.com>
> 

The patch itself looks OK to me, but I dislike empty commit message
bodies. Please say at least something like the following:

"We removed IntelFspPkg and IntelFspWrapperPkg for
<https://bugzilla.tianocore.org/show_bug.cgi?id=1819>; now remove the
dangling maintainer/reviewer assignments too".

With that update (no need to repost):

Reviewed-by: Laszlo Ersek <lersek@redhat.com>

Thanks
Laszlo