Re: [edk2-devel] [edk2-platforms][PATCH] Platform/RPi4: Fix SDHC interrupt numbers.

["Philippe Mathieu-Daudé" <philmd@redhat.com>]

Cc'ing Samer because he has access to the datasheet, and I wonder if 
Linux is right.

Samer, do you mind to confirm this fix?

Thanks,

Phil.

On 12/31/19 11:39 AM, Pete Batard wrote:
> Many thanks for fixing these.
> 
> Reviewed-by: Pete Batard <pete@akeo.ie>
> 
> On 2019-12-30 15:07, Jared McNeill wrote:
>> According to the bcm2711 devicetree, the Arasan SDHCI uses GIC SPI 126
>> and the Broadcom SDHost uses GIC SPI 120.
>>
>> Signed-off-by: Jared McNeill <jmcneill@invisible.ca>
>> ---
>>   Platform/RaspberryPi/RPi4/AcpiTables/Sdhc.asl | 4 ++--
>>   1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/Platform/RaspberryPi/RPi4/AcpiTables/Sdhc.asl 
>> b/Platform/RaspberryPi/RPi4/AcpiTables/Sdhc.asl
>> index 57ee411a61..56d15c3927 100644
>> --- a/Platform/RaspberryPi/RPi4/AcpiTables/Sdhc.asl
>> +++ b/Platform/RaspberryPi/RPi4/AcpiTables/Sdhc.asl
>> @@ -33,7 +33,7 @@ Device (SDC1)
>>       Name (RBUF, ResourceTemplate ()
>>       {
>>         MEMORY32FIXED (ReadWrite, 0xFE300000, 0x100,)
>> -      Interrupt (ResourceConsumer, Level, ActiveHigh, Exclusive) { 
>> 0x5E }
>> +      Interrupt (ResourceConsumer, Level, ActiveHigh, Exclusive) { 
>> 0x9E }
>>       })
>>       Return (RBUF)
>>     }
>> @@ -76,7 +76,7 @@ Device (SDC2)
>>       Name (RBUF, ResourceTemplate ()
>>       {
>>         MEMORY32FIXED (ReadWrite, 0xFE202000, 0x100,)
>> -      Interrupt (ResourceConsumer, Level, ActiveHigh, Exclusive) { 
>> 0x58 }
>> +      Interrupt (ResourceConsumer, Level, ActiveHigh, Exclusive) { 
>> 0x98 }
>>       })
>>       Return (RBUF)
>>     }
>>
> 
> 
> 
>