From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.81]) by mx.groups.io with SMTP id smtpd.web09.3053.1577799020118229128 for ; Tue, 31 Dec 2019 05:30:20 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=Cz/aRK9+; spf=pass (domain: redhat.com, ip: 207.211.31.81, mailfrom: philmd@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1577799019; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=NDrQGnTRpMuGKKTLz0fS2yhtNM5mqXOho/rHLVrXXJ4=; b=Cz/aRK9+qzewm85cYmYZpIWvYqdOBTVtz1d8mDh5JXQ4ZJqM3SJt1kwtYoAjFqAz2u33P0 5nSf+kjqlpg1kIBQEfReeJ6UNIc9LJPaX9SZgU/Gkwnv1o1WG3LJzXmk4bfkaovBcetBk7 Ytje7N9SraCVYeC2bRq95Dwy0N72M3o= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-417-v2GkaruzOXOClJt6aisPiQ-1; Tue, 31 Dec 2019 08:30:14 -0500 Received: by mail-wm1-f72.google.com with SMTP id z2so155383wmf.5 for ; Tue, 31 Dec 2019 05:30:14 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=IQA6QbO0xgm9RnulSZkphrjPpNK40K3cw0zp+GTYfZE=; b=qAaV7O9p08rDPDwSYwThHrY6KwSvb6ekEC1wj3TU8G85sav3bZrpSFQMKXsR85RFbs HG4SiFSY+pPY2R1zmLNAR3Lmo4R/GUBGbOKs/6shVFd5CjrdoJowDwH5zwJ65xeJNh4c 2qW+LDPOkmNu9324ss/2d17s3FvqvTwjsbrI8JtYsgC1HiYyNuLNyyCKm8jkVbArQ17h +xsfNU9pHNYUyC+3z1ctmRDkWVFY+MZ7pEyQqymAOQstLXyuszZMOMcRmuwOt/6HoGQN Uq8GWy+TRh7XfXpWYrnxnn8yp9Ylassro2tVMTP9m9NwxQJ+a78VFAMGePxDSJa0UZ7p 8AbA== X-Gm-Message-State: APjAAAXFiV4cxWDpsgxZuCb8lHIeokQf0+LoxqaMaTmfzTisQqF4GGLR 9P0nEBUmIUO/ggLHh9r9+7jta1Dkygkjd7oNyjUylVUZ8C+pHKRYbzOKm3RLWt4wrcAjDjON7yF tDHhak/G/xEIfXA== X-Received: by 2002:a1c:7406:: with SMTP id p6mr4315513wmc.82.1577799013087; Tue, 31 Dec 2019 05:30:13 -0800 (PST) X-Google-Smtp-Source: APXvYqw94lZL3oCBt7eN9eEWhoVFwZQv6NTKTvRSnVm+17NC1Krdev+99OnICsGUC01ywho4O+r/EQ== X-Received: by 2002:a1c:7406:: with SMTP id p6mr4315491wmc.82.1577799012793; Tue, 31 Dec 2019 05:30:12 -0800 (PST) Return-Path: Received: from [192.168.1.25] (abayonne-654-1-140-248.w86-222.abo.wanadoo.fr. [86.222.91.248]) by smtp.gmail.com with ESMTPSA id v188sm2649055wma.10.2019.12.31.05.30.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 31 Dec 2019 05:30:12 -0800 (PST) Subject: Re: [edk2-devel] [edk2-platforms][PATCH] Platform/RPi4: Fix SDHC interrupt numbers. To: devel@edk2.groups.io, pete@akeo.ie, jmcneill@invisible.ca, Samer El-Haj-Mahmoud , Ard Biesheuvel References: <39052ebe-f126-6c84-5d95-8c91297216bd@akeo.ie> From: =?UTF-8?B?UGhpbGlwcGUgTWF0aGlldS1EYXVkw6k=?= Message-ID: <53e1b682-4d9a-2ba2-6f17-89f44afc32a6@redhat.com> Date: Tue, 31 Dec 2019 14:30:10 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2 MIME-Version: 1.0 In-Reply-To: <39052ebe-f126-6c84-5d95-8c91297216bd@akeo.ie> X-MC-Unique: v2GkaruzOXOClJt6aisPiQ-1 X-Mimecast-Spam-Score: 0 Content-Language: en-US Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable Cc'ing Samer because he has access to the datasheet, and I wonder if=20 Linux is right. Samer, do you mind to confirm this fix? Thanks, Phil. On 12/31/19 11:39 AM, Pete Batard wrote: > Many thanks for fixing these. >=20 > Reviewed-by: Pete Batard >=20 > On 2019-12-30 15:07, Jared McNeill wrote: >> According to the bcm2711 devicetree, the Arasan SDHCI uses GIC SPI 126 >> and the Broadcom SDHost uses GIC SPI 120. >> >> Signed-off-by: Jared McNeill >> --- >> =C2=A0 Platform/RaspberryPi/RPi4/AcpiTables/Sdhc.asl | 4 ++-- >> =C2=A0 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/Platform/RaspberryPi/RPi4/AcpiTables/Sdhc.asl=20 >> b/Platform/RaspberryPi/RPi4/AcpiTables/Sdhc.asl >> index 57ee411a61..56d15c3927 100644 >> --- a/Platform/RaspberryPi/RPi4/AcpiTables/Sdhc.asl >> +++ b/Platform/RaspberryPi/RPi4/AcpiTables/Sdhc.asl >> @@ -33,7 +33,7 @@ Device (SDC1) >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 Name (RBUF, ResourceTemplate () >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 { >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 MEMORY32FIXED (ReadWrite, 0x= FE300000, 0x100,) >> -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 Interrupt (ResourceConsumer, Level, Act= iveHigh, Exclusive) {=20 >> 0x5E } >> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 Interrupt (ResourceConsumer, Level, Act= iveHigh, Exclusive) {=20 >> 0x9E } >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 }) >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 Return (RBUF) >> =C2=A0=C2=A0=C2=A0 } >> @@ -76,7 +76,7 @@ Device (SDC2) >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 Name (RBUF, ResourceTemplate () >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 { >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 MEMORY32FIXED (ReadWrite, 0x= FE202000, 0x100,) >> -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 Interrupt (ResourceConsumer, Level, Act= iveHigh, Exclusive) {=20 >> 0x58 } >> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 Interrupt (ResourceConsumer, Level, Act= iveHigh, Exclusive) {=20 >> 0x98 } >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 }) >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 Return (RBUF) >> =C2=A0=C2=A0=C2=A0 } >> >=20 >=20 >=20 >=20