From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124])
 by mx.groups.io with SMTP id smtpd.web10.19332.1611695240718360772
 for <devel@edk2.groups.io>;
 Tue, 26 Jan 2021 13:07:20 -0800
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=E2f2vD71;
 spf=pass (domain: redhat.com, ip: 63.128.21.124, mailfrom: lersek@redhat.com)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1611695239;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=nxlGbMbbY/2Rge1U0PJrDYQRVWcL/YuSjcrM0JgCvZo=;
	b=E2f2vD71YsEbbLa6yDlLZZJ/UfPHp3alnwa2j6dRAnfUExtpcLwqIhlqKq0Bj5TpqTGSYF
	2qfIefkBDnObXSgclauW7mpeAfavjHoSPaKyRaiWZ9Uy6ioVtVz7VHMFfBt7z0rmzA1W7z
	reMIRgFfTno+5vrRj+8yU9hAH0qSM+E=
Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com
 [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id
 us-mta-182-0Es9FjtEN6KDsJCejllklw-1; Tue, 26 Jan 2021 16:07:18 -0500
X-MC-Unique: 0Es9FjtEN6KDsJCejllklw-1
Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mimecast-mx01.redhat.com (Postfix) with ESMTPS id A79C6801AA3;
	Tue, 26 Jan 2021 21:07:16 +0000 (UTC)
Received: from lacos-laptop-7.usersys.redhat.com (ovpn-112-219.ams2.redhat.com [10.36.112.219])
	by smtp.corp.redhat.com (Postfix) with ESMTP id DE70C1F0;
	Tue, 26 Jan 2021 21:07:14 +0000 (UTC)
Subject: Re: [PATCH v5 1/9] OvmfPkg/CpuHotplugSmm: refactor hotplug logic
To: Ankur Arora <ankur.a.arora@oracle.com>, devel@edk2.groups.io
Cc: imammedo@redhat.com, boris.ostrovsky@oracle.com,
 Jordan Justen <jordan.l.justen@intel.com>,
 Ard Biesheuvel <ard.biesheuvel@arm.com>, Aaron Young <aaron.young@oracle.com>
References: <20210126064440.299596-1-ankur.a.arora@oracle.com>
 <20210126064440.299596-2-ankur.a.arora@oracle.com>
 <3f3fd01d-78a9-315c-85e3-b5788b8d6489@redhat.com>
 <4a1e8dd7-51e4-165c-64c1-d7d6fea6eafc@oracle.com>
From: "Laszlo Ersek" <lersek@redhat.com>
Message-ID: <53e8f8dc-99ef-9b13-c92f-e3d63ab39409@redhat.com>
Date: Tue, 26 Jan 2021 22:07:13 +0100
MIME-Version: 1.0
In-Reply-To: <4a1e8dd7-51e4-165c-64c1-d7d6fea6eafc@oracle.com>
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11
Authentication-Results: relay.mimecast.com;
	auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=lersek@redhat.com
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit

On 01/26/21 20:15, Ankur Arora wrote:
> On 2021-01-26 11:01 a.m., Laszlo Ersek wrote:

>> I'll continue the review later this week.
> 
> Acking the comments above.

Thank you!

> Meanwhile let me reprocess the series in light of the comments above.

I'm at such a point now, during the v5 review, that I think I can easily
re-sync.

In general, I don't mind the posting of a new version of a series
mid-review, *IF* we agree about it in advance.

If you prefer to post a v6, for addressing the comments I've made thus
far, I'm OK with that. If you'd like me to continue reviewing v5, I'm
also OK with that.

So it's up to you -- please state your decision, so that I know if I
should proceed with v5 (later this week), or wait for v6.

Thanks!
Laszlo