From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail05.groups.io (mail05.groups.io [45.79.224.7]) by spool.mail.gandi.net (Postfix) with ESMTPS id 16AF4740045 for ; Wed, 17 Jul 2024 14:26:01 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=nePfql/azcyZrqRr6cYOBAA3TGrVlFZpFtFb53hQF9g=; c=relaxed/simple; d=groups.io; h=Message-ID:Date:MIME-Version:User-Agent:Subject:To:CC:References:From:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20240206; t=1721226361; v=1; b=IMtoKl9qaxRL3WxGvZR6bfbK9lHtEHXI+AfCvT7y+8hAfZdwREohrFe0vIeTK9jjKz5Zg7R7 dbyHiLaeRTPIWJohFnekmnbvdS0GcQ/83VOlnBSS2PD/qFEAKniQpkRr2+M4Jyy0ZCZM7j+ZJlB veKdamc8eLnx9KY7uSnzoJZaMokXMKmyHuhYBzSMk+d+u2TrtgzZF2IbrBYzYkaNBcFkMG32qZg 5i+vOFjP5wyDEkTQEQNo7Dyuhz1txufxqLHpJedDXhz2F5ZZC8ysK+rETRQhxfyXPhYpf7HZXMh e/0WEJuqVmC2Q+yREeVo1fX5gic+ut6R5WNZGsKv443XQ== X-Received: by 127.0.0.2 with SMTP id LQHQYY7687511xGL4Wgyehy9; Wed, 17 Jul 2024 07:26:00 -0700 X-Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) by mx.groups.io with SMTP id smtpd.web11.16430.1721226354818446040 for ; Wed, 17 Jul 2024 07:25:54 -0700 X-Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 46H6t68U004379; Wed, 17 Jul 2024 14:24:52 GMT X-Received: from nasanppmta05.qualcomm.com (i-global254.qualcomm.com [199.106.103.254]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 40dwfpamw0-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 17 Jul 2024 14:24:52 +0000 (GMT) X-Received: from nasanex01c.na.qualcomm.com (nasanex01c.na.qualcomm.com [10.45.79.139]) by NASANPPMTA05.qualcomm.com (8.17.1.19/8.17.1.19) with ESMTPS id 46HEOpXW009863 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 17 Jul 2024 14:24:51 GMT X-Received: from [10.111.135.62] (10.80.80.8) by nasanex01c.na.qualcomm.com (10.45.79.139) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.9; Wed, 17 Jul 2024 07:24:49 -0700 Message-ID: <53f09dca-d305-45c2-8714-9e5ef2390512@quicinc.com> Date: Wed, 17 Jul 2024 15:24:47 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [edk2-devel] [edk2-libc Patch 1/1] edk2-libc: add .gitattributes to ensure right line endings in .sh .bat To: , , "Kinney, Michael D" CC: Rebecca Cran References: <20240712142844.1317-1-n.jayaprakash@intel.com> <20240712142844.1317-2-n.jayaprakash@intel.com> From: "Leif Lindholm" In-Reply-To: X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nasanex01c.na.qualcomm.com (10.45.79.139) X-QCInternal: smtphost X-Proofpoint-ORIG-GUID: i7lFoSXUHBAQCrpCN8MgVV72N_r_Nuib X-Proofpoint-GUID: i7lFoSXUHBAQCrpCN8MgVV72N_r_Nuib Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Wed, 17 Jul 2024 07:25:54 -0700 Resent-From: quic_llindhol@quicinc.com Reply-To: devel@edk2.groups.io,quic_llindhol@quicinc.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: N8G5ZRdRO2su6MDYJTDy7olMx7686176AA= Content-Language: en-GB Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=IMtoKl9q; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=quicinc.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.224.7 as permitted sender) smtp.mailfrom=bounce@groups.io Hi, The address I am replying from is the email address I use for tianocore=20 work. Messages sent elsewhere are going to end up misfiled and likely lost. On 2024-07-17 06:55, Jayaprakash, N wrote: > Hi Lefi, >=20 > Do you have any recommendations on this? >=20 > Regards, > JP >=20 > -----Original Message----- > From: Kinney, Michael D > Sent: Friday, July 12, 2024 9:29 PM > To: Jayaprakash, N ; devel@edk2.groups.io; Leif = Lindholm > Cc: Rebecca Cran ; Kinney, Michael D > Subject: RE: [edk2-libc Patch 1/1] edk2-libc: add .gitattributes to ensur= e right line endings in .sh .bat >=20 > + Leif >=20 > .gitattributes is not used in other TianoCore repos. Technically sort of correct, but see below. > This feature changes the line endings locally when checked out. >=20 > Instead, the edk2 repo uses a CI check like PatchCheck.py to make sure fi= les with specific extensions have the correct line endings when they are ch= ecked in and files are checked out unmodified. >=20 > I know Leif has been evaluating some line ending changes to TianoCore Rep= os. Don't know if this direction is in alignment with those ideas or not. >=20 > Mike >=20 >> -----Original Message----- >> From: Jayaprakash, N >> Sent: Friday, July 12, 2024 7:27 AM >> To: devel@edk2.groups.io >> Cc: Jayaprakash, N ; Rebecca Cran >> ; Kinney, Michael D >> Subject: [edk2-libc Patch 1/1] edk2-libc: add .gitattributes to ensure >> right line endings in .sh .bat >> >> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D4809 >> >> This commit adds .gitattributes file with the right settings to >> preserve the correct line endings for .sh and .bat files as per the >> Linxu and Windows line ending conventions respectively. >> >> Cc: Rebecca Cran >> Cc: Michael D Kinney >> Cc: Jayaprakash N >> Signed-off-by: Jayaprakash N >> --- >> .gitattributes | 2 ++ >> 1 file changed, 2 insertions(+) >> create mode 100644 .gitattributes >> >> diff --git a/.gitattributes b/.gitattributes new file mode 100644 >> index 0000000..3fd9ec8 >> --- /dev/null >> +++ b/.gitattributes >> @@ -0,0 +1,2 @@ >> +*.bat text eol=3Dcrlf >> +*.sh text eol=3Dlf >> \ No newline at end of file ^ This is not a good look for any submission, but especially not one=20 dealing with line endings. Please manually look at patches before=20 sending them out. Now, as for the suggestion: this isn't wrong, but can you explain what=20 problem it is solving? I had a look in edk2-libc and all the .sh files have LF line endings and=20 all the .bat files have CRLF line endings. Now, if we *did* want to do this, I would strongly prefer a patch to=20 edk2/BaseTools/Conf/gitattributes, which is applied in any repo=20 SetupGit.py has been executed in. But ultimately I want to convert the repos completely to LF line endings=20 except for where special cases exist (which *should* be described in=20 [.]gitattributes) and then move to enable core.autocrlf. / Leif >> -- >> 2.45.1.windows.1 >=20 >=20 >=20 >=20 >=20 >=20 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#119953): https://edk2.groups.io/g/devel/message/119953 Mute This Topic: https://groups.io/mt/107182920/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-