From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=209.132.183.28; helo=mx1.redhat.com; envelope-from=lersek@redhat.com; receiver=edk2-devel@lists.01.org Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 10F822118A5BC for ; Fri, 9 Nov 2018 00:01:45 -0800 (PST) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 745F03DBD4; Fri, 9 Nov 2018 08:01:44 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-120-96.rdu2.redhat.com [10.10.120.96]) by smtp.corp.redhat.com (Postfix) with ESMTP id A8EBD601A6; Fri, 9 Nov 2018 08:01:42 +0000 (UTC) To: "Bi, Dandan" , "Gao, Liming" , "edk2-devel@lists.01.org" , "afish@apple.com" , Leif Lindholm Cc: "Ni, Ruiyu" , "Kinney, Michael D" References: <20181108134935.51312-1-dandan.bi@intel.com> <4A89E2EF3DFEDB4C8BFDE51014F606A14E367885@SHSMSX104.ccr.corp.intel.com> <3C0D5C461C9E904E8F62152F6274C0BB40183185@shsmsx102.ccr.corp.intel.com> From: Laszlo Ersek Message-ID: <542478ca-5f80-a8ae-cc6e-0ca1c68f2dd9@redhat.com> Date: Fri, 9 Nov 2018 09:01:41 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <3C0D5C461C9E904E8F62152F6274C0BB40183185@shsmsx102.ccr.corp.intel.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.30]); Fri, 09 Nov 2018 08:01:44 +0000 (UTC) Subject: Re: [patch] MdePkg: Fix incorrect check for DisplayOnly text format in AcpiEx X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 09 Nov 2018 08:01:45 -0000 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 11/09/18 04:34, Bi, Dandan wrote: > Hi Stewards and package maintainers: > > Since this is a clear bug. And the risk for this release is small. > So I plan to push this patch before edk2-stable201811 tag is created. I agree, this is a bugfix, not a feature patch. Thanks, Laszlo > If you have any concern, please raise here. > > > Thanks, > Dandan > >> -----Original Message----- >> From: Gao, Liming >> Sent: Thursday, November 8, 2018 9:56 PM >> To: Bi, Dandan ; edk2-devel@lists.01.org >> Cc: Ni, Ruiyu ; Kinney, Michael D >> >> Subject: RE: [patch] MdePkg: Fix incorrect check for DisplayOnly text format >> in AcpiEx >> >> Reviewed-by: Liming Gao >> >>> -----Original Message----- >>> From: Bi, Dandan >>> Sent: Thursday, November 8, 2018 9:50 PM >>> To: edk2-devel@lists.01.org >>> Cc: Ni, Ruiyu ; Kinney, Michael D >>> ; Gao, Liming >>> Subject: [patch] MdePkg: Fix incorrect check for DisplayOnly text >>> format in AcpiEx >>> >>> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1312 >>> >>> Text format for AcpiEx device path in UEFI Spec: >>> AcpiEx(HID,CID,UID,HIDSTR,CIDSTR,UIDSTR) >>> AcpiEx(HID|HIDSTR,(CID|CIDSTR,UID|UIDSTR))(Display Only) >>> >>> When convert device path to text for ACPI device path, current code >>> check AllowShortcuts parameter to convert the device path to >>> DisplayOnly text format(shorter text >>> representation) by mistake. >>> It should check DisplayOnly parameter. >>> >>> This commit is to fix this issue. >>> >>> Cc: Ruiyu Ni >>> Cc: Michael D Kinney >>> Cc: Liming Gao >>> Contributed-under: TianoCore Contribution Agreement 1.1 >>> Signed-off-by: Dandan Bi >>> --- >>> MdePkg/Library/UefiDevicePathLib/DevicePathToText.c | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/MdePkg/Library/UefiDevicePathLib/DevicePathToText.c >>> b/MdePkg/Library/UefiDevicePathLib/DevicePathToText.c >>> index cdcdb3623a..97d279eeb2 100644 >>> --- a/MdePkg/Library/UefiDevicePathLib/DevicePathToText.c >>> +++ b/MdePkg/Library/UefiDevicePathLib/DevicePathToText.c >>> @@ -495,11 +495,11 @@ DevPathToTextAcpiEx ( >>> CIDText, >>> UIDStr >>> ); >>> } >>> } else { >>> - if (AllowShortcuts) { >>> + if (DisplayOnly) { >>> // >>> // display only >>> // >>> if (AcpiEx->HID == 0) { >>> UefiDevicePathLibCatPrint (Str, L"AcpiEx(%a,", HIDStr); >>> -- >>> 2.18.0.windows.1 >