public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
* [patch] MdePkg: Fix incorrect check for DisplayOnly text format in AcpiEx
@ 2018-11-08 13:49 Dandan Bi
  2018-11-08 13:56 ` Gao, Liming
  0 siblings, 1 reply; 4+ messages in thread
From: Dandan Bi @ 2018-11-08 13:49 UTC (permalink / raw)
  To: edk2-devel; +Cc: Ruiyu Ni, Michael D Kinney, Liming Gao

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1312

Text format for AcpiEx device path in UEFI Spec:
AcpiEx(HID,CID,UID,HIDSTR,CIDSTR,UIDSTR)
AcpiEx(HID|HIDSTR,(CID|CIDSTR,UID|UIDSTR))(Display Only)

When convert device path to text for ACPI device path,
current code check AllowShortcuts parameter to convert
the device path to DisplayOnly text format(shorter text
representation) by mistake.
It should check DisplayOnly parameter.

This commit is to fix this issue.

Cc: Ruiyu Ni <ruiyu.ni@intel.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Dandan Bi <dandan.bi@intel.com>
---
 MdePkg/Library/UefiDevicePathLib/DevicePathToText.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/MdePkg/Library/UefiDevicePathLib/DevicePathToText.c b/MdePkg/Library/UefiDevicePathLib/DevicePathToText.c
index cdcdb3623a..97d279eeb2 100644
--- a/MdePkg/Library/UefiDevicePathLib/DevicePathToText.c
+++ b/MdePkg/Library/UefiDevicePathLib/DevicePathToText.c
@@ -495,11 +495,11 @@ DevPathToTextAcpiEx (
         CIDText,
         UIDStr
        );
     }
   } else {
-    if (AllowShortcuts) {
+    if (DisplayOnly) {
       //
       // display only
       //
       if (AcpiEx->HID == 0) {
         UefiDevicePathLibCatPrint (Str, L"AcpiEx(%a,", HIDStr);
-- 
2.18.0.windows.1



^ permalink raw reply related	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2018-11-09  8:01 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-11-08 13:49 [patch] MdePkg: Fix incorrect check for DisplayOnly text format in AcpiEx Dandan Bi
2018-11-08 13:56 ` Gao, Liming
2018-11-09  3:34   ` Bi, Dandan
2018-11-09  8:01     ` Laszlo Ersek

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox