From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) (using TLSv1 with cipher CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 535081A1E74 for ; Thu, 1 Sep 2016 17:49:31 -0700 (PDT) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga104.fm.intel.com with ESMTP; 01 Sep 2016 17:49:31 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.30,269,1470726000"; d="scan'208";a="1034476389" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by fmsmga001.fm.intel.com with ESMTP; 01 Sep 2016 17:49:30 -0700 Received: from fmsmsx156.amr.corp.intel.com (10.18.116.74) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.248.2; Thu, 1 Sep 2016 17:49:30 -0700 Received: from shsmsx104.ccr.corp.intel.com (10.239.4.70) by fmsmsx156.amr.corp.intel.com (10.18.116.74) with Microsoft SMTP Server (TLS) id 14.3.248.2; Thu, 1 Sep 2016 17:49:30 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.109]) by SHSMSX104.ccr.corp.intel.com ([169.254.5.174]) with mapi id 14.03.0248.002; Fri, 2 Sep 2016 08:49:28 +0800 From: "Fan, Jeff" To: Laszlo Ersek , "Zeng, Star" , "edk2-devel@ml01.01.org" CC: "Kinney, Michael D" , "Justen, Jordan L" , "Tian, Feng" Thread-Topic: [edk2] [Patch v5 48/48] UefiCpuPkg/PiSmmCpuDxeSmm: Add gEfiVariableArchProtocolGuid dependency Thread-Index: AQHR7Jy4Gz8Pd1vRVUq8pvPSUJUViKBPEBCAgACPpPD//4MCAIAABX8AgAADOQCABxy8AIAAudsAgAANcACAACBagIAAbTsAgAAePICAAbZq0IAHuI2AgALTdgCAAJSdgIAA+5hg Date: Fri, 2 Sep 2016 00:49:27 +0000 Message-ID: <542CF652F8836A4AB8DBFAAD40ED192A4A1D9F28@shsmsx102.ccr.corp.intel.com> References: <1470128388-17960-1-git-send-email-jeff.fan@intel.com> <1470128388-17960-49-git-send-email-jeff.fan@intel.com> <4f61b2b4-eeb4-8435-412f-20848347c88e@redhat.com> <542CF652F8836A4AB8DBFAAD40ED192A143D9CFD@shsmsx102.ccr.corp.intel.com> <795dd4fe-cd16-c0f1-7f04-f78601e2c7a8@redhat.com> <82c6b5c9-dcab-f3c1-5ffe-20fb27ddb1af@intel.com> <6cd44902-8c07-8f76-1204-d79c85559ae5@intel.com> <7d39ce29-88ce-c5f2-af61-7fd964acb5c0@intel.com> <801f810c-4cd7-d657-f536-a8471a37802c@redhat.com> <8c9e77d3-14d2-4a92-2407-eb80cd255bb4@intel.com> <542CF652F8836A4AB8DBFAAD40ED192A143DEF4E@shsmsx102.ccr.corp.intel.com> <8373cabb-8bf5-bb9e-2377-e7b045b54c59@redhat.com> <542CF652F8836A4AB8DBFAAD40ED192A4A1D8F62@shsmsx102.ccr.corp.intel.com> In-Reply-To: Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMDdhZDNlNTQtZmI5Yy00Y2NmLTlhMjEtMWM3ZTEyNTZkYzZjIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6Ikd6RHFEWHBOS0RXZFp0S2FVKzBoMFJ3Z1YrUWtodU8yZGd3UEozSEh3YWc9In0= x-ctpclassification: CTP_IC x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [Patch v5 48/48] UefiCpuPkg/PiSmmCpuDxeSmm: Add gEfiVariableArchProtocolGuid dependency X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 02 Sep 2016 00:49:31 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Laszlo, There is no changing request on Ovmf and UefiCpuPkg SmmCpuFeaturesLib insta= nces. Jeff -----Original Message----- From: Laszlo Ersek [mailto:lersek@redhat.com]=20 Sent: Friday, September 02, 2016 1:47 AM To: Fan, Jeff; Zeng, Star; edk2-devel@ml01.01.org Cc: Kinney, Michael D; Justen, Jordan L; Tian, Feng Subject: Re: [edk2] [Patch v5 48/48] UefiCpuPkg/PiSmmCpuDxeSmm: Add gEfiVar= iableArchProtocolGuid dependency On 09/01/16 03:11, Fan, Jeff wrote: > Laszlo, >=20 > UefiCpuPkg/PiSmmCpuDxeSmm driver and > UefiCpuPkg/Library/SmmCpuFeatuersLib have no such requirement on=20 > gEfiVariableArchProtocolGuid to access HII type PCD. In fact, our=20 > platform SmmCpuFeaturesLib instance (linked by PiSmmCpuDxeSmm) is=20 > trying to read HII type PCD. >=20 > The correct solution is to add gEfiVariableArchProtocolGuid dependency=20 > in platform SmmCpuFeaturesLib instance and this dependency will be=20 > inherited by PiSmmCpuDxeSmm driver. OVMF also has its own SmmCpuFeaturesLib instance, under "OvmfPkg/Library/Sm= mCpuFeaturesLib". That library instance has no particular depex, similarly = to UefiCpuPkg's instance. If you add the depex to your platform's SmmCpuFeaturesLib instance, that sh= ould keep both UefiCpuPkg's and OvmfPkg's instance unchanged. That sounds g= reat to me, thank you! Laszlo