From: "Fan, Jeff" <jeff.fan@intel.com>
To: "Gao, Liming" <liming.gao@intel.com>,
Laszlo Ersek <lersek@redhat.com>,
"edk2-devel@ml01.01.org" <edk2-devel@ml01.01.org>
Subject: Re: [Patch] MdePkg BaseSynchronizationLib: Update InterlockedCompareExchange64.nasm
Date: Tue, 18 Oct 2016 01:47:44 +0000 [thread overview]
Message-ID: <542CF652F8836A4AB8DBFAAD40ED192A4A2AD5A0@shsmsx102.ccr.corp.intel.com> (raw)
In-Reply-To: <4A89E2EF3DFEDB4C8BFDE51014F606A14B495913@shsmsx102.ccr.corp.intel.com>
Reviewed-by: Jeff Fan <jeff.fan@intel.com>
-----Original Message-----
From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Gao, Liming
Sent: Tuesday, October 18, 2016 9:36 AM
To: Laszlo Ersek; edk2-devel@ml01.01.org
Subject: Re: [edk2] [Patch] MdePkg BaseSynchronizationLib: Update InterlockedCompareExchange64.nasm
Thanks! I will use this subject.
> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of
> Laszlo Ersek
> Sent: Friday, October 14, 2016 8:22 PM
> To: Gao, Liming <liming.gao@intel.com>; edk2-devel@ml01.01.org
> Subject: Re: [edk2] [Patch] MdePkg BaseSynchronizationLib: Update
> InterlockedCompareExchange64.nasm
>
> On 10/14/16 08:47, Liming Gao wrote:
> > Remove extra qword in nasm code to make it pass build.
> > This file is only built in INTEL ICC compiler. So, there is missing
> > build check for it.
> >
> > Contributed-under: TianoCore Contribution Agreement 1.0
> > Signed-off-by: Liming Gao <liming.gao@intel.com>
> > ---
> > .../BaseSynchronizationLib/Ia32/InterlockedCompareExchange64.nasm
> | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git
> a/MdePkg/Library/BaseSynchronizationLib/Ia32/InterlockedCompareExchan
> ge64.nasm
> b/MdePkg/Library/BaseSynchronizationLib/Ia32/InterlockedCompareExchan
> ge64.nasm
> > index ee63ff7..206de40 100644
> > ---
> a/MdePkg/Library/BaseSynchronizationLib/Ia32/InterlockedCompareExchan
> ge64.nasm
> > +++
> b/MdePkg/Library/BaseSynchronizationLib/Ia32/InterlockedCompareExchan
> ge64.nasm
> > @@ -41,7 +41,7 @@ ASM_PFX(InternalSyncCompareExchange64):
> > mov edx, [esp + 20]
> > mov ebx, [esp + 24]
> > mov ecx, [esp + 28]
> > - lock cmpxchg8b qword [esi]
> > + lock cmpxchg8b [esi]
> > pop ebx
> > pop esi
> > ret
> >
>
> Suggested subject line:
>
> MdePkg BaseSynchronizationLib InterlockedCompareExchange64: fix ICC
> build
>
> (73 characters)
>
> Thanks,
> Laszlo
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
prev parent reply other threads:[~2016-10-18 1:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-14 6:47 [Patch] MdePkg BaseSynchronizationLib: Update InterlockedCompareExchange64.nasm Liming Gao
2016-10-14 12:22 ` Laszlo Ersek
2016-10-18 1:36 ` Gao, Liming
2016-10-18 1:47 ` Fan, Jeff [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=542CF652F8836A4AB8DBFAAD40ED192A4A2AD5A0@shsmsx102.ccr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox