From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) (using TLSv1 with cipher CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 0A30A1A1E20 for ; Mon, 17 Oct 2016 18:47:48 -0700 (PDT) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga102.fm.intel.com with ESMTP; 17 Oct 2016 18:47:47 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.31,359,1473145200"; d="scan'208";a="1055287741" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by fmsmga001.fm.intel.com with ESMTP; 17 Oct 2016 18:47:47 -0700 Received: from shsmsx104.ccr.corp.intel.com (10.239.4.70) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.248.2; Mon, 17 Oct 2016 18:47:47 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.206]) by SHSMSX104.ccr.corp.intel.com ([169.254.5.209]) with mapi id 14.03.0248.002; Tue, 18 Oct 2016 09:47:45 +0800 From: "Fan, Jeff" To: "Gao, Liming" , Laszlo Ersek , "edk2-devel@ml01.01.org" Thread-Topic: [edk2] [Patch] MdePkg BaseSynchronizationLib: Update InterlockedCompareExchange64.nasm Thread-Index: AQHSJebv0UP7tXJDbkCZ+jlbRt3lB6CnWUqAgAWUxYCAAIkyEA== Date: Tue, 18 Oct 2016 01:47:44 +0000 Message-ID: <542CF652F8836A4AB8DBFAAD40ED192A4A2AD5A0@shsmsx102.ccr.corp.intel.com> References: <1476427653-13184-1-git-send-email-liming.gao@intel.com> <8168a43b-1b66-6697-eeb5-41b431af15ee@redhat.com> <4A89E2EF3DFEDB4C8BFDE51014F606A14B495913@shsmsx102.ccr.corp.intel.com> In-Reply-To: <4A89E2EF3DFEDB4C8BFDE51014F606A14B495913@shsmsx102.ccr.corp.intel.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMDc1YTFmNDYtYmE3Yy00MWEwLWI1YWEtN2UxNWU0ZTBiOWIxIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6ImZYaHFrcVBiUGZibHE0dFRhOEhkTW9vR1B2ejNEYXRNbWl2Q1dIZDJiVzQ9In0= x-ctpclassification: CTP_IC x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [Patch] MdePkg BaseSynchronizationLib: Update InterlockedCompareExchange64.nasm X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 Oct 2016 01:47:48 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Jeff Fan -----Original Message----- From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Gao,= Liming Sent: Tuesday, October 18, 2016 9:36 AM To: Laszlo Ersek; edk2-devel@ml01.01.org Subject: Re: [edk2] [Patch] MdePkg BaseSynchronizationLib: Update Interlock= edCompareExchange64.nasm Thanks! I will use this subject.=20 > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of=20 > Laszlo Ersek > Sent: Friday, October 14, 2016 8:22 PM > To: Gao, Liming ; edk2-devel@ml01.01.org > Subject: Re: [edk2] [Patch] MdePkg BaseSynchronizationLib: Update=20 > InterlockedCompareExchange64.nasm >=20 > On 10/14/16 08:47, Liming Gao wrote: > > Remove extra qword in nasm code to make it pass build. > > This file is only built in INTEL ICC compiler. So, there is missing=20 > > build check for it. > > > > Contributed-under: TianoCore Contribution Agreement 1.0 > > Signed-off-by: Liming Gao > > --- > > .../BaseSynchronizationLib/Ia32/InterlockedCompareExchange64.nasm > | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git > a/MdePkg/Library/BaseSynchronizationLib/Ia32/InterlockedCompareExchan > ge64.nasm > b/MdePkg/Library/BaseSynchronizationLib/Ia32/InterlockedCompareExchan > ge64.nasm > > index ee63ff7..206de40 100644 > > --- > a/MdePkg/Library/BaseSynchronizationLib/Ia32/InterlockedCompareExchan > ge64.nasm > > +++ > b/MdePkg/Library/BaseSynchronizationLib/Ia32/InterlockedCompareExchan > ge64.nasm > > @@ -41,7 +41,7 @@ ASM_PFX(InternalSyncCompareExchange64): > > mov edx, [esp + 20] > > mov ebx, [esp + 24] > > mov ecx, [esp + 28] > > - lock cmpxchg8b qword [esi] > > + lock cmpxchg8b [esi] > > pop ebx > > pop esi > > ret > > >=20 > Suggested subject line: >=20 > MdePkg BaseSynchronizationLib InterlockedCompareExchange64: fix ICC=20 > build >=20 > (73 characters) >=20 > Thanks, > Laszlo > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel