From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) (using TLSv1 with cipher CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 3EA5E1A1E6B for ; Wed, 19 Oct 2016 19:46:04 -0700 (PDT) Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga101.jf.intel.com with ESMTP; 19 Oct 2016 19:46:03 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.31,516,1473145200"; d="scan'208";a="181702334" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by fmsmga004.fm.intel.com with ESMTP; 19 Oct 2016 19:46:03 -0700 Received: from fmsmsx157.amr.corp.intel.com (10.18.116.73) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.248.2; Wed, 19 Oct 2016 19:46:03 -0700 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by FMSMSX157.amr.corp.intel.com (10.18.116.73) with Microsoft SMTP Server (TLS) id 14.3.248.2; Wed, 19 Oct 2016 19:46:02 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.206]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.96]) with mapi id 14.03.0248.002; Thu, 20 Oct 2016 10:46:00 +0800 From: "Fan, Jeff" To: Gary Lin CC: "edk2-devel@lists.01.org" Thread-Topic: [edk2] [PATCH 32/33] UefiCpuPkg: Fix typos in comments Thread-Index: AQHSKdcCMq1yImr1jUKhAlIh8iE21qCwlf0g//99/wCAAJA/cA== Date: Thu, 20 Oct 2016 02:45:59 +0000 Message-ID: <542CF652F8836A4AB8DBFAAD40ED192A4A2B03E6@shsmsx102.ccr.corp.intel.com> References: <20161019070138.16424-1-glin@suse.com> <20161019070138.16424-33-glin@suse.com> <542CF652F8836A4AB8DBFAAD40ED192A4A2B0113@shsmsx102.ccr.corp.intel.com> <20161020020846.xwaap72vfxk5hwnb@GaryWorkstation> In-Reply-To: <20161020020846.xwaap72vfxk5hwnb@GaryWorkstation> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYmRkNzNjOTQtMjQ3MS00MTI0LWFhY2QtNWM3MDhkNWVjMWU0IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6InhHU3I1Rm5Bak4xRENFblRWZkhwRUxINHFnRnM1RzVVV3ZmSExzYzNtd2s9In0= x-ctpclassification: CTP_IC x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH 32/33] UefiCpuPkg: Fix typos in comments X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 20 Oct 2016 02:46:04 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Just v2 for this single patch is fine for me. I will help to commit. Thanks! Jeff -----Original Message----- From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Gary= Lin Sent: Thursday, October 20, 2016 10:09 AM To: Fan, Jeff Cc: edk2-devel@lists.01.org Subject: Re: [edk2] [PATCH 32/33] UefiCpuPkg: Fix typos in comments On Thu, Oct 20, 2016 at 01:58:51AM +0000, Fan, Jeff wrote: > Reviewed-by: Jeff Fan >=20 > Could you please help to fix typo *ruturn* when you commit the patch. > - @return The ruturn value of this paramter indica= tes the number of > + @return The ruturn value of this parameter indic= ates the number of >=20 I don't have the write access to the edk2 git. Should I submit a v2 to fix = this one? Thanks, Gary Lin > Thanks! >=20 > -----Original Message----- > From: Gary Lin [mailto:glin@suse.com] > Sent: Wednesday, October 19, 2016 3:02 PM > To: edk2-devel@lists.01.org > Cc: Fan, Jeff > Subject: [PATCH 32/33] UefiCpuPkg: Fix typos in comments >=20 > - excute -> execute > - Retrive -> Retrieve > - possilbe -> possible > - CONTINOUS -> CONTINUOUS > - storgage -> storage > - allcated -> allocated > - triggerred -> triggered > - paramter -> parameter > - perodically -> periodically > - retore -> restore >=20 > Cc: Jeff Fan > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Gary Lin > --- > UefiCpuPkg/Include/Library/MtrrLib.h | 2 += - > UefiCpuPkg/Library/CpuExceptionHandlerLib/PeiDxeSmmCpuException.c | 2 += - > UefiCpuPkg/Library/MpInitLib/DxeMpLib.c | 2 += - > UefiCpuPkg/Library/MtrrLib/MtrrLib.c | 2 += - > UefiCpuPkg/Universal/Acpi/S3Resume2Pei/S3Resume.c | 10 += ++++----- > 5 files changed, 9 insertions(+), 9 deletions(-) >=20 > diff --git a/UefiCpuPkg/Include/Library/MtrrLib.h=20 > b/UefiCpuPkg/Include/Library/MtrrLib.h > index 36cd2cd..5d62adb 100644 > --- a/UefiCpuPkg/Include/Library/MtrrLib.h > +++ b/UefiCpuPkg/Include/Library/MtrrLib.h > @@ -306,7 +306,7 @@ MtrrSetAllMtrrs ( > MtrrValidBitsMask & 0xfffffffffffff0= 00ULL > @param[out] VariableMtrr The array to shadow variable MTRRs c= ontent > =20 > - @return The ruturn value of this paramter indica= tes the number of > + @return The ruturn value of this parameter indic= ates the number of > MTRRs which has been used. > **/ > UINT32 > diff --git=20 > a/UefiCpuPkg/Library/CpuExceptionHandlerLib/PeiDxeSmmCpuException.c=20 > b/UefiCpuPkg/Library/CpuExceptionHandlerLib/PeiDxeSmmCpuException.c > index 02d5622..e55709c 100644 > ---=20 > a/UefiCpuPkg/Library/CpuExceptionHandlerLib/PeiDxeSmmCpuException.c > +++ b/UefiCpuPkg/Library/CpuExceptionHandlerLib/PeiDxeSmmCpuException. > +++ c > @@ -65,7 +65,7 @@ CommonExceptionHandlerWorker ( > // > if (ReservedVectors[ExceptionType].ApicId =3D=3D GetApicId ()) { > // > - // Old IDT handler has been executed, then retore CPU exception = content to > + // Old IDT handler has been executed, then restore CPU=20 > + exception content to > // run new exception handler. > // > ArchRestoreExceptionContext (ExceptionType, SystemContext);=20 > diff --git a/UefiCpuPkg/Library/MpInitLib/DxeMpLib.c=20 > b/UefiCpuPkg/Library/MpInitLib/DxeMpLib.c > index 50b5b27..b399f1c 100644 > --- a/UefiCpuPkg/Library/MpInitLib/DxeMpLib.c > +++ b/UefiCpuPkg/Library/MpInitLib/DxeMpLib.c > @@ -172,7 +172,7 @@ CheckAndUpdateApsStatus ( > /** > Checks APs' status periodically. > =20 > - This function is triggerred by timer perodically to check the > + This function is triggered by timer periodically to check the > state of APs for StartupAllAPs() and StartupThisAP() executed > in non-blocking mode. > =20 > diff --git a/UefiCpuPkg/Library/MtrrLib/MtrrLib.c=20 > b/UefiCpuPkg/Library/MtrrLib/MtrrLib.c > index 5aef772..7783b63 100644 > --- a/UefiCpuPkg/Library/MtrrLib/MtrrLib.c > +++ b/UefiCpuPkg/Library/MtrrLib/MtrrLib.c > @@ -606,7 +606,7 @@ MtrrGetMemoryAttributeInVariableMtrrWorker ( > @param[in] MtrrValidAddressMask The valid address mask for MTRR > @param[out] VariableMtrr The array to shadow variable MTRRs = content > =20 > - @return The return value of this paramter indica= tes the > + @return The return value of this parameter indic= ates the > number of MTRRs which has been used. > =20 > **/ > diff --git a/UefiCpuPkg/Universal/Acpi/S3Resume2Pei/S3Resume.c=20 > b/UefiCpuPkg/Universal/Acpi/S3Resume2Pei/S3Resume.c > index 0ccf3a4..f907b30 100644 > --- a/UefiCpuPkg/Universal/Acpi/S3Resume2Pei/S3Resume.c > +++ b/UefiCpuPkg/Universal/Acpi/S3Resume2Pei/S3Resume.c > @@ -1,7 +1,7 @@ > /** @file > This module produces the EFI_PEI_S3_RESUME2_PPI. > This module works with StandAloneBootScriptExecutor to S3 resume to OS= . > - This module will excute the boot script saved during last boot and=20 > after that, > + This module will execute the boot script saved during last boot and=20 > + after that, > control is passed to OS waking up handler. > =20 > Copyright (c) 2006 - 2016, Intel Corporation. All rights reserved.
= @@ -294,7 +294,7 @@ WriteToOsS3PerformanceData ( > UINT64 Freq; > =20 > // > - // Retrive time stamp count as early as possilbe > + // Retrieve time stamp count as early as possible > // > Ticker =3D GetPerformanceCounter (); > =20 > @@ -612,12 +612,12 @@ RestoreS3PageTables ( > // NOTE: We have to ASSUME the page table generation format, because= we do not know whole page table information. > // The whole page table is too large to be saved in SMRAM. > // > - // The assumption is : whole page table is allocated in CONTINOUS me= mory and CR3 points to TOP page. > + // The assumption is : whole page table is allocated in CONTINUOUS m= emory and CR3 points to TOP page. > // > DEBUG ((EFI_D_ERROR, "S3NvsPageTableAddress - %x (%x)\n",=20 > (UINTN)S3NvsPageTableAddress, (UINTN)Build4GPageTableOnly)); > =20 > // > - // By architecture only one PageMapLevel4 exists - so lets allocate = storgage for it. > + // By architecture only one PageMapLevel4 exists - so lets allocate = storage for it. > // > PageMap =3D (PAGE_MAP_AND_DIRECTORY_POINTER *)S3NvsPageTableAddress; > S3NvsPageTableAddress +=3D SIZE_4KB; @@ -819,7 +819,7 @@=20 > S3ResumeExecuteBootScript ( > // > IdtDescriptor =3D (IA32_DESCRIPTOR *) (UINTN) (AcpiS3Context->IdtrPr= ofile); > // > - // Make sure the newly allcated IDT align with 16-bytes > + // Make sure the newly allocated IDT align with 16-bytes > //=20 > IdtBuffer =3D AllocatePages (EFI_SIZE_TO_PAGES((IdtDescriptor->Limit= + 1) + 16)); > if (IdtBuffer =3D=3D NULL) { > -- > 2.10.1 >=20 > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel >=20 _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel