Re: [PATCH 0/2] Place APs to suitable state on Legacy OS boot

["Fan, Jeff" <jeff.fan@intel.com>]

Laszlo,

Got you. It's a good suggestion!

Jeff

-----Original Message-----
From: Laszlo Ersek [mailto:lersek@redhat.com] 
Sent: Friday, November 11, 2016 8:33 PM
To: Fan, Jeff
Cc: edk2-devel@ml01.01.org; Tian, Feng; Yao, Jiewen; Kinney, Michael D; Paolo Bonzini
Subject: Re: [edk2] [PATCH 0/2] Place APs to suitable state on Legacy OS boot

On 11/11/16 12:57, Jeff Fan wrote:
> Currently, DxeMpLib only places APs into specified c-state in Exit 
> Boot Service callback function for UEFI OS boot. We need to put APs 
> into specified c-state for legacy OS boot also.
> 
> https://bugzilla.tianocore.org/show_bug.cgi?id=210
> 
> Jeff Fan (2):
>   UefiCpuPkg/DxeMpLib: Rename MpInitExitBootServicesCallback()
>   UefiCpuPkg/DxeMpLib: Place APs to suitable state on Legacy OS boot
> 
>  UefiCpuPkg/Library/MpInitLib/DxeMpInitLib.inf |  1 +
>  UefiCpuPkg/Library/MpInitLib/DxeMpLib.c       | 18 +++++++++++++++---
>  2 files changed, 16 insertions(+), 3 deletions(-)
> 

>From a cursory look, it looks good to me, but I think I'll leave the official review on this to Mike et al :)

Also, a meta-hint: when you post a cover letter for a patch series, it is best to collect all the CC's from the patches, sort them uniquely, and then add the resulting CC list to the cover letter as well. This way every CC'd person will receive the high level description for the entire set.

https://github.com/tianocore/tianocore.github.io/wiki/Laszlo's-unkempt-git-guide-for-edk2-contributors-and-maintainers#contrib-23

    * finally, add all of the Cc: tags to the cover letter that you
      used across all of the patches. This will ensure that even if a
      maintainer is involved in reviewing one or two of your patches
      across the series, he or she will get a copy of your cover
      letter, which outlines the full feature or bugfix.

Thanks,
Laszlo