From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 036B881DA0 for ; Fri, 11 Nov 2016 04:39:40 -0800 (PST) Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga102.fm.intel.com with ESMTP; 11 Nov 2016 04:39:44 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.31,621,1473145200"; d="scan'208";a="30201830" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by orsmga005.jf.intel.com with ESMTP; 11 Nov 2016 04:39:44 -0800 Received: from shsmsx103.ccr.corp.intel.com (10.239.4.69) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.248.2; Fri, 11 Nov 2016 04:39:44 -0800 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.239]) by SHSMSX103.ccr.corp.intel.com ([169.254.4.96]) with mapi id 14.03.0248.002; Fri, 11 Nov 2016 20:39:42 +0800 From: "Fan, Jeff" To: Laszlo Ersek CC: "edk2-devel@ml01.01.org" , "Tian, Feng" , "Yao, Jiewen" , "Kinney, Michael D" , Paolo Bonzini Thread-Topic: [edk2] [PATCH 0/2] Place APs to suitable state on Legacy OS boot Thread-Index: AQHSPBLpA5xJSn1xJ0itCh65B6tbi6DTMTmAgACH12A= Date: Fri, 11 Nov 2016 12:39:41 +0000 Message-ID: <542CF652F8836A4AB8DBFAAD40ED192A4A2DACBD@shsmsx102.ccr.corp.intel.com> References: <20161111115740.8024-1-jeff.fan@intel.com> In-Reply-To: Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYmUwMjAyNDEtNzAxZS00YmQ5LTkzY2UtOTMxOGIzOTg3ODEwIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6Ilh1eG00TlNveGx0bHZaeTRPVGtVM0Y3NkhwYkZOQW5sRFoxdzM3OExFT009In0= x-ctpclassification: CTP_IC x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH 0/2] Place APs to suitable state on Legacy OS boot X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 11 Nov 2016 12:39:41 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Laszlo, Got you. It's a good suggestion! Jeff -----Original Message----- From: Laszlo Ersek [mailto:lersek@redhat.com]=20 Sent: Friday, November 11, 2016 8:33 PM To: Fan, Jeff Cc: edk2-devel@ml01.01.org; Tian, Feng; Yao, Jiewen; Kinney, Michael D; Pao= lo Bonzini Subject: Re: [edk2] [PATCH 0/2] Place APs to suitable state on Legacy OS bo= ot On 11/11/16 12:57, Jeff Fan wrote: > Currently, DxeMpLib only places APs into specified c-state in Exit=20 > Boot Service callback function for UEFI OS boot. We need to put APs=20 > into specified c-state for legacy OS boot also. >=20 > https://bugzilla.tianocore.org/show_bug.cgi?id=3D210 >=20 > Jeff Fan (2): > UefiCpuPkg/DxeMpLib: Rename MpInitExitBootServicesCallback() > UefiCpuPkg/DxeMpLib: Place APs to suitable state on Legacy OS boot >=20 > UefiCpuPkg/Library/MpInitLib/DxeMpInitLib.inf | 1 + > UefiCpuPkg/Library/MpInitLib/DxeMpLib.c | 18 +++++++++++++++--- > 2 files changed, 16 insertions(+), 3 deletions(-) >=20 >>From a cursory look, it looks good to me, but I think I'll leave the offici= al review on this to Mike et al :) Also, a meta-hint: when you post a cover letter for a patch series, it is b= est to collect all the CC's from the patches, sort them uniquely, and then = add the resulting CC list to the cover letter as well. This way every CC'd = person will receive the high level description for the entire set. https://github.com/tianocore/tianocore.github.io/wiki/Laszlo's-unkempt-git-= guide-for-edk2-contributors-and-maintainers#contrib-23 * finally, add all of the Cc: tags to the cover letter that you used across all of the patches. This will ensure that even if a maintainer is involved in reviewing one or two of your patches across the series, he or she will get a copy of your cover letter, which outlines the full feature or bugfix. Thanks, Laszlo