From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id B413A81E46 for ; Thu, 17 Nov 2016 16:48:51 -0800 (PST) Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga105.jf.intel.com with ESMTP; 17 Nov 2016 16:48:56 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.31,655,1473145200"; d="scan'208";a="32074548" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by orsmga004.jf.intel.com with ESMTP; 17 Nov 2016 16:48:56 -0800 Received: from fmsmsx118.amr.corp.intel.com (10.18.116.18) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.248.2; Thu, 17 Nov 2016 16:48:56 -0800 Received: from shsmsx103.ccr.corp.intel.com (10.239.4.69) by fmsmsx118.amr.corp.intel.com (10.18.116.18) with Microsoft SMTP Server (TLS) id 14.3.248.2; Thu, 17 Nov 2016 16:48:56 -0800 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.239]) by SHSMSX103.ccr.corp.intel.com ([169.254.4.96]) with mapi id 14.03.0248.002; Fri, 18 Nov 2016 08:48:54 +0800 From: "Fan, Jeff" To: "Kinney, Michael D" , "edk2-devel@lists.01.org" CC: "Gao, Liming" , Laszlo Ersek , Andrew Fish Thread-Topic: [Patch v2 0/2] Fix ACPI S3 resume failure with GCC 5.4 Thread-Index: AQHSQRg/XTL2MT359Uuh/gEvzG3Yo6Dd6NSQ Date: Fri, 18 Nov 2016 00:48:53 +0000 Message-ID: <542CF652F8836A4AB8DBFAAD40ED192A4A2E1285@shsmsx102.ccr.corp.intel.com> References: <1479417550-20400-1-git-send-email-michael.d.kinney@intel.com> In-Reply-To: <1479417550-20400-1-git-send-email-michael.d.kinney@intel.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiOTI5NDM5YjUtMTYwNy00YjEwLWEzMmYtMGQ0ZGEzYjNlZmRmIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6IkM1TVN0VEh6NFwvdThqMUt4bjRsNk83bE5sOUphVXFqVFBzMThkNWRjXC9wWT0ifQ== x-ctpclassification: CTP_IC x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [Patch v2 0/2] Fix ACPI S3 resume failure with GCC 5.4 X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 18 Nov 2016 00:48:51 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Jeff Fan Thanks! -----Original Message----- From: Kinney, Michael D=20 Sent: Friday, November 18, 2016 5:19 AM To: edk2-devel@lists.01.org Cc: Gao, Liming; Laszlo Ersek; Andrew Fish; Fan, Jeff Subject: [Patch v2 0/2] Fix ACPI S3 resume failure with GCC 5.4 Add volatile qualifier to mNumberToFinish to prevent GCC 5.4 compiler from = optimizing away required logic in ACPI S3 resume. Update TransferApToSafeState() use UINTN params to reduce the number of typ= e casts required in these calls and change the NumberToFinish parameter fro= m UINT32* to UINTN NumberToFinishAddress to resolve compiler warnings from = a volatile pointer to a non-volatile pointer conversion. Cc: Liming Gao Cc: Laszlo Ersek Cc: Andrew Fish Cc: Jeff Fan Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Michael Kinney Michael Kinney (2): UefiCpuPkg/PiSmmCpuDxeSmm: TransferApToSafeState() use UINTN params UefiCpuPkg/PiSmmCpuDxeSmm: Add volatile to mNumberToFinish UefiCpuPkg/PiSmmCpuDxeSmm/CpuS3.c | 10 +++++----- UefiCpuPkg/PiSmmCpuDxeSmm/Ia32/SmmFuncsArch.c | 18 +++++++++--------- UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.h | 12 ++++++------ UefiCpuPkg/PiSmmCpuDxeSmm/X64/SmmFuncsArch.c | 18 +++++++++--------- 4 files changed, 29 insertions(+), 29 deletions(-) -- 2.6.3.windows.1