From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id DE176817E4 for ; Tue, 10 Jan 2017 17:45:31 -0800 (PST) Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga104.fm.intel.com with ESMTP; 10 Jan 2017 17:45:31 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,345,1477983600"; d="scan'208";a="47642716" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by orsmga004.jf.intel.com with ESMTP; 10 Jan 2017 17:45:31 -0800 Received: from FMSMSX109.amr.corp.intel.com (10.18.116.9) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.248.2; Tue, 10 Jan 2017 17:45:31 -0800 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by fmsmsx109.amr.corp.intel.com (10.18.116.9) with Microsoft SMTP Server (TLS) id 14.3.248.2; Tue, 10 Jan 2017 17:45:30 -0800 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.88]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.132]) with mapi id 14.03.0248.002; Wed, 11 Jan 2017 09:45:28 +0800 From: "Fan, Jeff" To: "Gao, Liming" , Leo Duran , "edk2-devel@lists.01.org" CC: "brijesh.singh@amd.com" , "Justen, Jordan L" , "Kinney, Michael D" , "lersek@redhat.com" Thread-Topic: [edk2] [PATCH 0/8] IoLib class library Thread-Index: AQHSa50iiBnp3O5ut0yrkkmi2UNEiqEx+loAgACGp1A= Date: Wed, 11 Jan 2017 01:45:28 +0000 Message-ID: <542CF652F8836A4AB8DBFAAD40ED192A4C5122BA@shsmsx102.ccr.corp.intel.com> References: <1484092554-26224-1-git-send-email-leo.duran@amd.com> <4A89E2EF3DFEDB4C8BFDE51014F606A14D6CCE7E@shsmsx102.ccr.corp.intel.com> In-Reply-To: <4A89E2EF3DFEDB4C8BFDE51014F606A14D6CCE7E@shsmsx102.ccr.corp.intel.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiODMyNmVkMzEtNDA1NC00OTY3LWE1MGYtMThiMDk4NjE5NmE0IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6Imc3K3dlNHVqdTRUNU5aT0RDUmhEMDJFS1p3TjNPQlZWWHBJeU9cL0xQVWQ0PSJ9 x-ctpclassification: CTP_IC x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH 0/8] IoLib class library X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 11 Jan 2017 01:45:32 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Leo, I suggest not to add .asm file again. It's hard to maintain in the future, = because VS and GCC compile .nasm file by default now. Liming, any comments? Thanks! Jeff -----Original Message----- From: Gao, Liming=20 Sent: Wednesday, January 11, 2017 9:42 AM To: Leo Duran; edk2-devel@lists.01.org Cc: brijesh.singh@amd.com; Justen, Jordan L; Kinney, Michael D; lersek@redh= at.com; Fan, Jeff Subject: RE: [edk2] [PATCH 0/8] IoLib class library Leo: Thanks for your update. Here is my comments.=20 1) PeiIoLib, DxeIoLibCpuIo, DxeIoLibCpuIo2 library instance can base on CPU= IO service to do FifoIo operation. They don't implement them again. 2) IntelFrameworkModulePkg CpuIoDxe and UefiCpuPkg CpuIoPei driver can be u= pdated to base on FifoIo API for their FifoIo implementation. 3) One coding style issue. We don't assign value to the variable declaratio= n.=20 UINT8 *Buffer8 =3D (UINT8 *)Buffer; =3D=3D> UINT8 *Buffer8; Buffer8 =3D (UINT8 *)Buffer; Thanks Liming -----Original Message----- From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Leo = Duran Sent: Wednesday, January 11, 2017 7:56 AM To: edk2-devel@lists.01.org Cc: brijesh.singh@amd.com; Justen, Jordan L ; Ga= o, Liming ; Leo Duran ; Kinney, Mi= chael D ; lersek@redhat.com; Fan, Jeff Subject: [edk2] [PATCH 0/8] IoLib class library The UefiCpuPkg/CpuIo2Dxe driver and the QemuCfgLib library have duplicate i= mplementations of I/O Fifo routines. The patch series moves the I/O Fifo ro= utines into the BaseIoLibIntrinsic library and expands the IoLib class to i= nclude the ported I/O Fifo routines. The Fifo routines moved from the UefiCpuPkg/CpuIo2Dxe driver support IA32 a= nd X64 natively, and other architectures are supported by simply looping th= rough the basic IoRead/IoWrite routines as appropiate. The intent of this patch series is twofold: 1) Integrate I/O Fifo routines into the IoLib class library. 2) Allow override of IoLib as may be required to support specific hardware = implementations, such as AMD's Secure Encrypted Virtualization (SEV). Leo Duran (8): MdePkg: Expand BaseIoLibIntrinsic (IoLib class) library MdePkg/DxeIoLibCpuIo2: Add new Fifo routines in IoLib class MdePkg/DxeIoLibEsal: Add new Fifo routines in IoLib class MdePkg/PeiIoLibCpuIo: Add new Fifo routines in IoLib class MdePkg/SmmIoLibSmmCpuIo2: Add new Fifo routines in IoLib class IntelFrameworkPkg/DxeIoLibCpuIo: Add new Fifo routines in IoLib class UefiCpuPkg: Modify CpuIo2Dxe to use new IoLib class library OvmfPkg: Modify QemuFwCfgLib to use new IoLib class library IntelFrameworkPkg/Library/DxeIoLibCpuIo/IoLib.c | 203 +++++++++++++++++= ++++ MdePkg/Include/Library/IoLib.h | 158 ++++++++++++++++ .../BaseIoLibIntrinsic/BaseIoLibIntrinsic.inf | 6 +- .../Library/BaseIoLibIntrinsic}/Ia32/IoFifo.asm | 1 + .../Library/BaseIoLibIntrinsic}/Ia32/IoFifo.nasm | 1 + MdePkg/Library/BaseIoLibIntrinsic/IoLibArm.c | 182 +++++++++++++++++= + MdePkg/Library/BaseIoLibIntrinsic/IoLibEbc.c | 179 +++++++++++++++++= + MdePkg/Library/BaseIoLibIntrinsic/IoLibIpf.c | 201 +++++++++++++++++= +++ .../Library/BaseIoLibIntrinsic}/X64/IoFifo.asm | 1 + .../Library/BaseIoLibIntrinsic}/X64/IoFifo.nasm | 1 + MdePkg/Library/DxeIoLibCpuIo2/IoLib.c | 203 +++++++++++++++++= ++++ MdePkg/Library/DxeIoLibEsal/IoLib.c | 203 +++++++++++++++++= ++++ MdePkg/Library/PeiIoLibCpuIo/IoLib.c | 203 +++++++++++++++++= ++++ MdePkg/Library/SmmIoLibSmmCpuIo2/IoLib.c | 203 +++++++++++++++++= ++++ OvmfPkg/Library/QemuFwCfgLib/Ia32/IoLibExAsm.nasm | 55 ------ OvmfPkg/Library/QemuFwCfgLib/QemuFwCfgLib.c | 54 +----- OvmfPkg/Library/QemuFwCfgLib/QemuFwCfgLib.inf | 7 +- OvmfPkg/Library/QemuFwCfgLib/QemuFwCfgSecLib.inf | 7 +- OvmfPkg/Library/QemuFwCfgLib/X64/IoLibExAsm.nasm | 52 ------ UefiCpuPkg/CpuIo2Dxe/CpuIo2Dxe.c | 3 +- UefiCpuPkg/CpuIo2Dxe/CpuIo2Dxe.inf | 11 +- UefiCpuPkg/CpuIo2Dxe/IoFifo.h | 176 -----------------= - 22 files changed, 1751 insertions(+), 359 deletions(-) rename {UefiCpuPkg= /CpuIo2Dxe =3D> MdePkg/Library/BaseIoLibIntrinsic}/Ia32/IoFifo.asm (94%) r= ename {UefiCpuPkg/CpuIo2Dxe =3D> MdePkg/Library/BaseIoLibIntrinsic}/Ia32/Io= Fifo.nasm (94%) rename {UefiCpuPkg/CpuIo2Dxe =3D> MdePkg/Library/BaseIoLib= Intrinsic}/X64/IoFifo.asm (95%) rename {UefiCpuPkg/CpuIo2Dxe =3D> MdePkg/L= ibrary/BaseIoLibIntrinsic}/X64/IoFifo.nasm (95%) delete mode 100644 OvmfPk= g/Library/QemuFwCfgLib/Ia32/IoLibExAsm.nasm delete mode 100644 OvmfPkg/Library/QemuFwCfgLib/X64/IoLibExAsm.nasm delete mode 100644 UefiCpuPkg/CpuIo2Dxe/IoFifo.h -- 1.9.1 _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel