From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id E425481E9C for ; Thu, 19 Jan 2017 20:42:11 -0800 (PST) Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga103.fm.intel.com with ESMTP; 19 Jan 2017 20:42:11 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,257,1477983600"; d="scan'208";a="56118169" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by fmsmga006.fm.intel.com with ESMTP; 19 Jan 2017 20:42:11 -0800 Received: from fmsmsx156.amr.corp.intel.com (10.18.116.74) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.248.2; Thu, 19 Jan 2017 20:42:11 -0800 Received: from shsmsx103.ccr.corp.intel.com (10.239.4.69) by fmsmsx156.amr.corp.intel.com (10.18.116.74) with Microsoft SMTP Server (TLS) id 14.3.248.2; Thu, 19 Jan 2017 20:42:11 -0800 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.88]) by SHSMSX103.ccr.corp.intel.com ([10.239.4.69]) with mapi id 14.03.0248.002; Fri, 20 Jan 2017 12:42:09 +0800 From: "Fan, Jeff" To: "Zeng, Star" , "edk2-devel@lists.01.org" CC: "Ni, Ruiyu" , "Gao, Liming" , "Kinney, Michael D" Thread-Topic: [PATCH 4/7] IntelFrameworkModulePkg: Use EfiEventEmptyFunction from UefiLib Thread-Index: AQHScJCXaRIFv/S9XE2I/rrt41ZYZqFAzeGw Date: Fri, 20 Jan 2017 04:42:08 +0000 Message-ID: <542CF652F8836A4AB8DBFAAD40ED192A4C520322@shsmsx102.ccr.corp.intel.com> References: <1484636920-180432-1-git-send-email-star.zeng@intel.com> <1484636920-180432-5-git-send-email-star.zeng@intel.com> In-Reply-To: <1484636920-180432-5-git-send-email-star.zeng@intel.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiOTM4NDE1NmYtNjRmZS00MDFhLTk5ZjItYTU5OTUyZDllOTRhIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6ImlXNm1mYjBIT1lUaStqMFQzMDNOakxNdHR3eTVTZVN6eGdzTGpCWDRSSEU9In0= x-ctpclassification: CTP_IC x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH 4/7] IntelFrameworkModulePkg: Use EfiEventEmptyFunction from UefiLib X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 20 Jan 2017 04:42:12 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Jeff Fan -----Original Message----- From: Zeng, Star=20 Sent: Tuesday, January 17, 2017 3:09 PM To: edk2-devel@lists.01.org Cc: Zeng, Star; Fan, Jeff; Ni, Ruiyu; Gao, Liming; Kinney, Michael D Subject: [PATCH 4/7] IntelFrameworkModulePkg: Use EfiEventEmptyFunction fro= m UefiLib Use EfiEventEmptyFunction from UefiLib and remove the duplication of event = empty function. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D298 Cc: Jeff Fan Cc: Ruiyu Ni Cc: Liming Gao Cc: Michael Kinney Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Star Zeng --- IntelFrameworkModulePkg/Universal/BdsDxe/BdsEntry.c | 20 +----------------= --- 1 file changed, 1 insertion(+), 19 deletions(-) diff --git a/IntelFrameworkModulePkg/Universal/BdsDxe/BdsEntry.c b/IntelFra= meworkModulePkg/Universal/BdsDxe/BdsEntry.c index bf81de40a31d..8a64f041426a 100644 --- a/IntelFrameworkModulePkg/Universal/BdsDxe/BdsEntry.c +++ b/IntelFrameworkModulePkg/Universal/BdsDxe/BdsEntry.c @@ -83,24 +83,6 @@ BdsInitialize ( return Status; } =20 - -/** - An empty function to pass error checking of CreateEventEx (). - - @param Event Event whose notification function is being= invoked. - @param Context Pointer to the notification function's con= text, - which is implementation-dependent. - -**/ -VOID -EFIAPI -BdsEmptyCallbackFunction ( - IN EFI_EVENT Event, - IN VOID *Context - ) -{ -} - /** =20 This function attempts to boot for the boot order specified @@ -144,7 +1= 26,7 @@ BdsBootDeviceSelect ( Status =3D gBS->CreateEventEx ( EVT_NOTIFY_SIGNAL, TPL_CALLBACK, - BdsEmptyCallbackFunction, + EfiEventEmptyFunction, NULL, &gConnectConInEventGuid, &ConnectConInEvent -- 2.7.0.windows.1