public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Fan, Jeff" <jeff.fan@intel.com>
To: "Zeng, Star" <star.zeng@intel.com>,
	"Duran, Leo" <leo.duran@amd.com>,
	"'edk2-devel@ml01.01.org'" <edk2-devel@ml01.01.org>,
	"Tian, Feng" <feng.tian@intel.com>
Cc: "Yao, Jiewen" <jiewen.yao@intel.com>
Subject: Re: UefiCpuPkg: PiSmmCpuDxeSmm (MpServioce.c)
Date: Wed, 22 Feb 2017 01:26:13 +0000	[thread overview]
Message-ID: <542CF652F8836A4AB8DBFAAD40ED192A4C54288C@shsmsx102.ccr.corp.intel.com> (raw)
In-Reply-To: <0C09AFA07DD0434D9E2A0C6AEB0483103B829F73@shsmsx102.ccr.corp.intel.com>

I agree to remove it.

-----Original Message-----
From: Zeng, Star 
Sent: Wednesday, February 22, 2017 9:23 AM
To: Duran, Leo; Fan, Jeff; 'edk2-devel@ml01.01.org'; Tian, Feng
Cc: Yao, Jiewen; Zeng, Star
Subject: RE: UefiCpuPkg: PiSmmCpuDxeSmm (MpServioce.c)

Leo,

Seemingly, you are right that no one is using SetCacheability().

Jeff,

Could you confirm that?

Thanks,
Star

-----Original Message-----
From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Duran, Leo
Sent: Wednesday, February 22, 2017 5:44 AM
To: 'edk2-devel@ml01.01.org' <edk2-devel@ml01.01.org>; Tian, Feng <feng.tian@intel.com>
Cc: Zeng, Star <star.zeng@intel.com>
Subject: [edk2] UefiCpuPkg: PiSmmCpuDxeSmm (MpServioce.c)

Hi Feng, et al,

I'm wondering if the SetCacheability() function has been deprecated from the build tree?
That is, the function is part of MpService.c, but it does not seem to be used by any other code.

Would be it be OK to remove SetCacheability() from MpService.c?
I ask because I'm preparing a patch for code that touches page-table entries, and I'd prefer to simply ignore/remove SetCacheability(), if it's not needed anymore.

Thanks,
Leo


_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel


      reply	other threads:[~2017-02-22  1:26 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-21 21:44 UefiCpuPkg: PiSmmCpuDxeSmm (MpServioce.c) Duran, Leo
2017-02-22  1:22 ` Zeng, Star
2017-02-22  1:26   ` Fan, Jeff [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=542CF652F8836A4AB8DBFAAD40ED192A4C54288C@shsmsx102.ccr.corp.intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox