* UefiCpuPkg: PiSmmCpuDxeSmm (MpServioce.c)
@ 2017-02-21 21:44 Duran, Leo
2017-02-22 1:22 ` Zeng, Star
0 siblings, 1 reply; 3+ messages in thread
From: Duran, Leo @ 2017-02-21 21:44 UTC (permalink / raw)
To: 'edk2-devel@ml01.01.org', 'Feng Tian'
Cc: 'Zeng, Star'
Hi Feng, et al,
I'm wondering if the SetCacheability() function has been deprecated from the build tree?
That is, the function is part of MpService.c, but it does not seem to be used by any other code.
Would be it be OK to remove SetCacheability() from MpService.c?
I ask because I'm preparing a patch for code that touches page-table entries, and I'd prefer to simply ignore/remove SetCacheability(), if it's not needed anymore.
Thanks,
Leo
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: UefiCpuPkg: PiSmmCpuDxeSmm (MpServioce.c)
2017-02-21 21:44 UefiCpuPkg: PiSmmCpuDxeSmm (MpServioce.c) Duran, Leo
@ 2017-02-22 1:22 ` Zeng, Star
2017-02-22 1:26 ` Fan, Jeff
0 siblings, 1 reply; 3+ messages in thread
From: Zeng, Star @ 2017-02-22 1:22 UTC (permalink / raw)
To: Duran, Leo, Fan, Jeff, 'edk2-devel@ml01.01.org',
Tian, Feng
Cc: Yao, Jiewen, Zeng, Star
Leo,
Seemingly, you are right that no one is using SetCacheability().
Jeff,
Could you confirm that?
Thanks,
Star
-----Original Message-----
From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Duran, Leo
Sent: Wednesday, February 22, 2017 5:44 AM
To: 'edk2-devel@ml01.01.org' <edk2-devel@ml01.01.org>; Tian, Feng <feng.tian@intel.com>
Cc: Zeng, Star <star.zeng@intel.com>
Subject: [edk2] UefiCpuPkg: PiSmmCpuDxeSmm (MpServioce.c)
Hi Feng, et al,
I'm wondering if the SetCacheability() function has been deprecated from the build tree?
That is, the function is part of MpService.c, but it does not seem to be used by any other code.
Would be it be OK to remove SetCacheability() from MpService.c?
I ask because I'm preparing a patch for code that touches page-table entries, and I'd prefer to simply ignore/remove SetCacheability(), if it's not needed anymore.
Thanks,
Leo
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: UefiCpuPkg: PiSmmCpuDxeSmm (MpServioce.c)
2017-02-22 1:22 ` Zeng, Star
@ 2017-02-22 1:26 ` Fan, Jeff
0 siblings, 0 replies; 3+ messages in thread
From: Fan, Jeff @ 2017-02-22 1:26 UTC (permalink / raw)
To: Zeng, Star, Duran, Leo, 'edk2-devel@ml01.01.org',
Tian, Feng
Cc: Yao, Jiewen
I agree to remove it.
-----Original Message-----
From: Zeng, Star
Sent: Wednesday, February 22, 2017 9:23 AM
To: Duran, Leo; Fan, Jeff; 'edk2-devel@ml01.01.org'; Tian, Feng
Cc: Yao, Jiewen; Zeng, Star
Subject: RE: UefiCpuPkg: PiSmmCpuDxeSmm (MpServioce.c)
Leo,
Seemingly, you are right that no one is using SetCacheability().
Jeff,
Could you confirm that?
Thanks,
Star
-----Original Message-----
From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Duran, Leo
Sent: Wednesday, February 22, 2017 5:44 AM
To: 'edk2-devel@ml01.01.org' <edk2-devel@ml01.01.org>; Tian, Feng <feng.tian@intel.com>
Cc: Zeng, Star <star.zeng@intel.com>
Subject: [edk2] UefiCpuPkg: PiSmmCpuDxeSmm (MpServioce.c)
Hi Feng, et al,
I'm wondering if the SetCacheability() function has been deprecated from the build tree?
That is, the function is part of MpService.c, but it does not seem to be used by any other code.
Would be it be OK to remove SetCacheability() from MpService.c?
I ask because I'm preparing a patch for code that touches page-table entries, and I'd prefer to simply ignore/remove SetCacheability(), if it's not needed anymore.
Thanks,
Leo
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-02-22 1:26 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-02-21 21:44 UefiCpuPkg: PiSmmCpuDxeSmm (MpServioce.c) Duran, Leo
2017-02-22 1:22 ` Zeng, Star
2017-02-22 1:26 ` Fan, Jeff
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox