From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 0A86882241 for ; Tue, 21 Feb 2017 17:26:17 -0800 (PST) Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 21 Feb 2017 17:26:16 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.35,191,1484035200"; d="scan'208";a="60948075" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by orsmga004.jf.intel.com with ESMTP; 21 Feb 2017 17:26:16 -0800 Received: from fmsmsx152.amr.corp.intel.com (10.18.125.5) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.248.2; Tue, 21 Feb 2017 17:26:16 -0800 Received: from shsmsx103.ccr.corp.intel.com (10.239.4.69) by FMSMSX152.amr.corp.intel.com (10.18.125.5) with Microsoft SMTP Server (TLS) id 14.3.248.2; Tue, 21 Feb 2017 17:26:16 -0800 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.88]) by SHSMSX103.ccr.corp.intel.com ([10.239.4.69]) with mapi id 14.03.0248.002; Wed, 22 Feb 2017 09:26:14 +0800 From: "Fan, Jeff" To: "Zeng, Star" , "Duran, Leo" , "'edk2-devel@ml01.01.org'" , "Tian, Feng" CC: "Yao, Jiewen" Thread-Topic: UefiCpuPkg: PiSmmCpuDxeSmm (MpServioce.c) Thread-Index: AdKMi6MACnohGIS0SdGxzhpw4g2m1QAHlqVwAAAfyxA= Date: Wed, 22 Feb 2017 01:26:13 +0000 Message-ID: <542CF652F8836A4AB8DBFAAD40ED192A4C54288C@shsmsx102.ccr.corp.intel.com> References: <0C09AFA07DD0434D9E2A0C6AEB0483103B829F73@shsmsx102.ccr.corp.intel.com> In-Reply-To: <0C09AFA07DD0434D9E2A0C6AEB0483103B829F73@shsmsx102.ccr.corp.intel.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiM2MyZjcwN2EtMjc3MS00NzIxLThkMzEtOWFkMmQzNGQ3ZDVhIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6IlJcL1BiQVl4d2JYRHN5YkNCNksyT1l1dm5CeXRYamhzMGVaa010Um5lU3VnPSJ9 x-ctpclassification: CTP_IC x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: UefiCpuPkg: PiSmmCpuDxeSmm (MpServioce.c) X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 22 Feb 2017 01:26:17 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable I agree to remove it. -----Original Message----- From: Zeng, Star=20 Sent: Wednesday, February 22, 2017 9:23 AM To: Duran, Leo; Fan, Jeff; 'edk2-devel@ml01.01.org'; Tian, Feng Cc: Yao, Jiewen; Zeng, Star Subject: RE: UefiCpuPkg: PiSmmCpuDxeSmm (MpServioce.c) Leo, Seemingly, you are right that no one is using SetCacheability(). Jeff, Could you confirm that? Thanks, Star -----Original Message----- From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Dura= n, Leo Sent: Wednesday, February 22, 2017 5:44 AM To: 'edk2-devel@ml01.01.org' ; Tian, Feng Cc: Zeng, Star Subject: [edk2] UefiCpuPkg: PiSmmCpuDxeSmm (MpServioce.c) Hi Feng, et al, I'm wondering if the SetCacheability() function has been deprecated from th= e build tree? That is, the function is part of MpService.c, but it does not seem to be us= ed by any other code. Would be it be OK to remove SetCacheability() from MpService.c? I ask because I'm preparing a patch for code that touches page-table entrie= s, and I'd prefer to simply ignore/remove SetCacheability(), if it's not ne= eded anymore. Thanks, Leo _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel