From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 7F9A521DFA91C for ; Thu, 6 Apr 2017 17:46:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=intel.com; i=@intel.com; q=dns/txt; s=intel; t=1491525992; x=1523061992; h=from:to:cc:subject:date:message-id:references: in-reply-to:mime-version; bh=UF8lweNs28xHRXzoHts7XZ0wovZIevGX08RRjL1fkvs=; b=xC1kk2QBcv0ezZaZpKtKcLlMHN1F6WInSfPw3d1c6gdMr6hthIAYmRpa H59fLsIX5w7Www749EiEZVL3+aNGbA==; Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 06 Apr 2017 17:46:32 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.37,161,1488873600"; d="scan'208,217";a="1132276666" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by fmsmga001.fm.intel.com with ESMTP; 06 Apr 2017 17:46:31 -0700 Received: from fmsmsx122.amr.corp.intel.com (10.18.125.37) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.319.2; Thu, 6 Apr 2017 17:46:31 -0700 Received: from shsmsx103.ccr.corp.intel.com (10.239.4.69) by fmsmsx122.amr.corp.intel.com (10.18.125.37) with Microsoft SMTP Server (TLS) id 14.3.319.2; Thu, 6 Apr 2017 17:46:31 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.246]) by SHSMSX103.ccr.corp.intel.com ([169.254.4.117]) with mapi id 14.03.0319.002; Fri, 7 Apr 2017 08:46:29 +0800 From: "Fan, Jeff" To: "Yao, Jiewen" , "edk2-devel@lists.01.org" CC: "Kinney, Michael D" , "Tian, Feng" Thread-Topic: [PATCH 0/9] Export Dump CPU Context service Thread-Index: AQHSrzehLcl/s7SSL065sJk4L8epmaG5Ed2Q Date: Fri, 7 Apr 2017 00:46:27 +0000 Message-ID: <542CF652F8836A4AB8DBFAAD40ED192A4C597F8A@shsmsx102.ccr.corp.intel.com> References: <20170401132530.8340-1-jeff.fan@intel.com> <74D8A39837DF1E4DA445A8C0B3885C503A928876@shsmsx102.ccr.corp.intel.com> In-Reply-To: <74D8A39837DF1E4DA445A8C0B3885C503A928876@shsmsx102.ccr.corp.intel.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYjk5YmM3YWQtZDE0Mi00OTNlLTk2YmItMmRmMjVlZmRjYjRjIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6InorWjlqWWxTTVB5ZndMXC90ZnpHdUVPS3g4VDRVYk9aODBIVERQWE5PbFg0PSJ9 x-ctpclassification: CTP_IC x-originating-ip: [10.239.127.40] MIME-Version: 1.0 X-Content-Filtered-By: Mailman/MimeDel 2.1.22 Subject: Re: [PATCH 0/9] Export Dump CPU Context service X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 07 Apr 2017 00:46:32 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Jiewen, That's fine. If you consider the patch based on module for this case is bet= ter your review, I will combine some of them soon. Thanks! Jeff From: Yao, Jiewen Sent: Friday, April 07, 2017 8:41 AM To: Fan, Jeff; edk2-devel@lists.01.org Cc: Kinney, Michael D; Tian, Feng Subject: RE: [PATCH 0/9] Export Dump CPU Context service Hi I do not think it is necessary to split this simple patch to so many. It brings burden to me to review the change. For example, there are 4 patch= es for CpuExceptionHandlerLib. Can we combine the patch based upon the module? Thank you Yao Jiewen > -----Original Message----- > From: Fan, Jeff > Sent: Saturday, April 1, 2017 9:25 PM > To: edk2-devel@lists.01.org > Cc: Yao, Jiewen >; Kinn= ey, Michael D > >; Tian, Fe= ng > > Subject: [PATCH 0/9] Export Dump CPU Context service > > This serial of patches are: > 1. Export PeCoffSerachImageBase() that could serach PE/COFF image base. > 2. Export DumpCpuContext that could dump CPU context when exception > happened. > > https://bugzilla.tianocore.org/show_bug.cgi?id=3D242 > > Cc: Jiewen Yao > > Cc: Michael Kinney > > Cc: Feng Tian > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Jeff Fan > > > Jeff Fan (9): > MdePkg/PeCoffGetEntryPointLib: Add PeCoffSerachImageBase() > MdeModulePkg/CpuExceptionHandlerLib: Add DumpCpuContext() > UefiCpuPkg/CpuExceptionHandlerLib: Rename internal DumpCpuContent() > UefiCpuPkg/CpuExceptionHandlerLib: Add DumpModuleImageInfo() > UefiCpuPkg/CpuExceptionHandlerLib: Add DumpCpuContext() > implementation > UefiCpuPkg/CpuExceptionHandlerLib: Display PF Excption Data bit > UefiCpuPkg/PiSmmCpuDxeSmm: Consume PeCoffSerachImageBase() > UefiCpuPkg/PiSmmCpuDxeSmm: Consume DumpCpuContext() > SourceLevelDebugPkg/DebugAgent.c: Consume PeCoffSerachImageBase() > > .../Include/Library/CpuExceptionHandlerLib.h | 15 ++++- > .../CpuExceptionHandlerLibNull.c | 16 ++++- > MdePkg/Include/Library/PeCoffGetEntryPointLib.h | 20 +++++- > .../PeCoffGetEntryPoint.c | 72 > ++++++++++++++++++++- > .../DebugAgent/DebugAgentCommon/DebugAgent.c | 50 ++------------- > .../CpuExceptionHandlerLib/CpuExceptionCommon.c | 75 > ++++++---------------- > .../CpuExceptionHandlerLib/CpuExceptionCommon.h | 27 +++++--- > .../Library/CpuExceptionHandlerLib/DxeException.c | 7 +- > .../Ia32/ArchExceptionHandler.c | 65 > ++++++++++++------- > .../CpuExceptionHandlerLib/PeiCpuException.c | 6 +- > .../CpuExceptionHandlerLib/PeiDxeSmmCpuException.c | 4 +- > .../CpuExceptionHandlerLib/SecPeiCpuException.c | 8 +-- > .../Library/CpuExceptionHandlerLib/SmmException.c | 7 +- > .../X64/ArchExceptionHandler.c | 57 ++++++++++------ > UefiCpuPkg/PiSmmCpuDxeSmm/Ia32/PageTbl.c | 18 ++---- > UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.c | 37 +---------- > UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.h | 4 +- > UefiCpuPkg/PiSmmCpuDxeSmm/SmmProfileInternal.h | 6 +- > UefiCpuPkg/PiSmmCpuDxeSmm/X64/PageTbl.c | 18 ++---- > 19 files changed, 265 insertions(+), 247 deletions(-) > > -- > 2.9.3.windows.2