From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id DB22321A16EEF for ; Fri, 19 May 2017 04:57:13 -0700 (PDT) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga104.jf.intel.com with ESMTP; 19 May 2017 04:57:13 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.38,363,1491289200"; d="scan'208";a="859025429" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by FMSMGA003.fm.intel.com with ESMTP; 19 May 2017 04:57:13 -0700 Received: from fmsmsx155.amr.corp.intel.com (10.18.116.71) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.319.2; Fri, 19 May 2017 04:57:13 -0700 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by FMSMSX155.amr.corp.intel.com (10.18.116.71) with Microsoft SMTP Server (TLS) id 14.3.319.2; Fri, 19 May 2017 04:57:12 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.246]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.193]) with mapi id 14.03.0319.002; Fri, 19 May 2017 19:57:10 +0800 From: "Fan, Jeff" To: "Kinney, Michael D" , "edk2-devel@lists.01.org" CC: "Gao, Liming" Thread-Topic: [Patch] UefiCpuPkg: Use FINIT instead of hex values Thread-Index: AQHS0GpdJ+Zx9XsHr0unn4TmZEuYMqH7jR8Q Date: Fri, 19 May 2017 11:57:09 +0000 Message-ID: <542CF652F8836A4AB8DBFAAD40ED192A4C5E5B12@shsmsx102.ccr.corp.intel.com> References: <1495175827-23664-1-git-send-email-michael.d.kinney@intel.com> In-Reply-To: <1495175827-23664-1-git-send-email-michael.d.kinney@intel.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYmMzNjhkYTMtY2Q4Zi00MDNmLWJlYjItNzg2YmE3MGUwNDEzIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6IkJcLzhiNXdJbURFNVhseUJuMVBPTjVna0NsTXNCV2M0Y2VZNVB3RERLcmFnPSJ9 x-ctpclassification: CTP_IC x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [Patch] UefiCpuPkg: Use FINIT instead of hex values X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 19 May 2017 11:57:14 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Jeff Fan -----Original Message----- From: Kinney, Michael D=20 Sent: Friday, May 19, 2017 2:37 PM To: edk2-devel@lists.01.org Cc: Fan, Jeff; Gao, Liming; Kinney, Michael D Subject: [Patch] UefiCpuPkg: Use FINIT instead of hex values https://bugzilla.tianocore.org/show_bug.cgi?id=3D560 Update X64 NASM file to match IA32 NASM file and use FINIT instruction inst= ead of hand assembled hex values for the FINIT instruction. Cc: Jeff Fan Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Michael D Kinney --- UefiCpuPkg/Library/BaseUefiCpuLib/X64/InitializeFpu.nasm | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/UefiCpuPkg/Library/BaseUefiCpuLib/X64/InitializeFpu.nasm b/Uef= iCpuPkg/Library/BaseUefiCpuLib/X64/InitializeFpu.nasm index 904b64e..41cd84e 100644 --- a/UefiCpuPkg/Library/BaseUefiCpuLib/X64/InitializeFpu.nasm +++ b/UefiCpuPkg/Library/BaseUefiCpuLib/X64/InitializeFpu.nasm @@ -1,6 +1,6 @@ ;-------------------------------------------------------------------------= ----- ;* -;* Copyright (c) 2009 - 2012, Intel Corporation. All rights reserved. +;* Copyright (c) 2009 - 2017, Intel Corporation. All rights reserved. ;* This program and the accompanying materials ;* are licensed and made available under the terms and conditions of the= BSD License ;* which accompanies this distribution. The full text of the license ma= y be found at @@ -41,10 +41,7 @@ ASM_PFX(InitializeFloatingPointUnits): ; ; Initialize floating point units ; - ; The following opcodes stand for instruction 'finit' - ; to be supported by some 64-bit assemblers - ; - DB 0x9B, 0xDB, 0xE3 + finit fldcw [mFpuControlWord] =20 ; -- 2.6.3.windows.1