From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 9B42F21BB253B for ; Mon, 12 Jun 2017 22:30:33 -0700 (PDT) Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 12 Jun 2017 22:31:47 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.39,336,1493708400"; d="scan'208";a="980082698" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by orsmga003.jf.intel.com with ESMTP; 12 Jun 2017 22:31:46 -0700 Received: from fmsmsx124.amr.corp.intel.com (10.18.125.39) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.319.2; Mon, 12 Jun 2017 22:31:46 -0700 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by fmsmsx124.amr.corp.intel.com (10.18.125.39) with Microsoft SMTP Server (TLS) id 14.3.319.2; Mon, 12 Jun 2017 22:31:46 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.146]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.56]) with mapi id 14.03.0319.002; Tue, 13 Jun 2017 13:31:42 +0800 From: "Fan, Jeff" To: "Yao, Jiewen" , "edk2-devel@lists.01.org" CC: "Kinney, Michael D" Thread-Topic: [PATCH] UefiCpuPkg/SmmCpuFeatureLib: Add more CPU ID for SmmFeatureControl. Thread-Index: AQHS4yGFpf69j/T7f0yX4DrmlkbRfqIiRc4A Date: Tue, 13 Jun 2017 05:31:41 +0000 Message-ID: <542CF652F8836A4AB8DBFAAD40ED192A4C609152@shsmsx102.ccr.corp.intel.com> References: <1497233616-25564-1-git-send-email-jiewen.yao@intel.com> In-Reply-To: <1497233616-25564-1-git-send-email-jiewen.yao@intel.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiOWRiODg3MjEtN2YzNi00ZTg4LWI2YTAtNTZlNjVhZDI5OWM1IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6IlNSM25naEVLUEhNeUhBcm1VTmF2Y0w5YUV1WlVLQ1FDamNqRzNHSXAxOEk9In0= x-ctpclassification: CTP_IC x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH] UefiCpuPkg/SmmCpuFeatureLib: Add more CPU ID for SmmFeatureControl. X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Jun 2017 05:30:33 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Jiewen, Besides you added ModelId, we still have the following ModelId support SMM = Code Access Check feature in IA32 SDM. Processor: ModelId Goldmont 0x5C HaswellE 0x3F XeonD 0x4F, 0x56 XeonPhi 0x57 Could you also add them into your patch? Thank! Jeff -----Original Message----- From: Yao, Jiewen=20 Sent: Monday, June 12, 2017 10:14 AM To: edk2-devel@lists.01.org Cc: Fan, Jeff; Kinney, Michael D Subject: [PATCH] UefiCpuPkg/SmmCpuFeatureLib: Add more CPU ID for SmmFeatur= eControl. Add more CPU ID which can support SmmFeatureControl, according to IA32 SDM. Cc: Jeff Fan Cc: Michael Kinney Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jiewen Yao --- UefiCpuPkg/Library/SmmCpuFeaturesLib/SmmCpuFeaturesLib.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/UefiCpuPkg/Library/SmmCpuFeaturesLib/SmmCpuFeaturesLib.c b/Uef= iCpuPkg/Library/SmmCpuFeaturesLib/SmmCpuFeaturesLib.c index 079baa4..b0c442e 100644 --- a/UefiCpuPkg/Library/SmmCpuFeaturesLib/SmmCpuFeaturesLib.c +++ b/UefiCpuPkg/Library/SmmCpuFeaturesLib/SmmCpuFeaturesLib.c @@ -296,7 +296,8 @@ SmmCpuFeaturesInitializeProcessor ( // Intel(R) Core(TM) Processor Family MSRs. // if (FamilyId =3D=3D 0x06) { - if (ModelId =3D=3D 0x3C || ModelId =3D=3D 0x45 || ModelId =3D=3D 0x46)= { + if (ModelId =3D=3D 0x3C || ModelId =3D=3D 0x45 || ModelId =3D=3D 0x46 = || + ModelId =3D=3D 0x3D || ModelId =3D=3D 0x47 || ModelId =3D=3D 0x4E = ||=20 + ModelId =3D=3D 0x4F) { // // Check to see if the CPU supports the SMM Code Access Check featur= e // Do not access this MSR unless the CPU supports the SmmRegFeatureC= ontrol -- 2.7.4.windows.1