* [PATCH] UefiCpuPkg/SmmCpuFeatureLib: Add more CPU ID for SmmFeatureControl. @ 2017-06-12 2:13 Jiewen Yao 2017-06-13 5:31 ` Fan, Jeff 0 siblings, 1 reply; 3+ messages in thread From: Jiewen Yao @ 2017-06-12 2:13 UTC (permalink / raw) To: edk2-devel; +Cc: Jeff Fan, Michael Kinney Add more CPU ID which can support SmmFeatureControl, according to IA32 SDM. Cc: Jeff Fan <jeff.fan@intel.com> Cc: Michael Kinney <michael.d.kinney@intel.com> Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jiewen Yao <jiewen.yao@intel.com> --- UefiCpuPkg/Library/SmmCpuFeaturesLib/SmmCpuFeaturesLib.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/UefiCpuPkg/Library/SmmCpuFeaturesLib/SmmCpuFeaturesLib.c b/UefiCpuPkg/Library/SmmCpuFeaturesLib/SmmCpuFeaturesLib.c index 079baa4..b0c442e 100644 --- a/UefiCpuPkg/Library/SmmCpuFeaturesLib/SmmCpuFeaturesLib.c +++ b/UefiCpuPkg/Library/SmmCpuFeaturesLib/SmmCpuFeaturesLib.c @@ -296,7 +296,8 @@ SmmCpuFeaturesInitializeProcessor ( // Intel(R) Core(TM) Processor Family MSRs. // if (FamilyId == 0x06) { - if (ModelId == 0x3C || ModelId == 0x45 || ModelId == 0x46) { + if (ModelId == 0x3C || ModelId == 0x45 || ModelId == 0x46 || + ModelId == 0x3D || ModelId == 0x47 || ModelId == 0x4E || ModelId == 0x4F) { // // Check to see if the CPU supports the SMM Code Access Check feature // Do not access this MSR unless the CPU supports the SmmRegFeatureControl -- 2.7.4.windows.1 ^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] UefiCpuPkg/SmmCpuFeatureLib: Add more CPU ID for SmmFeatureControl. 2017-06-12 2:13 [PATCH] UefiCpuPkg/SmmCpuFeatureLib: Add more CPU ID for SmmFeatureControl Jiewen Yao @ 2017-06-13 5:31 ` Fan, Jeff 2017-06-13 6:43 ` Yao, Jiewen 0 siblings, 1 reply; 3+ messages in thread From: Fan, Jeff @ 2017-06-13 5:31 UTC (permalink / raw) To: Yao, Jiewen, edk2-devel@lists.01.org; +Cc: Kinney, Michael D Jiewen, Besides you added ModelId, we still have the following ModelId support SMM Code Access Check feature in IA32 SDM. Processor: ModelId Goldmont 0x5C HaswellE 0x3F XeonD 0x4F, 0x56 XeonPhi 0x57 Could you also add them into your patch? Thank! Jeff -----Original Message----- From: Yao, Jiewen Sent: Monday, June 12, 2017 10:14 AM To: edk2-devel@lists.01.org Cc: Fan, Jeff; Kinney, Michael D Subject: [PATCH] UefiCpuPkg/SmmCpuFeatureLib: Add more CPU ID for SmmFeatureControl. Add more CPU ID which can support SmmFeatureControl, according to IA32 SDM. Cc: Jeff Fan <jeff.fan@intel.com> Cc: Michael Kinney <michael.d.kinney@intel.com> Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jiewen Yao <jiewen.yao@intel.com> --- UefiCpuPkg/Library/SmmCpuFeaturesLib/SmmCpuFeaturesLib.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/UefiCpuPkg/Library/SmmCpuFeaturesLib/SmmCpuFeaturesLib.c b/UefiCpuPkg/Library/SmmCpuFeaturesLib/SmmCpuFeaturesLib.c index 079baa4..b0c442e 100644 --- a/UefiCpuPkg/Library/SmmCpuFeaturesLib/SmmCpuFeaturesLib.c +++ b/UefiCpuPkg/Library/SmmCpuFeaturesLib/SmmCpuFeaturesLib.c @@ -296,7 +296,8 @@ SmmCpuFeaturesInitializeProcessor ( // Intel(R) Core(TM) Processor Family MSRs. // if (FamilyId == 0x06) { - if (ModelId == 0x3C || ModelId == 0x45 || ModelId == 0x46) { + if (ModelId == 0x3C || ModelId == 0x45 || ModelId == 0x46 || + ModelId == 0x3D || ModelId == 0x47 || ModelId == 0x4E || + ModelId == 0x4F) { // // Check to see if the CPU supports the SMM Code Access Check feature // Do not access this MSR unless the CPU supports the SmmRegFeatureControl -- 2.7.4.windows.1 ^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] UefiCpuPkg/SmmCpuFeatureLib: Add more CPU ID for SmmFeatureControl. 2017-06-13 5:31 ` Fan, Jeff @ 2017-06-13 6:43 ` Yao, Jiewen 0 siblings, 0 replies; 3+ messages in thread From: Yao, Jiewen @ 2017-06-13 6:43 UTC (permalink / raw) To: Fan, Jeff, edk2-devel@lists.01.org; +Cc: Kinney, Michael D Sure, I will send V2 patch soon. > -----Original Message----- > From: Fan, Jeff > Sent: Tuesday, June 13, 2017 1:32 PM > To: Yao, Jiewen <jiewen.yao@intel.com>; edk2-devel@lists.01.org > Cc: Kinney, Michael D <michael.d.kinney@intel.com> > Subject: RE: [PATCH] UefiCpuPkg/SmmCpuFeatureLib: Add more CPU ID for > SmmFeatureControl. > > Jiewen, > > Besides you added ModelId, we still have the following ModelId support SMM > Code Access Check feature in IA32 SDM. > > Processor: ModelId > Goldmont 0x5C > HaswellE 0x3F > XeonD 0x4F, 0x56 > XeonPhi 0x57 > > Could you also add them into your patch? > > Thank! > Jeff > > -----Original Message----- > From: Yao, Jiewen > Sent: Monday, June 12, 2017 10:14 AM > To: edk2-devel@lists.01.org > Cc: Fan, Jeff; Kinney, Michael D > Subject: [PATCH] UefiCpuPkg/SmmCpuFeatureLib: Add more CPU ID for > SmmFeatureControl. > > Add more CPU ID which can support SmmFeatureControl, according to IA32 SDM. > > Cc: Jeff Fan <jeff.fan@intel.com> > Cc: Michael Kinney <michael.d.kinney@intel.com> > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Jiewen Yao <jiewen.yao@intel.com> > --- > UefiCpuPkg/Library/SmmCpuFeaturesLib/SmmCpuFeaturesLib.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/UefiCpuPkg/Library/SmmCpuFeaturesLib/SmmCpuFeaturesLib.c > b/UefiCpuPkg/Library/SmmCpuFeaturesLib/SmmCpuFeaturesLib.c > index 079baa4..b0c442e 100644 > --- a/UefiCpuPkg/Library/SmmCpuFeaturesLib/SmmCpuFeaturesLib.c > +++ b/UefiCpuPkg/Library/SmmCpuFeaturesLib/SmmCpuFeaturesLib.c > @@ -296,7 +296,8 @@ SmmCpuFeaturesInitializeProcessor ( > // Intel(R) Core(TM) Processor Family MSRs. > // > if (FamilyId == 0x06) { > - if (ModelId == 0x3C || ModelId == 0x45 || ModelId == 0x46) { > + if (ModelId == 0x3C || ModelId == 0x45 || ModelId == 0x46 || > + ModelId == 0x3D || ModelId == 0x47 || ModelId == 0x4E || > + ModelId == 0x4F) { > // > // Check to see if the CPU supports the SMM Code Access Check feature > // Do not access this MSR unless the CPU supports the > SmmRegFeatureControl > -- > 2.7.4.windows.1 ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-06-13 6:41 UTC | newest] Thread overview: 3+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2017-06-12 2:13 [PATCH] UefiCpuPkg/SmmCpuFeatureLib: Add more CPU ID for SmmFeatureControl Jiewen Yao 2017-06-13 5:31 ` Fan, Jeff 2017-06-13 6:43 ` Yao, Jiewen
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox