public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: B Cran <rebecca@bluestop.org>
To: "Gao, Liming" <liming.gao@intel.com>
Cc: "edk2-devel@lists.01.org" <edk2-devel@lists.01.org>,
	"Tian, Feng" <feng.tian@intel.com>,
	"Zeng, Star" <star.zeng@intel.com>,
	"Fu, Siyuan" <siyuan.fu@intel.com>,
	"Wu, Jiaxin" <jiaxin.wu@intel.com>
Subject: Re: [PATCH] Fix some typos of "according"
Date: Tue, 7 Feb 2017 22:21:15 -0700	[thread overview]
Message-ID: <5438BF5E-AC6F-4AE3-A97D-78B1AD7DE986@bluestop.org> (raw)
In-Reply-To: <4A89E2EF3DFEDB4C8BFDE51014F606A14D6D7D39@shsmsx102.ccr.corp.intel.com>

Thanks!
> On Feb 7, 2017, at 10:07 PM, Gao, Liming <liming.gao@intel.com> wrote:
> 
> Reviewed-by: Liming Gao <liming.gao@intel.com>
> 
> To meet with edk2 patch policy, I will separate this patch per package, then push it. 
> 
>> -----Original Message-----
>> From: Rebecca Cran [mailto:rebecca@bluestop.org]
>> Sent: Wednesday, February 08, 2017 3:41 AM
>> To: edk2-devel@lists.01.org
>> Cc: Rebecca Cran <rebecca@bluestop.org>; Tian, Feng <feng.tian@intel.com>;
>> Zeng, Star <star.zeng@intel.com>; Fu, Siyuan <siyuan.fu@intel.com>; Wu,
>> Jiaxin <jiaxin.wu@intel.com>; Gao, Liming <liming.gao@intel.com>
>> Subject: [PATCH] Fix some typos of "according"
>> 
>> Cc: Feng Tian <feng.tian@intel.com>
>> Cc: Star Zeng <star.zeng@intel.com>
>> Cc: Siyuan Fu <siyuan.fu@intel.com>
>> Cc: Jiaxin Wu <jiaxin.wu@intel.com>
>> Cc: Liming Gao <liming.gao@intel.com>
>> Contributed-under: TianoCore Contribution Agreement 1.0
>> Signed-off-by: Rebecca Cran <rebecca@bluestop.org>
>> ---
>> EdkCompatibilityPkg/Sample/Tools/Source/UefiStrGather/StrGather.c | 2 +-
>> MdeModulePkg/Core/PiSmmCore/MemoryAttributesTable.c               | 4 ++--
>> MdeModulePkg/Library/DxeHttpLib/DxeHttpLib.c                      | 2 +-
>> MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbCmdMemory.c          | 2
>> +-
>> MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbCmdSymbol.c          | 6
>> +++---
>> MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbDisasmSupport.c      | 2
>> +-
>> MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbDisasmSupport.h      | 2
>> +-
>> MdeModulePkg/Universal/Network/Dhcp4Dxe/Dhcp4Impl.c               | 2 +-
>> NetworkPkg/HttpBootDxe/HttpBootConfigStrings.uni                  | 2 +-
>> 9 files changed, 12 insertions(+), 12 deletions(-)
>> 
>> diff --git
>> a/EdkCompatibilityPkg/Sample/Tools/Source/UefiStrGather/StrGather.c
>> b/EdkCompatibilityPkg/Sample/Tools/Source/UefiStrGather/StrGather.c
>> index 535a265046..e71b5e4e7d 100644
>> --- a/EdkCompatibilityPkg/Sample/Tools/Source/UefiStrGather/StrGather.c
>> +++ b/EdkCompatibilityPkg/Sample/Tools/Source/UefiStrGather/StrGather.c
>> @@ -854,7 +854,7 @@ GetLangCode (
>>  }
>> 
>>  //
>> -  // Convert the language accoring to the table.
>> +  // Convert the language according to the table.
>>  //
>>  for (Index = 0; LanguageConvertTable[Index].ISO639 != NULL; Index++) {
>>    if (wcscmp(LanguageConvertTable[Index].ISO639, Lang) == 0) {
>> diff --git a/MdeModulePkg/Core/PiSmmCore/MemoryAttributesTable.c
>> b/MdeModulePkg/Core/PiSmmCore/MemoryAttributesTable.c
>> index eba938e2a9..6cfd35945a 100644
>> --- a/MdeModulePkg/Core/PiSmmCore/MemoryAttributesTable.c
>> +++ b/MdeModulePkg/Core/PiSmmCore/MemoryAttributesTable.c
>> @@ -785,7 +785,7 @@ SmmCoreGetMemoryMapMemoryAttributesTable (
>> //
>> 
>> /**
>> -  Set MemoryProtectionAttribute accroding to PE/COFF image section
>> alignment.
>> +  Set MemoryProtectionAttribute according to PE/COFF image section
>> alignment.
>> 
>>  @param[in]  SectionAlignment    PE/COFF section alignment
>> **/
>> @@ -1225,7 +1225,7 @@ Finish:
>> }
>> 
>> /**
>> -  Find image record accroding to image base and size.
>> +  Find image record according to image base and size.
>> 
>>  @param[in]  ImageBase    Base of PE image
>>  @param[in]  ImageSize    Size of PE image
>> diff --git a/MdeModulePkg/Library/DxeHttpLib/DxeHttpLib.c
>> b/MdeModulePkg/Library/DxeHttpLib/DxeHttpLib.c
>> index a4579bf043..8734291ae3 100644
>> --- a/MdeModulePkg/Library/DxeHttpLib/DxeHttpLib.c
>> +++ b/MdeModulePkg/Library/DxeHttpLib/DxeHttpLib.c
>> @@ -396,7 +396,7 @@ HttpParseUrl (
>>  FoundAt = FALSE;
>>  for (Char = Url; Char < Url + Length; Char++) {
>>    //
>> -    // Update state machine accoring to next char.
>> +    // Update state machine according to next char.
>>    //
>>    State = NetHttpParseUrlChar (*Char, State);
>> 
>> diff --git
>> a/MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbCmdMemory.c
>> b/MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbCmdMemory.c
>> index 74c17bd248..3dc6376215 100644
>> --- a/MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbCmdMemory.c
>> +++ b/MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbCmdMemory.c
>> @@ -37,7 +37,7 @@ EdbDisplayMemoryUnit (
>>  UINT64 Data64;
>> 
>>  //
>> -  // Print accroding to width
>> +  // Print according to width
>>  //
>>  switch (Width) {
>>  case EdbWidthUint8:
>> diff --git
>> a/MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbCmdSymbol.c
>> b/MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbCmdSymbol.c
>> index ba62c6ac27..3ca793059f 100644
>> --- a/MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbCmdSymbol.c
>> +++ b/MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbCmdSymbol.c
>> @@ -70,7 +70,7 @@ GetDirNameFromFullPath (
>> 
>> /**
>> 
>> -  Construct full path accroding to dir and file path.
>> +  Construct full path according to dir and file path.
>> 
>>  @param  DirPath         - dir path
>>  @param  FilePath        - file path
>> @@ -127,7 +127,7 @@ EdbSymbolTypeToStr (
>> 
>> /**
>> 
>> -  Find the symbol accroding to address and display symbol.
>> +  Find the symbol according to address and display symbol.
>> 
>>  @param  Address         - SymbolAddress
>>  @param  DebuggerPrivate - EBC Debugger private data structure
>> @@ -190,7 +190,7 @@ DebuggerDisplaySymbolAccrodingToAddress (
>> 
>> /**
>> 
>> -  Find the symbol accroding to name and display symbol.
>> +  Find the symbol according to name and display symbol.
>> 
>>  @param  SymbolFileName  - The Symbol File Name, NULL means for all
>>  @param  SymbolName      - The Symbol Name, NULL means for all
>> diff --git
>> a/MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbDisasmSupport.c
>> b/MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbDisasmSupport.c
>> index 472158b8f9..26a86548b4 100644
>> --- a/MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbDisasmSupport.c
>> +++ b/MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbDisasmSupport.c
>> @@ -1178,7 +1178,7 @@ EdbShowDisasm (
>> 
>> /**
>> 
>> -  Get register value accroding to the system context, and register index.
>> +  Get register value according to the system context, and register index.
>> 
>>  @param  SystemContext   - EBC system context.
>>  @param  Index           - EBC register index
>> diff --git
>> a/MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbDisasmSupport.h
>> b/MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbDisasmSupport.h
>> index af5a7cab99..a95b5834a8 100644
>> --- a/MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbDisasmSupport.h
>> +++ b/MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbDisasmSupport.h
>> @@ -556,7 +556,7 @@ EdbShowDisasm (
>> 
>> /**
>> 
>> -  Get register value accroding to the system context, and register index.
>> +  Get register value according to the system context, and register index.
>> 
>>  @param  SystemContext   - EBC system context.
>>  @param  Index           - EBC register index
>> diff --git a/MdeModulePkg/Universal/Network/Dhcp4Dxe/Dhcp4Impl.c
>> b/MdeModulePkg/Universal/Network/Dhcp4Dxe/Dhcp4Impl.c
>> index 18796fdbfb..1db4c667d7 100644
>> --- a/MdeModulePkg/Universal/Network/Dhcp4Dxe/Dhcp4Impl.c
>> +++ b/MdeModulePkg/Universal/Network/Dhcp4Dxe/Dhcp4Impl.c
>> @@ -1215,7 +1215,7 @@ Dhcp4InstanceConfigUdpIo (
>>    // UEFI spec, while in classless addressing network, the netmask must be
>> explicitly
>>    // provided together with the station address.
>>    // If the DHCP instance haven't be configured with a valid netmask, we
>> could only
>> -    // compute it accroding to the classful addressing rule.
>> +    // compute it according to the classful addressing rule.
>>    //
>>    Class = NetGetIpClass (ClientAddr);
>>    ASSERT (Class < IP4_ADDR_CLASSE);
>> diff --git a/NetworkPkg/HttpBootDxe/HttpBootConfigStrings.uni
>> b/NetworkPkg/HttpBootDxe/HttpBootConfigStrings.uni
>> index 77c3186bb4..6cddafef83 100644
>> --- a/NetworkPkg/HttpBootDxe/HttpBootConfigStrings.uni
>> +++ b/NetworkPkg/HttpBootDxe/HttpBootConfigStrings.uni
>> @@ -22,6 +22,6 @@
>> #string STR_HTTP_BOOT_IP_VERSION_4            #language en-US "IP4"
>> #string STR_HTTP_BOOT_IP_VERSION_6            #language en-US "IP6"
>> #string STR_BOOT_URI_PROMPT                   #language en-US "Boot URI"
>> -#string STR_BOOT_URI_HELP                     #language en-US "A new Boot Option
>> will be created accroding to this Boot URI."
>> +#string STR_BOOT_URI_HELP                     #language en-US "A new Boot
>> Option will be created according to this Boot URI."
>> #string STR_BOOT_DESCRIPTION_PROMPT           #language en-US "Input the
>> description"
>> #string STR_NULL_STRING                       #language en-US ""
>> --
>> 2.11.0
> 



      reply	other threads:[~2017-02-08  5:21 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-07 19:40 [PATCH] Fix some typos of "according" Rebecca Cran
2017-02-08  0:58 ` Fu, Siyuan
2017-02-08  1:45 ` Zeng, Star
2017-02-08  2:04   ` Tian, Feng
2017-02-08  5:00 ` Wu, Jiaxin
2017-02-08  5:07 ` Gao, Liming
2017-02-08  5:21   ` B Cran [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5438BF5E-AC6F-4AE3-A97D-78B1AD7DE986@bluestop.org \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox