From: "Jeff Brasen via groups.io" <jbrasen=nvidia.com@groups.io>
To: <devel@edk2.groups.io>
Cc: <quic_llindhol@quicinc.com>, <ardb+tianocore@kernel.org>,
<Sami.Mujawar@arm.com>, <pierre.gondois@arm.com>,
Vidya Sagar <vidyas@nvidia.com>,
Shanker Donthineni <sdonthineni@nvidia.com>,
Jeff Brasen <jbrasen@nvidia.com>
Subject: [edk2-devel] [PATCH 2/2] DynamicTablesPkg: AcpiSsdtPcieLibArm: Use QWord to describe I/O range
Date: Mon, 11 Sep 2023 23:48:58 +0000 [thread overview]
Message-ID: <5454419ccfe1a9c34c2955d7c233eb44115034fb.1694475927.git.jbrasen@nvidia.com> (raw)
In-Reply-To: <cover.1694475927.git.jbrasen@nvidia.com>
From: Vidya Sagar <vidyas@nvidia.com>
Use AmlCodeGenRdQWordIo() to generate the I/O range in _CRS instead of
AmlCodeGenRdDWordIo() to cater to the scenarios where 64-bit addresses
can be used to generate I/O packets over the PCIe bus.
Reviewed-by: Shanker Donthineni <sdonthineni@nvidia.com>
Signed-off-by: Vidya Sagar <vidyas@nvidia.com>
Signed-off-by: Jeff Brasen <jbrasen@nvidia.com>
---
.../Library/Acpi/Arm/AcpiSsdtPcieLibArm/SsdtPcieGenerator.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtPcieLibArm/SsdtPcieGenerator.c b/DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtPcieLibArm/SsdtPcieGenerator.c
index c54ae6f551f6..9ddaddc198fa 100644
--- a/DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtPcieLibArm/SsdtPcieGenerator.c
+++ b/DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtPcieLibArm/SsdtPcieGenerator.c
@@ -540,7 +540,7 @@ GeneratePciCrs (
switch (AddrMapInfo->SpaceCode) {
case PCI_SS_IO:
- Status = AmlCodeGenRdDWordIo (
+ Status = AmlCodeGenRdQWordIo (
FALSE,
TRUE,
TRUE,
--
2.25.1
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#108508): https://edk2.groups.io/g/devel/message/108508
Mute This Topic: https://groups.io/mt/101305538/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
next prev parent reply other threads:[~2023-09-11 23:49 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-11 23:48 [edk2-devel] [PATCH 0/2] Add support for PCI IO using Qword resources Jeff Brasen via groups.io
2023-09-11 23:48 ` [edk2-devel] [PATCH 1/2] DynamicTablesPkg: AML Code generation for I/O ranges Jeff Brasen via groups.io
2023-09-12 9:35 ` Leif Lindholm
2023-09-12 9:55 ` PierreGondois
2023-09-12 19:32 ` Leif Lindholm
2023-09-12 19:04 ` Jeff Brasen via groups.io
2023-09-12 19:31 ` Leif Lindholm
2023-09-11 23:48 ` Jeff Brasen via groups.io [this message]
2023-09-12 8:54 ` [edk2-devel] [PATCH 0/2] Add support for PCI IO using Qword resources PierreGondois
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5454419ccfe1a9c34c2955d7c233eb44115034fb.1694475927.git.jbrasen@nvidia.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox