public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Laszlo Ersek <lersek@redhat.com>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: Ray Ni <ray.ni@intel.com>,
	qemu devel list <qemu-devel@nongnu.org>,
	edk2-devel-01 <edk2-devel@lists.01.org>,
	Markus Armbruster <armbru@redhat.com>
Subject: Re: nonzero LUN on USB Bulk Only Transfer fails with QEMU+edk2
Date: Tue, 19 Feb 2019 09:54:28 +0100	[thread overview]
Message-ID: <547c2b61-3f31-e958-ca7c-a5215dc8b017@redhat.com> (raw)
In-Reply-To: <20190219084916.yinhlryf4sgx7t5p@sirius.home.kraxel.org>

On 02/19/19 09:49, Gerd Hoffmann wrote:
>   Hi,
> 
>> (2) If I change the cmdline to "lun=5", then the exchange is:
> 
> Not supported (by the usb protocol).
> 
> The protocol has a control message to query the number of devices (grep
> for GetMaxLun in qemu).  LUNs are not allowed to be sparse.  So, with a
> single storage device the LUN must be zero.  With two devices the LUNs
> must be 0,1, with three 0,1,2 etc., you get the idea :)

Yes, Phil explained the same -- I originally missed this part of the
documentation (because the requirement is documented, so the fault is
clearly mine).

However, once I fixed the configuration (so that I'd have LUNs 0 and 1),
edk2 still tripped an assert. Please see my message elsewhere in this
thread; the fixed config case is marked as item (4).

Thanks!
Laszlo

> Maybe usb-bot should check for that and throw an error, I think right
> now we only have the generic scsi code check which will verify the lun
> isn't too big (<= 15) but will not check the non-sparse requirement.
> 
> cheers,
>   Gerd
> 



      reply	other threads:[~2019-02-19  8:54 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-13  8:37 nonzero LUN on USB Bulk Only Transfer fails with QEMU+edk2 Laszlo Ersek
2019-02-13 17:00 ` Philippe Mathieu-Daudé
2019-02-14  0:13   ` Laszlo Ersek
2019-02-19  8:49 ` Gerd Hoffmann
2019-02-19  8:54   ` Laszlo Ersek [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=547c2b61-3f31-e958-ca7c-a5215dc8b017@redhat.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox