From: "Ard Biesheuvel" <ard.biesheuvel@arm.com>
To: Laszlo Ersek <lersek@redhat.com>, devel@edk2.groups.io
Cc: liming.gao@intel.com, leif@nuviainc.com,
Hao A Wu <hao.a.wu@intel.com>, Ray Ni <ray.ni@intel.com>
Subject: Re: [edk2-devel] [PATCH] MdeModulePkg/NonDiscoverablePciDeviceDxe: connect handles on registration
Date: Fri, 22 May 2020 19:04:18 +0200 [thread overview]
Message-ID: <549622c2-b643-5039-90fc-e5b2a7de0037@arm.com> (raw)
In-Reply-To: <129aa70d-d72f-3bcc-8aca-76fc6859ddf2@redhat.com>
On 5/22/20 6:48 PM, Laszlo Ersek wrote:
> On 05/22/20 18:46, Laszlo Ersek wrote:
>
>> the spec led me to believe
>
> Well, if I had read a few more pages from the spec... It's totally my
> fault! :) sorry, it's Friday! :)
>
No worries, thanks for taking the time to dig into this.
I had already noticed that the DriverImageHandle[] approach does not
work, it indeed simply changes the order in which drivers are considered.
So I found a way to fix this in the BDS, which is not as clean as I
like, but not that intrusive either. It turns out the the existing code
plays nicely with the driver model in most cases, the only place where
it cuts corners is when it connects the short-form USB device path for
the console keyboard - this is the only place where it mucks around with
PCI I/O handles explicitly, to connect USB host controllers.
So we can simply do the same for non-discoverable uhci/ehci/xhci
devices, i.e., connect them non-recursively so that the PCI I/O protocol
as well as the USB host controller protocol are installed (which is
fine, as the latter was going to be installed by the BDS anyway)
prev parent reply other threads:[~2020-05-22 17:04 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-21 11:10 [PATCH] MdeModulePkg/NonDiscoverablePciDeviceDxe: connect handles on registration Ard Biesheuvel
2020-05-21 11:16 ` Leif Lindholm
2020-05-21 17:29 ` Ard Biesheuvel
2020-05-21 21:12 ` Laszlo Ersek
2020-05-21 21:58 ` [edk2-devel] " Ard Biesheuvel
2020-05-22 16:36 ` Laszlo Ersek
2020-05-22 16:46 ` Laszlo Ersek
2020-05-22 16:48 ` Laszlo Ersek
2020-05-22 17:04 ` Ard Biesheuvel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=549622c2-b643-5039-90fc-e5b2a7de0037@arm.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox