From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mx.groups.io with SMTP id smtpd.web10.85572.1670009517351978985 for ; Fri, 02 Dec 2022 11:31:57 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@linux.microsoft.com header.s=default header.b=Jws3HUKb; spf=pass (domain: linux.microsoft.com, ip: 13.77.154.182, mailfrom: mikuback@linux.microsoft.com) Received: from [192.168.4.22] (unknown [47.201.8.94]) by linux.microsoft.com (Postfix) with ESMTPSA id BBA1920B83C2; Fri, 2 Dec 2022 11:31:54 -0800 (PST) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com BBA1920B83C2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1670009516; bh=a0dvO7FVV/xcHxORERxwn36nlZiE2i9bt4Apxcvba/s=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=Jws3HUKbxBAwRA6bP5zPw4Nh4Ru3QmA/I7HKMSNKRbideUwmsdUfAMLtgpTmSVvM+ /fUU2kw8FUjX0GzXZCvyMmXIPbdjaQxZsmnUcjOFkYavc729CmkT5wnbQKbTk5lkvI Vduk+FzihT2P+boNvAX99xsaKgGbe8uektxCt+f0= Message-ID: <54a4bd5a-d8eb-26dc-3b19-37359628401d@linux.microsoft.com> Date: Fri, 2 Dec 2022 14:31:53 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.13.1 Subject: Re: [edk2-devel] [PATCH v10 07/17] CI: Use Fedora 35 container (Linux only) To: devel@edk2.groups.io, osteffen@redhat.com Cc: Andrew Fish , Ard Biesheuvel , Bob Feng , Daniel Schaefer , Gerd Hoffmann , Jiewen Yao , Jordan Justen , Leif Lindholm , Liming Gao , Michael D Kinney , Ray Ni , Sami Mujawar , Sean Brogan , Sunil V L , Yuwei Chen , Zhiguang Liu , Pawel Polawski , Chris Fernald References: <20221201202810.109662-1-osteffen@redhat.com> From: "Michael Kubacki" In-Reply-To: Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Reviewed-by: Michael Kubacki On 12/1/2022 3:28 PM, Oliver Steffen wrote: > Run all Linux based jobs in a container, using a custom Fedora 35 image > (gcc 11). The image is hosted on ghcr.io and the Dockerfiles are > here: https://github.com/tianocore/containers > The version numbers of gcc, iasl, and nasm are pinned to avoid > unintended upgrades during image rebuild. > > Do not run apt-get in CI jobs to install qemu and gcc dependencies. > Assume the container image provides these. > > Use Python from the container image, do not download at runtime. > > Signed-off-by: Oliver Steffen > --- > .azurepipelines/Ubuntu-GCC5.yml | 6 ++---- > .azurepipelines/templates/basetools-build-steps.yml | 9 --------- > 2 files changed, 2 insertions(+), 13 deletions(-) > > diff --git a/.azurepipelines/Ubuntu-GCC5.yml b/.azurepipelines/Ubuntu-GCC5.yml > index 4ed6cb601b8e..ca23b684e222 100644 > --- a/.azurepipelines/Ubuntu-GCC5.yml > +++ b/.azurepipelines/Ubuntu-GCC5.yml > @@ -13,14 +13,12 @@ pr: > - master > - stable/* > > -variables: > - - template: templates/defaults.yml > - > jobs: > - template: templates/pr-gate-build-job.yml > parameters: > tool_chain_tag: 'GCC5' > vm_image: 'ubuntu-latest' > + container: 'ghcr.io/tianocore/containers/fedora-35-build:2113a0e' > arch_list: "IA32,X64,ARM,AARCH64,RISCV64,LOONGARCH64" > - usePythonVersion: ${{ variables.default_python_version }} > + usePythonVersion: '' # use Python from the container image > > diff --git a/.azurepipelines/templates/basetools-build-steps.yml > b/.azurepipelines/templates/basetools-build-steps.yml > index d8c108c6e212..a72758bc3395 100644 > --- a/.azurepipelines/templates/basetools-build-steps.yml > +++ b/.azurepipelines/templates/basetools-build-steps.yml > @@ -10,15 +10,6 @@ parameters: > tool_chain_tag: '' > > steps: > -- ${{ if contains(parameters.tool_chain_tag, 'GCC') }}: > - - bash: sudo apt-get update > - displayName: Update apt > - condition: and(gt(variables.pkg_count, 0), succeeded()) > - > - - bash: sudo apt-get install gcc g++ make uuid-dev > - displayName: Install required tools > - condition: and(gt(variables.pkg_count, 0), succeeded()) > - > - task: CmdLine@1 > displayName: Build Base Tools from source > inputs: