From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
 by mx.groups.io with SMTP id smtpd.web12.10649.1597133650031150200
 for <devel@edk2.groups.io>;
 Tue, 11 Aug 2020 01:14:10 -0700
Authentication-Results: mx.groups.io;
 dkim=missing; spf=pass (domain: arm.com, ip: 217.140.110.172, mailfrom: ard.biesheuvel@arm.com)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
	by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 2D2021063;
	Tue, 11 Aug 2020 01:14:09 -0700 (PDT)
Received: from [192.168.178.54] (unknown [172.31.20.19])
	by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 62F463F22E;
	Tue, 11 Aug 2020 01:14:08 -0700 (PDT)
Subject: Re: [PATCH v9 04/16] ArmVirtPkg/ArmVirtPkg.ci.yaml: Add configuration for Ecc check
To: Shenglei Zhang <shenglei.zhang@intel.com>, devel@edk2.groups.io
Cc: Laszlo Ersek <lersek@redhat.com>, Leif Lindholm <leif@nuviainc.com>
References: <20200811070204.55160-1-shenglei.zhang@intel.com>
 <20200811070204.55160-5-shenglei.zhang@intel.com>
From: "Ard Biesheuvel" <ard.biesheuvel@arm.com>
Message-ID: <54e98e13-5f3f-f1c2-bb7f-e6c20f4539af@arm.com>
Date: Tue, 11 Aug 2020 10:14:06 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.7.0
MIME-Version: 1.0
In-Reply-To: <20200811070204.55160-5-shenglei.zhang@intel.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit

On 8/11/20 9:01 AM, Shenglei Zhang wrote:
> Add configuration ExceptionList and IgnoreFiles for package config
> files. So users can rely on this to ignore some Ecc issues.
> 
> Cc: Laszlo Ersek <lersek@redhat.com>
> Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>
> Cc: Leif Lindholm <leif@nuviainc.com>
> Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
> Reviewed-by: Liming Gao <liming.gao@intel.com>

Acked-by: Ard Biesheuvel <ard.biesheuvel@arm.com>

> ---
>   ArmVirtPkg/ArmVirtPkg.ci.yaml | 12 ++++++++++++
>   1 file changed, 12 insertions(+)
> 
> diff --git a/ArmVirtPkg/ArmVirtPkg.ci.yaml b/ArmVirtPkg/ArmVirtPkg.ci.yaml
> index 27bb7ff49011..8b2c0305c175 100644
> --- a/ArmVirtPkg/ArmVirtPkg.ci.yaml
> +++ b/ArmVirtPkg/ArmVirtPkg.ci.yaml
> @@ -5,6 +5,7 @@
>   # used for code analysis.
>   #
>   # Copyright (c) Microsoft Corporation
> +# Copyright (c) 2020, Intel Corporation. All rights reserved.<BR>
>   # SPDX-License-Identifier: BSD-2-Clause-Patent
>   ##
>   {
> @@ -12,6 +13,17 @@
>       "LicenseCheck": {
>           "IgnoreFiles": []
>       },
> +    "EccCheck": {
> +        ## Exception sample looks like below:
> +        ## "ExceptionList": [
> +        ##     "<ErrorID>", "<KeyWord>"
> +        ## ]
> +        "ExceptionList": [
> +        ],
> +        ## Both file path and directory path are accepted.
> +        "IgnoreFiles": [
> +        ]
> +    },
>       ## options defined .pytool/Plugin/CompilerPlugin
>       "CompilerPlugin": {
>           "DscPath": "" # Don't support this test
>